Fixed following SonarQube issues:

1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation, 
6. A while loop should be used instead of a 'for' loop.

web/pgadmin/static/js/codemirror/addon/fold/pgadmin-sqlfoldcode.js

@@ -26,7 +26,7 @@
     let tokenSetNo = 0;
     let startTkn = tokenSet[tokenSetNo].start,
       endTkn = tokenSet[tokenSetNo].end;
-    for (; at > 0;) {
+    while (at > 0) {
       var found = lineText.lastIndexOf(startTkn, at);
       var startToken = startTkn;
       var endToken = endTkn;
@@ -57,7 +57,8 @@
     outer: for (var i = line + 1; i < lastLine; ++i) {
       var text = cm.getLine(i),
         pos = 0;
-      for (;;) {
+      var whileloopvar = 0;
+      while (whileloopvar < 1) {
         var nextOpen = text.indexOf(startToken, pos),
           nextClose = text.indexOf(endToken, pos);
         if (nextOpen < 0) nextOpen = text.length;

web/pgadmin/static/js/pgadmin.js

@@ -66,7 +66,7 @@ define([], function() {
       c = [1 / 25.4, 1 / 2.54, 1 / 72, 1 / 6],
       f = ['mm', 'cm', 'pt', 'pc', 'in', 'mozmm'],
       u = 6;
-    for (i.appendChild(n), m && (n.style.marginTop = '1%', p = '1%' === m(n).marginTop); u--;) d[f[u] + 'toPx'] = c[u] ? c[u] * d.inToPx : r(n, '1' + f[u]);
+    for (i.appendChild(n), m && ((n.style.marginTop = '1%'), (p = '1%' === m(n).marginTop)); u--;) d[f[u] + 'toPx'] = c[u] ? c[u] * d.inToPx : r(n, '1' + f[u]);
     i.removeChild(n); t.toPx = r;
   })(pgAdmin, window.document);
 

web/pgadmin/static/js/sqleditor_utils.js

@@ -191,7 +191,8 @@ define(['jquery', 'underscore', 'sources/gettext', 'sources/url_for'],
 
       calcFontSize: function(fontSize) {
         if(fontSize) {
-          let rounded = Number((Math.round(fontSize + 'e+2') + 'e-2'));
+          fontSize = parseFloat((Math.round(parseFloat(fontSize + 'e+2')) + 'e-2'));
+          let rounded = Number(fontSize);
           if(rounded > 0) {
             return rounded + 'em';
           }