Fixed SonarQube issues.

This commit is contained in:
Akshay Joshi
2022-09-08 18:08:58 +05:30
parent 603ce21d24
commit 7086719640
129 changed files with 945 additions and 981 deletions

View File

@@ -44,7 +44,7 @@ define('pgadmin.node.role', [
hasSQL: true,
width: '550px',
canDrop: function(node, item) {
var treeData = pgBrowser.tree.getTreeNodeHierarchy(item),
let treeData = pgBrowser.tree.getTreeNodeHierarchy(item),
server = treeData['server'];
/*
To Drop a role:
@@ -112,13 +112,13 @@ define('pgadmin.node.role', [
}]);
},
can_create_role: function(node, item) {
var treeData = pgBrowser.tree.getTreeNodeHierarchy(item),
let treeData = pgBrowser.tree.getTreeNodeHierarchy(item),
server = treeData['server'];
return server.connected && server.user.can_create_role;
},
can_reassign_role: function(node, item) {
var treeData = pgBrowser.tree.getTreeNodeHierarchy(item),
let treeData = pgBrowser.tree.getTreeNodeHierarchy(item),
server = treeData['server'];
return server.connected && node.can_login;

View File

@@ -49,16 +49,16 @@ export default class RoleSchema extends BaseUISchema {
}
readOnly(state) {
var user = this.nodeInfo.server.user;
let user = this.nodeInfo.server.user;
this.oid = state.oid;
this.isReadOnly = !(user.is_superuser || user.can_create_role);
return (!(user.is_superuser || user.can_create_role) && user.id != state.oid);
}
memberDataFormatter(rawData) {
var members = '';
let members = '';
if(_.isObject(rawData)) {
var withAdmin = '';
let withAdmin = '';
rawData.forEach(member => {
if(member.admin) { withAdmin = ' [WITH ADMIN]';}