IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed SonarQube issues.

Browse Source
This commit is contained in:
Akshay Joshi
2022-09-08 18:08:58 +05:30
parent 603ce21d24
commit 7086719640
129 changed files with 945 additions and 981 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
web/pgadmin/tools/backup/static/js/backup.js
View File

@@ -55,7 +55,7 @@ define([
this.initialized = true;
// Define the nodes on which the menus to be appear
var menus = [{
let menus = [{
name: 'backup_global',
module: this,
applies: ['tools'],
@@ -142,36 +142,36 @@ define([
},
startBackupGlobal: function(action, treeItem) {
pgBrowser.Node.registerUtilityPanel();
var panel = pgBrowser.Node.addUtilityPanel(pgBrowser.stdW.md);
var tree = pgBrowser.tree,
let panel = pgBrowser.Node.addUtilityPanel(pgBrowser.stdW.md);
let tree = pgBrowser.tree,
i = treeItem || tree.selected(),
data = i ? tree.itemData(i) : undefined,
j = panel.$container.find('.obj_properties').first();
var schema = this.getGlobalUISchema(treeItem);
let schema = this.getGlobalUISchema(treeItem);
panel.title('Backup Globals');
panel.focus();
var typeOfDialog = 'globals';
var serverIdentifier = this.retrieveServerIdentifier();
let typeOfDialog = 'globals';
let serverIdentifier = this.retrieveServerIdentifier();
var extraData = this.setExtraParameters(typeOfDialog);
let extraData = this.setExtraParameters(typeOfDialog);
this.showBackupDialog(schema, treeItem, j, data, panel, typeOfDialog, serverIdentifier, extraData);
},
startBackupServer: function(action, treeItem) {
pgBrowser.Node.registerUtilityPanel();
var panel = pgBrowser.Node.addUtilityPanel(pgBrowser.stdW.md);
var tree = pgBrowser.tree,
let panel = pgBrowser.Node.addUtilityPanel(pgBrowser.stdW.md);
let tree = pgBrowser.tree,
i = treeItem || tree.selected(),
data = i ? tree.itemData(i) : undefined,
j = panel.$container.find('.obj_properties').first();
var schema = this.getUISchema(treeItem, 'server');
let schema = this.getUISchema(treeItem, 'server');
panel.title(gettext('Backup Server'));
panel.focus();
var typeOfDialog = 'server';
var serverIdentifier = this.retrieveServerIdentifier();
let typeOfDialog = 'server';
let serverIdentifier = this.retrieveServerIdentifier();
var extraData = this.setExtraParameters(typeOfDialog);
let extraData = this.setExtraParameters(typeOfDialog);
this.showBackupDialog(schema, treeItem, j, data, panel, typeOfDialog, serverIdentifier, extraData);
},
saveCallBack: function(data) {
@@ -202,8 +202,8 @@ define([
const baseUrl = url_for(urlShortcut, {
'sid': serverIdentifier,
});
var sqlHelpUrl = 'backup.html';
var helpUrl = url_for('help.static', {
let sqlHelpUrl = 'backup.html';
let helpUrl = url_for('help.static', {
'filename': this.getHelpFile(typeOfDialog),
});
getUtilityView(
@@ -212,8 +212,8 @@ define([
},
// Callback to draw Backup Dialog for objects
backupObjects: function(action, treeItem) {
var that = this;
var tree = pgBrowser.tree,
let that = this;
let tree = pgBrowser.tree,
i = treeItem || tree.selected(),
data = i ? tree.itemData(i) : undefined;
@@ -235,14 +235,14 @@ define([
}
pgBrowser.Node.registerUtilityPanel();
var panel = pgBrowser.Node.addUtilityPanel(pgBrowser.stdW.md, pgBrowser.stdH.lg),
let panel = pgBrowser.Node.addUtilityPanel(pgBrowser.stdW.md, pgBrowser.stdH.lg),
j = panel.$container.find('.obj_properties').first();
var schema = that.getUISchema(treeItem, 'backup_objects');
let schema = that.getUISchema(treeItem, 'backup_objects');
panel.title(gettext(`Backup (${pgBrowser.Nodes[data._type].label}: ${data.label})`));
panel.focus();
var typeOfDialog = 'backup_objects',
let typeOfDialog = 'backup_objects',
serverIdentifier = that.retrieveServerIdentifier(),
extraData = that.setExtraParameters(typeOfDialog);
@@ -286,14 +286,14 @@ define([
retrieveServerIdentifier() {
const selectedNode = pgBrowser.tree.selected();
var node = pgBrowser.tree.findNodeByDomElement(selectedNode);
let node = pgBrowser.tree.findNodeByDomElement(selectedNode);
const treeInfo = pgBrowser.tree.getTreeNodeHierarchy(node);
return treeInfo.server._id;
},
setExtraParameters(typeOfDialog) {
var extraData = {};
let extraData = {};
const selectedNode = pgBrowser.tree.selected();
var selectedTreeNode = pgBrowser.tree.findNodeByDomElement(selectedNode);
let selectedTreeNode = pgBrowser.tree.findNodeByDomElement(selectedNode);
const treeInfo = pgBrowser.tree.getTreeNodeHierarchy(selectedTreeNode);
if (typeOfDialog === 'backup_objects') {

10
web/pgadmin/tools/backup/static/js/backup.ui.js
View File

@@ -181,7 +181,7 @@ export class SaveOptSchema extends BaseUISchema {
disabled: false,
group: gettext('Do not save'),
visible: function() {
var serverInfo = _.isUndefined(obj.fieldOptions.nodeInfo) ? undefined : obj.fieldOptions.nodeInfo.server;
let serverInfo = _.isUndefined(obj.fieldOptions.nodeInfo) ? undefined : obj.fieldOptions.nodeInfo.server;
return _.isUndefined(serverInfo) ? false : serverInfo.version >= 110000;
},
@@ -267,7 +267,7 @@ export class QueryOptionSchema extends BaseUISchema {
if (!_.isUndefined(obj.backupType) && obj.backupType === 'server')
return false;
var serverInfo = _.isUndefined(obj.fieldOptions.nodeInfo) ? undefined : obj.fieldOptions.nodeInfo.server;
let serverInfo = _.isUndefined(obj.fieldOptions.nodeInfo) ? undefined : obj.fieldOptions.nodeInfo.server;
return _.isUndefined(serverInfo) ? false : serverInfo.version >= 110000;
},
@@ -349,7 +349,7 @@ export class MiscellaneousSchema extends BaseUISchema {
deps: ['use_column_inserts', 'use_insert_commands'],
group: gettext('Miscellaneous'),
disabled: function(state) {
var serverInfo = _.isUndefined(obj.fieldOptions.nodeInfo) ? undefined : obj.fieldOptions.nodeInfo.server;
let serverInfo = _.isUndefined(obj.fieldOptions.nodeInfo) ? undefined : obj.fieldOptions.nodeInfo.server;
if (!_.isUndefined(serverInfo) && serverInfo.version >= 120000)
return true;
@@ -418,7 +418,7 @@ export default class BackupSchema extends BaseUISchema {
}
get baseFields() {
var obj = this;
let obj = this;
return [{
id: 'file',
label: gettext('Filename'),
@@ -480,7 +480,7 @@ export default class BackupSchema extends BaseUISchema {
options: obj.fieldOptions.encoding,
visible: function() {
if (!_.isUndefined(obj.backupType) && obj.backupType === 'server') {
var dbNode = obj.pgBrowser.serverInfo[obj.treeNodeInfo.server._id];
let dbNode = obj.pgBrowser.serverInfo[obj.treeNodeInfo.server._id];
return _.isUndefined(dbNode) ? false : dbNode.version >= 110000;
}
return true;

2
web/pgadmin/tools/backup/static/js/backupGlobal.ui.js
View File

@@ -65,7 +65,7 @@ export default class BackupGlobalSchema extends BaseUISchema {
}
get baseFields() {
var obj = this;
let obj = this;
return [{
id: 'file',
label: gettext('Filename'),