IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed SonarQube issues.

Browse Source
This commit is contained in:
Akshay Joshi
2022-09-08 18:08:58 +05:30
parent 603ce21d24
commit 7086719640
129 changed files with 945 additions and 981 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
web/pgadmin/tools/sqleditor/static/js/SQLEditorModule.js
View File

@@ -55,7 +55,7 @@ export default class SQLEditor {
* otherwise disabled.
*/
viewMenuEnabled(obj) {
var isEnabled = (() => {
let isEnabled = (() => {
if (!_.isUndefined(obj) && !_.isNull(obj))
return (_.indexOf(this.SUPPORTED_NODES, obj._type) !== -1 ? true : false);
else
@@ -73,7 +73,7 @@ export default class SQLEditor {
* otherwise enabled.
*/
queryToolMenuEnabled(obj) {
var isEnabled = (() => {
let isEnabled = (() => {
if (!_.isUndefined(obj) && !_.isNull(obj)) {
if (_.indexOf(pgAdmin.unsupported_nodes, obj._type) == -1) {
if (obj._type == 'database' && obj.allowConn) {
@@ -116,7 +116,7 @@ export default class SQLEditor {
});
// Define the nodes on which the menus to be appear
var menus = [{
let menus = [{
name: 'query_tool',
module: this,
applies: ['tools'],
@@ -192,7 +192,7 @@ export default class SQLEditor {
pgBrowser.add_menus(menus);
// Creating a new pgAdmin.Browser frame to show the data.
var frame = new pgAdmin.Browser.Frame({
let frame = new pgAdmin.Browser.Frame({
name: 'frm_sqleditor',
showTitle: true,
isCloseable: true,
@@ -220,15 +220,15 @@ export default class SQLEditor {
// This is a callback function to show query tool when user click on menu item.
showQueryTool(url, treeIdentifier) {
const transId = commonUtils.getRandomInt(1, 9999999);
var t = pgBrowser.tree,
let t = pgBrowser.tree,
i = treeIdentifier || t.selected(),
d = i ? t.itemData(i) : undefined;
//Open query tool with create script if copy_sql_to_query_tool is true else open blank query tool
var preference = pgBrowser.get_preference('sqleditor', 'copy_sql_to_query_tool');
let preference = pgBrowser.get_preference('sqleditor', 'copy_sql_to_query_tool');
if(preference.value && !d._type.includes('coll-') && (url === '' || url['applies'] === 'tools')){
var stype = d._type.toLowerCase();
var data = {
let stype = d._type.toLowerCase();
let data = {
'script': stype,
data_disabled: gettext('The selected tree node does not support this option.'),
};
@@ -260,9 +260,9 @@ export default class SQLEditor {
openQueryToolPanel(trans_id, is_query_tool, panel_title, closeUrl, queryToolForm) {
let self = this;
var browser_preferences = pgBrowser.get_preferences_for_module('browser');
var propertiesPanel = pgBrowser.docker.findPanels('properties');
var queryToolPanel = pgBrowser.docker.addPanel('frm_sqleditor', wcDocker.DOCK.STACKED, propertiesPanel[0]);
let browser_preferences = pgBrowser.get_preferences_for_module('browser');
let propertiesPanel = pgBrowser.docker.findPanels('properties');
let queryToolPanel = pgBrowser.docker.addPanel('frm_sqleditor', wcDocker.DOCK.STACKED, propertiesPanel[0]);
queryToolPanel.trans_id = trans_id;
showQueryTool._set_dynamic_tab(pgBrowser, browser_preferences['dynamic_tabs']);
@@ -281,7 +281,7 @@ export default class SQLEditor {
self.onPanelRename(queryToolPanel, panelData, is_query_tool);
});
var openQueryToolURL = function(j) {
let openQueryToolURL = function(j) {
// add spinner element
let $spinner_el =
$(`<div class="pg-sp-container">
@@ -293,10 +293,10 @@ export default class SQLEditor {
</div>`).appendTo($(j).data('embeddedFrame').$container);
let init_poller_id = setInterval(function() {
var frameInitialized = $(j).data('frameInitialized');
let frameInitialized = $(j).data('frameInitialized');
if (frameInitialized) {
clearInterval(init_poller_id);
var frame = $(j).data('embeddedFrame');
let frame = $(j).data('embeddedFrame');
if (frame) {
frame.onLoaded(()=>{
$spinner_el.remove();
@@ -336,10 +336,10 @@ export default class SQLEditor {
</script>
`;
var browser_preferences = pgBrowser.get_preferences_for_module('browser');
var open_new_tab = browser_preferences.new_browser_tab_open;
let browser_preferences = pgBrowser.get_preferences_for_module('browser');
let open_new_tab = browser_preferences.new_browser_tab_open;
if (open_new_tab && open_new_tab.includes('qt')) {
var newWin = window.open('', '_blank');
let newWin = window.open('', '_blank');
if(newWin) {
newWin.document.write(queryToolForm);
newWin.document.title = panel_title;

4
web/pgadmin/tools/sqleditor/static/js/show_query_tool.js
View File

@@ -125,7 +125,7 @@ export function launchQueryTool(queryToolMod, transId, gridUrl, queryToolTitle,
}
export function _set_dynamic_tab(pgBrowser, value){
var sqleditor_panels = pgBrowser.docker.findPanels('frm_sqleditor');
let sqleditor_panels = pgBrowser.docker.findPanels('frm_sqleditor');
const process = panel => {
if(value) {
$('#' + panel.$title.index() + ' div:first').addClass('wcPanelTab-dynamic');
@@ -135,6 +135,6 @@ export function _set_dynamic_tab(pgBrowser, value){
};
sqleditor_panels.forEach(process);
var debugger_panels = pgBrowser.docker.findPanels('frm_debugger');
let debugger_panels = pgBrowser.docker.findPanels('frm_debugger');
debugger_panels.forEach(process);
}

12
web/pgadmin/tools/sqleditor/static/js/show_view_data.js
View File

@@ -141,7 +141,7 @@ function generateUrl(trans_id, connectionData, nodeData, parentData) {
function generateFilterValidateUrl(nodeData, parentData) {
// Create url to validate the SQL filter
var url_params = {
let url_params = {
'sid': parentData.server._id,
'did': parentData.database._id,
'obj_id': nodeData._id,
@@ -157,12 +157,12 @@ function showFilterDialog(pgBrowser, treeNodeInfo, queryToolMod, transId,
// Register dialog panel
pgBrowser.Node.registerUtilityPanel();
var panel = pgBrowser.Node.addUtilityPanel(pgBrowser.stdW.md),
let panel = pgBrowser.Node.addUtilityPanel(pgBrowser.stdW.md),
j = panel.$container.find('.obj_properties').first();
panel.title(gettext('Data Filter - %s', queryToolTitle));
panel.focus();
var helpUrl = url_for('help.static', {'filename': 'viewdata_filter.html'});
let helpUrl = url_for('help.static', {'filename': 'viewdata_filter.html'});
let okCallback = function() {
queryToolMod.launch(transId, gridUrl, false, queryToolTitle, null, schema._sessData.filter_sql);
@@ -182,7 +182,7 @@ function hasSchemaOrCatalogOrViewInformation(parentData) {
}
export function generateViewDataTitle(pgBrowser, treeIdentifier, custom_title=null, backend_entity=null) {
var preferences = pgBrowser.get_preferences_for_module('browser');
let preferences = pgBrowser.get_preferences_for_module('browser');
const parentData = pgBrowser.tree.getTreeNodeHierarchy(
treeIdentifier
);
@@ -191,7 +191,7 @@ export function generateViewDataTitle(pgBrowser, treeIdentifier, custom_title=nu
const db_label = !_.isUndefined(backend_entity) && backend_entity != null && backend_entity.hasOwnProperty('db_name') ? backend_entity['db_name'] : getDatabaseLabel(parentData);
const node = pgBrowser.tree.findNodeByDomElement(treeIdentifier);
var dtg_title_placeholder = '';
let dtg_title_placeholder = '';
if(custom_title) {
dtg_title_placeholder = custom_title;
} else {
@@ -199,7 +199,7 @@ export function generateViewDataTitle(pgBrowser, treeIdentifier, custom_title=nu
}
var title_data = {
let title_data = {
'database': db_label,
'username': parentData.server.user.name,
'server': parentData.server.label,

6
web/pgadmin/tools/sqleditor/static/js/sqleditor_title.js
View File

@@ -43,7 +43,7 @@ export function getTitle(pgAdmin, browserPref, parentData=null, isConnTitle=fals
}
export function getPanelTitle(pgBrowser, selected_item=null, custom_title=null, parentData=null, conn_title=false, db_label=null) {
var preferences = pgBrowser.get_preferences_for_module('browser');
let preferences = pgBrowser.get_preferences_for_module('browser');
if(selected_item == null && parentData == null) {
selected_item = pgBrowser.tree.selected();
}
@@ -60,7 +60,7 @@ export function getPanelTitle(pgBrowser, selected_item=null, custom_title=null,
db_label = getDatabaseLabel(parentData);
}
var qt_title_placeholder = '';
let qt_title_placeholder = '';
if (!conn_title) {
if (custom_title) {
qt_title_placeholder = custom_title;
@@ -71,7 +71,7 @@ export function getPanelTitle(pgBrowser, selected_item=null, custom_title=null,
qt_title_placeholder = pgAdmin['qt_default_placeholder'];
}
var title_data = {
let title_data = {
'database': db_label,
'username': parentData.server.user.name,
'server': parentData.server._label,