Fixed some SonarQube issues.

This commit is contained in:
Yogesh Mahajan
2022-08-30 14:21:33 +05:30
committed by Akshay Joshi
parent af1e9210b9
commit 71a4b20d90
10 changed files with 94 additions and 133 deletions

View File

@@ -66,7 +66,7 @@ PolyLine.propTypes = {
function Multitext({currentXpos, currentYpos, label, maxWidth}) {
const theme = useTheme();
let abc = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
var xmlns = 'https://www.w3.org/2000/svg';
var xmlns = 'http://www.w3.org/2000/svg';
var svgElem = document.createElementNS(xmlns, 'svg');
svgElem.setAttributeNS(xmlns, 'height', '100%');
svgElem.setAttributeNS(xmlns, 'width', '100%');
@@ -387,7 +387,7 @@ export default function Graphical({planData, ctx}) {
const onDownloadClick = ()=>{
downloadSvg(ReactDOMServer.renderToStaticMarkup(
<PlanSVG planData={planData} download={true} ctx={ctx} zoomFactor={INIT_ZOOM_FACTOR} onNodeClick={()=>{}}/>
<PlanSVG planData={planData} download={true} ctx={ctx} zoomFactor={INIT_ZOOM_FACTOR} onNodeClick={()=>{/*This is intentional (SonarQube)*/}}/>
), 'explain_plan_' + (new Date()).getTime() + '.svg');
};

View File

@@ -442,27 +442,25 @@ function parsePlanData(data, ctx) {
'Triggers': [],
'Summary': {},
};
if (data && 'JIT' in data) {
if ('JIT' in data) {
retPlan['Statistics']['JIT'] = retPlan['JIT'];
}
if (data && 'Triggers' in data) {
if ('Triggers' in data) {
retPlan['Statistics']['Triggers'] = retPlan['JITriggersT'];
}
if(data) {
let summKeys = ['Planning Time', 'Execution Time'],
summary = {};
summKeys.forEach((key)=>{
if (key in data) {
summary[key] = data[key];
}
});
retPlan['Statistics']['Summary'] = summary;
}
if (data && 'Settings' in data) {
if ('Settings' in data) {
retPlan['Statistics']['Settings'] = data['Settings'];
}
let summKeys = ['Planning Time', 'Execution Time'],
summary = {};
summKeys.forEach((key)=>{
if (key in data) {
summary[key] = data[key];
}
});
retPlan['Statistics']['Summary'] = summary;
parseExplainTableData(retPlan['Plan'], ctx);
}