IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2026-09-03 20:52:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixed chrome driver download utility issue for Ubuntu. Fixes #4942

Browse Source
This commit is contained in:
Murtuza Zabuawala
2020-03-12 11:18:07 +05:30
committed by Akshay Joshi
parent 6586be5158
commit 7cc30e3216
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/en_US/release_notes_4_20.rst
+1
View File
@@ -18,4 +18,5 @@ Bug fixes
********* *********
| `Issue #4237 <https://redmine.postgresql.org/issues/4237>`_ - Fix an issue where the user can not change the value of DateTime picker control using keyboard. | `Issue #4237 <https://redmine.postgresql.org/issues/4237>`_ - Fix an issue where the user can not change the value of DateTime picker control using keyboard.
| `Issue #4942 <https://redmine.postgresql.org/issues/4942>`_ - Fixed chrome driver download utility issue for Ubuntu.
| `Issue #5143 <https://redmine.postgresql.org/issues/5143>`_ - Fix an accessibility issue to maximize the panel for all alertify dialog. | `Issue #5143 <https://redmine.postgresql.org/issues/5143>`_ - Fix an accessibility issue to maximize the panel for all alertify dialog.
tools/get_chromedriver.py
+5
View File
@@ -102,6 +102,11 @@ def get_chrome_version(args):
print('The specified Chrome executable output an unexpected ' print('The specified Chrome executable output an unexpected '
'version string: {}.'.format(version_str)) 'version string: {}.'.format(version_str))
sys.exit(1) sys.exit(1)
# On some linux distro `chrome--version` gives output like
# 'Google Chrome 80.0.3987.132 unknown\n'
# so we need to check and remove the unknown string from the version
if version_str.endswith("unknown\n"):
version_str = version_str.strip("unknown\n").strip()
chrome_version = '.'.join(version_str.split()[-1].split('.')[:-1]) chrome_version = '.'.join(version_str.split()[-1].split('.')[:-1])