Fixed the SoanrQube code smell 'Variables should not be shadowed'.

web/pgadmin/static/js/select2/configure_show_on_scroll.js

@@ -11,10 +11,10 @@ export default function (options) {
      * The trick is, ajax: {} will also work even if you're actually not
      * using ajax.
      */
-    let ScrollDataAdapter = function ($element, options) {
+    let ScrollDataAdapter = function ($element, dropdownOptions) {
       this.$element = $element;
-      this.options = options;
-      this._dataToConvert = options.get('data') || [];
+      this.options = dropdownOptions;
+      this._dataToConvert = dropdownOptions.get('data') || [];
     };
 
     let BaseAdapter = null;

web/pgadmin/static/js/selection/xcell_selection_model.js

@@ -142,12 +142,12 @@ define([
       function shouldScrollToRightmostColumn() { return anchorActiveCell.cell === newSelectedRange.fromCell; }
 
       function getMobileCellFromRange(range, activeCell) {
-        var mobileCell = {};
+        var localMobileCell = {};
 
-        mobileCell.row = range.fromRow === activeCell.row ? range.toRow : range.fromRow;
-        mobileCell.cell = range.fromCell === activeCell.cell ? range.toCell : range.fromCell;
+        localMobileCell.row = range.fromRow === activeCell.row ? range.toRow : range.fromRow;
+        localMobileCell.cell = range.fromCell === activeCell.cell ? range.toCell : range.fromCell;
 
-        return mobileCell;
+        return localMobileCell;
       }
 
       function getNewRange(rangeCorner, oppositeCorner) {

web/pgadmin/static/js/sqleditor/filter_dialog.js

@@ -230,9 +230,9 @@ let FilterDialog = {
                     self.showFilterProgress[0]
                   ).addClass('d-none');
 
-                  let response = result.data.data;
+                  let filterResponse = result.data.data;
 
-                  if (response.status) {
+                  if (filterResponse.status) {
                     setTimeout(
                       function() {
                         self.close(); // Close the dialog now
@@ -243,7 +243,7 @@ let FilterDialog = {
                   } else {
                     Alertify.alert(
                       gettext('Validation Error'),
-                      response.result
+                      filterResponse.result
                     );
                   }
 

web/pgadmin/static/js/window.js

@@ -12,22 +12,22 @@ let getWindowOpener = (opener) => {
 };
 
 let pgWindow = function() {
-  let pgWindow = null;
+  let localPgWindow = null;
   try {
     if(window.opener && window.opener.pgAdmin) {
       /* Windows can be opened at multiple levels */
-      pgWindow = getWindowOpener(window.opener);
+      localPgWindow = getWindowOpener(window.opener);
     } else if(window.parent && window.parent.pgAdmin){
-      pgWindow = window.parent;
+      localPgWindow = window.parent;
     } else if(window.top && window.top.pgAdmin){
-      pgWindow = window.top;
+      localPgWindow = window.top;
     } else {
-      pgWindow = window;
+      localPgWindow = window;
     }
   } catch (error) {
-    pgWindow = window;
+    localPgWindow = window;
   }
-  return pgWindow;
+  return localPgWindow;
 }();
 
 export default pgWindow;

web/pgadmin/static/vendor/backgrid/backgrid-select-all.js

@@ -57,13 +57,13 @@
       }
 
       var column = this.column, model = this.model, $el = this.$el;
-      this.listenTo(column, "change:renderable", function (column, renderable) {
+      this.listenTo(column, "change:renderable", function (col, renderable) {
         $el.toggleClass("renderable", renderable);
       });
 
       if (Backgrid.callByNeed(column.renderable(), column, model)) $el.addClass("renderable");
 
-      this.listenTo(model, "backgrid:select", function (model, selected) {
+      this.listenTo(model, "backgrid:select", function (mod, selected) {
         this.checkbox().prop("checked", selected).change();
       });
     },
@@ -214,7 +214,7 @@
       });
 
       var column = this.column, $el = this.$el;
-      this.listenTo(column, "change:renderable", function (column, renderable) {
+      this.listenTo(column, "change:renderable", function (col, renderable) {
         $el.toggleClass("renderable", renderable);
       });