IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix SonarQube code smells:

Browse Source 
1) String literals should not be duplicated.
2) Prefer using an optional chain expression instead, as it's more concise and easier to read.
3) Expected the Promise rejection reason to be an Error.
This commit is contained in:
Akshay Joshi
2024-06-10 18:04:32 +05:30
parent 2d2aa45ec5
commit 8857f0d179
57 changed files with 210 additions and 205 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
web/pgadmin/misc/properties/ObjectNodeProperties.jsx
View File

@@ -25,7 +25,7 @@ export default function ObjectNodeProperties({panelId, node, treeNodeInfo, nodeD
const nodeType = nodeData?._type;
const pgAdmin = usePgAdmin();
let serverInfo = treeNodeInfo && ('server' in treeNodeInfo) &&
pgAdmin.Browser.serverInfo && pgAdmin.Browser.serverInfo[treeNodeInfo.server._id];
pgAdmin.Browser.serverInfo?.[treeNodeInfo.server._id];
let inCatalog = treeNodeInfo && ('catalog' in treeNodeInfo);
let isActionTypeCopy = actionType == 'copy';
// If the actionType is set to 'copy' it is necessary to retrieve the details
@@ -85,9 +85,9 @@ export default function ObjectNodeProperties({panelId, node, treeNodeInfo, nodeD
if (msg == 'CRYPTKEY_SET') {
return Promise.resolve(initData());
} else if (msg == 'CRYPTKEY_NOT_SET') {
reject(gettext('The master password is not set.'));
reject(new Error(gettext('The master password is not set.')));
}
reject(err);
reject(new Error(err));
});
})
@@ -114,9 +114,9 @@ export default function ObjectNodeProperties({panelId, node, treeNodeInfo, nodeD
if (msg == 'CRYPTKEY_SET') {
return Promise.resolve(onSaveClick(isNew, data));
} else if (msg == 'CRYPTKEY_NOT_SET') {
reject(gettext('The master password is not set.'));
reject(new Error(gettext('The master password is not set.')));
}
reject(err);
reject(new Error(err));
});
});
});
@@ -133,7 +133,7 @@ export default function ObjectNodeProperties({panelId, node, treeNodeInfo, nodeD
resolve(res.data.data);
}).catch((err)=>{
onError(err);
reject(err);
reject(new Error(err));
});
});
};