IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix a number of debugger execution issues. Fixes #3191

Browse Source 
1. EPAS packages' function/procedure does not honour INOUT arguments, it converts INOUT to OUT.

2.  Packages' functions and procedures are not getting listed in their respected nodes in some scenarios like procedure having INOUT argument and function with void return type

3. The Reverse engineering SQL is not correct for Packages' functions/procedures

4. In case of INOUT argument, debugger asks for mendatory input which should not.

5. Re-executing a procedure whilst direct debugging doesn't work.
This commit is contained in:
Khushboo Vashi
2018-07-17 12:51:24 +01:00
committed by Dave Page
parent 39b41d7b24
commit 8869fd6eb3
36 changed files with 176 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
web/pgadmin/tools/debugger/static/js/direct.js
View File

@@ -650,7 +650,6 @@ define([
// Start pooling again
pgTools.DirectDebug.polling_timeout_idle = false;
pgTools.DirectDebug.is_polling_required = true;
self.poll_end_execution_result(trans_id);
self.poll_result(trans_id);
if (restart_dbg) {

4
web/pgadmin/tools/debugger/templates/debugger/sql/get_function_debug_info.sql
View File

@@ -26,7 +26,11 @@ SELECT
pg_catalog.generate_series(0, pg_catalog.array_upper(proargtypes, 1)) s(i)), ',')
END AS proargtypes,
pg_catalog.array_to_string(p.proargnames, ',') AS proargnames,
{% if is_ppas_database %}
pg_catalog.array_to_string(proargdeclaredmodes, ',') AS proargmodes,
{% else %}
pg_catalog.array_to_string(proargmodes, ',') AS proargmodes,
{% endif %}
{% if is_ppas_database %}
CASE WHEN n.nspparent <> 0 THEN n.oid ELSE 0 END AS pkg,