Fixed some accessibility issues. Fixes #5732

This commit is contained in:
Pradip Parkale
2020-09-15 13:03:18 +05:30
committed by Akshay Joshi
parent 324e3e74be
commit 8e132eab08
9 changed files with 24 additions and 22 deletions

View File

@@ -1,3 +1,3 @@
<div class="filter-textarea">
<textarea id="sql_filter" rows="5" tabindex="0"></textarea>
<textarea id="sql_filter" rows="5" tabindex="0" aria-label="sql filter"></textarea>
</div>

View File

@@ -17,6 +17,7 @@
<div class="btn-group mr-1" role="group" aria-label="">
<button id="btn-show-query-tool" type="button" class="btn btn-sm btn-primary-icon btn-show-query-tool"
title=""
aria-label="show query tool"
tabindex="0">
<i class="pg-font-icon icon-query-tool" aria-hidden="true" role="img"></i>
</button>
@@ -36,7 +37,7 @@
</button>
<button id="btn-file-menu-dropdown" type="button" class="btn btn-sm btn-primary-icon dropdown-toggle dropdown-toggle-split"
data-toggle="dropdown" aria-haspopup="true" aria-expanded="false" disabled
tabindex="0">
tabindex="0" aria-label="file menu">
</button>
<ul class="dropdown-menu">
<li>
@@ -130,7 +131,7 @@
</button>
<button id="btn-copy-row-dropdown" type="button" class="btn btn-sm btn-primary-icon dropdown-toggle dropdown-toggle-split"
data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"
tabindex="0">
tabindex="0" aria-label="copy row">
</button>
<ul class="dropdown-menu">
<li>
@@ -265,7 +266,7 @@
title=""
tabindex="0">
</button>
<ul class="dropdown-menu" role="menu">
<ul class="dropdown-menu">
<li>
<a class="dropdown-item" id="btn-auto-commit" href="#" tabindex="0">
<i class="auto-commit fa fa-check visibility-hidden" aria-hidden="true" role="img"></i>
@@ -294,7 +295,7 @@
</button>
<button id="btn-explain-options-dropdown" type="button" class="btn btn-sm btn-primary-icon dropdown-toggle dropdown-toggle-split"
data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"
tabindex="0">
tabindex="0" aria-label="explain">
</button>
<ul class="dropdown-menu">
<li>

View File

@@ -1771,7 +1771,7 @@ define([
var editor_pane = $('<div id="stack_editor_pane" ' +
'class="pg-panel-content info"></div>');
var code_editor_area = $('<textarea id="debugger-editor-textarea">' +
var code_editor_area = $('<textarea aria-label="Code editor area" id="debugger-editor-textarea">' +
'</textarea>').appendTo(editor_pane);
self.code_editor_panel.layout().addItem(editor_pane);

View File

@@ -367,7 +367,7 @@ define('tools.querytool', [
queryToolNotifications.renderNotificationsGrid(self.notifications_panel);
var text_container = $('<textarea id="sql_query_tool" tabindex="-1"></textarea>');
var output_container = $('<div id="output-panel" tabindex="0"></div>').append(text_container);
var output_container = $('<label for="sql_query_tool" class="sr-only">SQL Editor</label><div id="output-panel" tabindex="0"></div>').append(text_container);
self.sql_panel_obj.$container.find('.pg-panel-content').append(output_container);
self.query_tool_obj = CodeMirror.fromTextArea(text_container.get(0), {