Replace if-then-else statement by a single return statement, issue reported by SonarQube.

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/primary_key.js

@@ -527,8 +527,7 @@ define('pgadmin.node.primary_key', [
           select2:{allowClear:false},
           filter: function(m) {
             // Don't show pg_global tablespace in selection.
-            if (m.label == 'pg_global') return false;
+            return (m.label != 'pg_global');
-            else return true;
           },
           disabled: function(m) {
             // Disable if index is selected.

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/unique_constraint.js

@@ -517,8 +517,7 @@ define('pgadmin.node.unique_constraint', [
           select2:{allowClear:false},
           filter: function(m) {
             // Don't show pg_global tablespace in selection.
-            if (m.label == 'pg_global') return false;
+            return (m.label != 'pg_global');
-            else return true;
           },
           disabled: function(m) {
             // Disable if index is selected.

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/static/js/index.js

@@ -192,11 +192,7 @@ define('pgadmin.node.index', [
     inSchemaWithModelCheck: function(m) {
       if(m.top.node_info &&  'schema' in m.top.node_info) {
         // We will disable control if it's in 'edit' mode
-        if (m.top.isNew()) {
+        return !m.top.isNew();
-          return false;
-        } else {
-          return true;
-        }
       }
       return true;
     },
@@ -419,20 +415,12 @@ define('pgadmin.node.index', [
           group: gettext('Definition'), model: ColumnModel, mode: ['edit', 'create'],
           canAdd: function(m) {
             // We will disable it if it's in 'edit' mode
-            if (m.isNew()) {
+            return m.isNew();
-              return true;
-            } else {
-              return false;
-            }
           },
           canEdit: false,
           canDelete: function(m) {
             // We will disable it if it's in 'edit' mode
-            if (m.isNew()) {
+            return m.isNew();
-              return true;
-            } else {
-              return false;
-            }
           },
           control: 'unique-col-collection', uniqueCol : ['colname'],
           columns: ['colname', 'op_class', 'sort_order', 'nulls', 'collspcname'],
@@ -532,11 +520,7 @@ define('pgadmin.node.index', [
         inSchemaWithModelCheck: function(m) {
           if(this.node_info &&  'schema' in this.node_info) {
             // We will disable control if it's in 'edit' mode
-            if (m.isNew()) {
+            return !m.isNew();
-              return false;
-            } else {
-              return true;
-            }
           }
           return true;
         },

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/static/js/partition.js

@@ -1204,22 +1204,14 @@ function(
       canCreate_with_trigger_enable: function(itemData, item, data) {
         if(this.canCreate.apply(this, [itemData, item, data])) {
           // We are here means we can create menu, now let's check condition
-          if(itemData.tigger_count > 0) {
+          return (itemData.tigger_count > 0);
-            return true;
-          } else {
-            return false;
-          }
         }
       },
       // Check to whether table has enable trigger(s)
       canCreate_with_trigger_disable: function(itemData, item, data) {
         if(this.canCreate.apply(this, [itemData, item, data])) {
           // We are here means we can create menu, now let's check condition
-          if(itemData.tigger_count > 0 && itemData.has_enable_triggers > 0) {
+          return (itemData.tigger_count > 0 && itemData.has_enable_triggers > 0);
-            return true;
-          } else {
-            return false;
-          }
         }
       },
     });

web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js

@@ -385,11 +385,7 @@ define('pgadmin.node.type', [
           group: gettext('Definition'), mode: ['edit', 'create'],
           canAdd: true, canEdit: false, canDelete: function(m) {
             // We will disable it if it's in 'edit' mode
-            if (m.isNew()) {
+            return m.isNew();
-              return true;
-            } else {
-              return false;
-            }
           },
           disabled: 'inSchema', deps: ['typtype'],
           control: 'unique-col-collection', uniqueCol : ['label'],

web/pgadmin/browser/server_groups/servers/databases/schemas/views/static/js/mview.js

@@ -201,8 +201,7 @@ define('pgadmin.node.mview', [
           type: 'text', group: gettext('Storage'), first_empty: false,
           control: 'node-list-by-name', node: 'tablespace', select2: { allowClear: false },
           filter: function(m) {
-            if (m.label == 'pg_global') return false;
+            return (m.label != 'pg_global');
-            else return true;
           },
         },{
           id: 'fillfactor', label: gettext('Fill factor'),