IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed following code smells reported by SonarQube:

Browse Source 
1) Immediately return this expression instead of assigning it to the temporary variable.
 2) Extract this nested ternary operation into an independent statement.
 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.
This commit is contained in:
Akshay Joshi
2022-01-18 14:49:54 +05:30
parent e3807ec3d6
commit 9f836f5433
62 changed files with 367 additions and 319 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web/pgadmin/dashboard/static/js/Graphs.jsx
View File

@@ -43,10 +43,10 @@ export function transformData(labels, refreshRate) {
export function legendCallback(chart) {
var text = [];
text.push('<div class="' + chart.id + '-legend d-flex">');
for (var i = 0; i < chart.data.datasets.length; i++) {
text.push('<div class="legend-value"><span style="background-color:' + chart.data.datasets[i].backgroundColor + '">&nbsp;&nbsp;&nbsp;&nbsp;</span>');
if (chart.data.datasets[i].label) {
text.push('<span class="legend-label">' + chart.data.datasets[i].label + '</span>');
for (let chart_val of chart.data.datasets) {
text.push('<div class="legend-value"><span style="background-color:' + chart_val.backgroundColor + '">&nbsp;&nbsp;&nbsp;&nbsp;</span>');
if (chart_val.label) {
text.push('<span class="legend-label">' + chart_val.label + '</span>');
}
text.push('</div>');
}