IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed following code smells reported by SonarQube:

Browse Source 
1) Immediately return this expression instead of assigning it to the temporary variable.
 2) Extract this nested ternary operation into an independent statement.
 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.
This commit is contained in:
Akshay Joshi
2022-01-18 14:49:54 +05:30
parent e3807ec3d6
commit 9f836f5433
62 changed files with 367 additions and 319 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/pgadmin/static/js/SchemaView/DataGridView.jsx
View File

@@ -277,7 +277,7 @@ export default function DataGridView({
/>;
}
};
colInfo.Cell.displayName = 'Cell',
colInfo.Cell.displayName = 'Cell';
colInfo.Cell.propTypes = {
row: PropTypes.object.isRequired,
};
@@ -316,7 +316,7 @@ export default function DataGridView({
);
}
};
colInfo.Cell.displayName = 'Cell',
colInfo.Cell.displayName = 'Cell';
colInfo.Cell.propTypes = {
row: PropTypes.object.isRequired,
};
@@ -381,7 +381,7 @@ export default function DataGridView({
/>;
},
};
colInfo.Cell.displayName = 'Cell',
colInfo.Cell.displayName = 'Cell';
colInfo.Cell.propTypes = {
row: PropTypes.object.isRequired,
value: PropTypes.any,

10
web/pgadmin/static/js/SchemaView/FormView.jsx
View File

@@ -101,14 +101,18 @@ export function getFieldMetaData(field, schema, value, viewHelperProps, onlyMode
}
let {visible, disabled, readonly, editable} = field;
let verInLimit;
let verInLimit = (_.isUndefined(viewHelperProps.serverInfo) ? true :
((_.isUndefined(field.server_type) ? true :
if (_.isUndefined(viewHelperProps.serverInfo)) {
verInLimit= true;
} else {
verInLimit = ((_.isUndefined(field.server_type) ? true :
(viewHelperProps.serverInfo.type in field.server_type)) &&
(_.isUndefined(field.min_version) ? true :
(viewHelperProps.serverInfo.version >= field.min_version)) &&
(_.isUndefined(field.max_version) ? true :
(viewHelperProps.serverInfo.version <= field.max_version))));
(viewHelperProps.serverInfo.version <= field.max_version)));
}
retData.readonly = viewHelperProps.inCatalog || (viewHelperProps.mode == 'properties');
if(!retData.readonly) {