Fixed following code smells reported by SonarQube:

1) Immediately return this expression instead of assigning it to the temporary variable.
 2) Extract this nested ternary operation into an independent statement.
 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.

web/pgadmin/tools/psql/static/js/psql_module.js

@@ -243,13 +243,11 @@ export function initialize(gettext, url_for, $, _, pgAdmin, csrfToken, Browser)
     },
     psql_terminal: function() {
       // theme colors
-      var term = new terminal({
+      return new terminal({
         cursorBlink: true,
         macOptionIsMeta: true,
         scrollback: 5000,
       });
-
-      return term;
     },
     psql_Addon: function(term) {
       const fitAddon = this.psql_fit_screen();