IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed following code smells reported by SonarQube:

Browse Source 
1) Immediately return this expression instead of assigning it to the temporary variable.
 2) Extract this nested ternary operation into an independent statement.
 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.
This commit is contained in:
Akshay Joshi
2022-01-18 14:49:54 +05:30
parent e3807ec3d6
commit 9f836f5433
62 changed files with 367 additions and 319 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web/regression/javascript/tree/tree_fake.js
View File

@@ -107,8 +107,12 @@ export class TreeFake extends Tree {
let idx = 0;
let node_cnt = 0;
let result = {};
let item = TreeNode.prototype.isPrototypeOf(identifier) ? identifier :
(identifier.path ? this.findNode(identifier.path) : this.findNodeByDomElement(identifier));
let item = null;
if (TreeNode.prototype.isPrototypeOf(identifier)) {
item = identifier;
} else {
item = identifier.path ? this.findNode(identifier.path) : this.findNodeByDomElement(identifier);
}
if (item == undefined || item == null) return null;