From b3d49c61a57f5e78108b132a92af9ea275d294c6 Mon Sep 17 00:00:00 2001 From: Nikhil Mohite Date: Tue, 25 Aug 2020 12:31:58 +0530 Subject: [PATCH] Fixed incorrect reverse engineering SQL for Foreign key when creating a table. Fixes #5748 --- docs/en_US/release_notes_4_26.rst | 1 + .../server_groups/servers/databases/schemas/tables/utils.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/en_US/release_notes_4_26.rst b/docs/en_US/release_notes_4_26.rst index 0ebea240a..d6fa70bd2 100644 --- a/docs/en_US/release_notes_4_26.rst +++ b/docs/en_US/release_notes_4_26.rst @@ -19,4 +19,5 @@ Housekeeping Bug fixes ********* +| `Issue #5748 `_ - Fixed incorrect reverse engineering SQL for Foreign key when creating a table. | `Issue #5754 `_ - Fixed an issue where schema diff is not working when providing the options to Foreign Data Wrapper, Foreign Server, and User Mapping. diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py index 0cb122a12..647a7ba5c 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py @@ -1117,7 +1117,7 @@ class BaseTableView(PGChildNodeView, BasePartitionTable): sql += '\n' + exclusion_constraint_sql return sql - def _check_for_foreign_key(self, data): + def _check_fk_constraint(self, data): if 'foreign_key' in data: for c in data['foreign_key']: schema, table = fkey_utils.get_parent( @@ -1250,7 +1250,7 @@ class BaseTableView(PGChildNodeView, BasePartitionTable): data = column_utils.parse_format_columns(data) data = BaseTableView.check_and_convert_name_to_string(data) - self._check_foreign_key(data) + self._check_fk_constraint(data) partitions_sql = self._check_for_partitioned(data)