IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2024-11-26 02:30:21 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix double click issue to expand the contents of a cell if the resultset was not editable. Fixes #4585

Browse Source
This commit is contained in:
Yosry Muhammad 2019-08-09 11:45:05 +05:30 committed by Akshay Joshi
parent 99b51f8f20
commit b618dfe286
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/en_US/release_notes_4_12.rst
View File

@ -46,4 +46,5 @@ Bug fixes
| `Issue #4565 <https://redmine.postgresql.org/issues/4565>`_ - Fix the reverse engineered SQL for trigger functions with the WINDOW option selected.
| `Issue #4578 <https://redmine.postgresql.org/issues/4578>`_ - Ensure enable trigger menu should be visible when trigger is disabled.
| `Issue #4581 <https://redmine.postgresql.org/issues/4581>`_ - Ensure the comment on a Primary Key constraint can be edited under the Table node.
| `Issue #4582 <https://redmine.postgresql.org/issues/4582>`_ - Fix console error when changing kind(SQL/BATCH) for pgAgent job step.
| `Issue #4582 <https://redmine.postgresql.org/issues/4582>`_ - Fix console error when changing kind(SQL/BATCH) for pgAgent job step.
| `Issue #4585 <https://redmine.postgresql.org/issues/4585>`_ - Fix double click issue to expand the contents of a cell if the resultset was not editable.

7
web/pgadmin/tools/sqleditor/static/js/sqleditor.js
View File

@ -713,7 +713,7 @@ define('tools.querytool', [
*/
// This function is responsible to create and render the SlickGrid.
render_grid: function(collection, columns, is_editable, client_primary_key, rows_affected, is_explain_plan) {
render_grid: function(collection, columns, is_editable, client_primary_key, rows_affected) {
var self = this;
self.handler.numberOfModifiedCells = 0;
@ -833,7 +833,7 @@ define('tools.querytool', [
}
var grid_options = {
editable: is_editable || is_explain_plan,
editable: true,
enableAddRow: is_editable,
enableCellNavigation: true,
enableColumnReorder: false,
@ -2481,7 +2481,6 @@ define('tools.querytool', [
&& data.types[0] && data.types[0].typname === 'json') {
/* json is sent as text, parse it */
explain_data_json = JSON.parse(data.result[0][0]);
self.is_explain_plan = true;
}
if (explain_data_json && explain_data_json[0] &&
@ -2497,7 +2496,7 @@ define('tools.querytool', [
function() {
self.gridView.render_grid(
explain_data_array, self.columns, self.can_edit,
self.client_primary_key, 0, self.is_explain_plan
self.client_primary_key, 0
);
// Make sure - the 'Explain' panel is visible, before - we
// start rendering the grid.