Fixed 'Remove the unnecessary boolean literals' code smell

This commit is contained in:
Akshay Joshi
2022-09-08 20:28:43 +05:30
parent b8f63adf41
commit b73aa6d000
13 changed files with 27 additions and 27 deletions

View File

@@ -13,7 +13,7 @@ let pgBrowser = pgAdmin.Browser;
export function childCreateMenuEnabled(itemData, item, data) {
// If check is false then , we will allow create menu
if (data && data.check === false) {
if (data && !data.check) {
return true;
}

View File

@@ -100,7 +100,7 @@ define('pgadmin.node.column', [
// Below function will enable right click menu for creating column
canCreate: function(itemData, item, data) {
// If check is false then , we will allow create menu
if (data && data.check == false)
if (data && !data.check)
return true;
let t = pgBrowser.tree, i = item, d = itemData, parents = [];

View File

@@ -100,7 +100,7 @@ define('pgadmin.node.check_constraint', [
// Below function will enable right click menu for creating check constraint.
canCreate: function(itemData, item, data) {
// If check is false then , we will allow create menu
if (data && data.check == false)
if (data && !data.check)
return true;
let t = pgBrowser.tree, i = item, d = itemData, parents = [];

View File

@@ -58,7 +58,7 @@ define('pgadmin.node.exclusion_constraint', [
canCreate: function(itemData, item, data) {
// If check is false then , we will allow create menu
if (data && data.check == false)
if (data && !data.check)
return true;
let t = pgBrowser.tree, i = item, d = itemData, parents = [],

View File

@@ -94,7 +94,7 @@ define('pgadmin.node.foreign_key', [
},
canCreate: function(itemData, item, data) {
// If check is false then , we will allow create menu
if (data && data.check == false)
if (data && !data.check)
return true;
let t = pgBrowser.tree, i = item, d = itemData, parents = [],

View File

@@ -52,7 +52,7 @@ define('pgadmin.node.unique_constraint', [
},
canCreate: function(itemData, item, data) {
// If check is false then , we will allow create menu
if (data && data.check == false)
if (data && !data.check)
return true;
let t = pgBrowser.tree, i = item, d = itemData, parents = [],

View File

@@ -94,7 +94,7 @@ define('pgadmin.node.index', [
// Below function will enable right click menu for creating column
canCreate: function(itemData, item, data) {
// If check is false then , we will allow create menu
if (data && data.check == false)
if (data && !data.check)
return true;
let t = pgBrowser.tree, i = item, d = itemData, parents = [],

View File

@@ -361,7 +361,7 @@ function(gettext, $, Backbone, Backform, Backgrid, pgNode) {
});
// Insert Delete Cell into Grid
if (data.disabled == false && data.canDelete) {
if (data.disabled && data.canDelete) {
gridSchema.columns.unshift({
name: 'pg-backform-delete width_percent_5', label: '',
cell: Backgrid.Extension.DeleteCell,
@@ -404,7 +404,7 @@ function(gettext, $, Backbone, Backform, Backgrid, pgNode) {
$gridBody.append(self.$grid);
// Add button callback
if (!(data.disabled || data.canAdd == false)) {
if (!(data.disabled || !data.canAdd)) {
$gridBody.find('button.add').first().on('click',(e) => {
e.preventDefault();
let canAddRow = _.isFunction(data.canAddRow) ?