IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed 'Remove the unnecessary boolean literals' code smell

Browse Source
This commit is contained in:
Akshay Joshi
2022-09-08 20:28:43 +05:30
parent b8f63adf41
commit b73aa6d000
13 changed files with 27 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/pgadmin/browser/static/js/frame.js
View File

@@ -49,7 +49,7 @@ define([
$(myPanel).data('pgAdminName', that.name);
myPanel.initSize(that.width, that.height);
if (myPanel.showTitle == false)
if (!myPanel.showTitle)
myPanel.title(false);
myPanel.icon(that.icon);

6
web/pgadmin/browser/static/js/node.js
View File

@@ -64,7 +64,7 @@ define('pgadmin.browser.node', [
child.callbacks = _.extend({}, parent.callbacks, props.callbacks);
// Let's not bind the callbacks, or initialize the child.
if (initialize === false)
if (!initialize)
return child;
var bindToChild = function(cb) {
@@ -1140,11 +1140,11 @@ define('pgadmin.browser.node', [
let tree = pgBrowser.tree,
auto_expand = pgBrowser.get_preference('browser', 'auto_expand_sole_children');
if (auto_expand && auto_expand.value == true && tree.children(item).length == 1) {
if (auto_expand && auto_expand.value && tree.children(item).length == 1) {
// Automatically expand the child node, if a treeview node has only a single child.
const first_child = tree.first(item);
if (first_child._loaded == true) {
if (first_child._loaded) {
tree.open(first_child);
} else {
const openSoleItem = setInterval(() => {

16
web/pgadmin/browser/static/js/quick_search/trigger_search.js
View File

@@ -49,11 +49,11 @@ export function Search() {
// Below will be called when any changes has been made to state
useEffect(() => {
if(menuSearchResult.fetched == true){
if(menuSearchResult.fetched){
setIsMenuLoading(false);
}
if(helpSearchResult.fetched == true){
if(helpSearchResult.fetched){
setIsHelpLoading(false);
}
}, [menuSearchResult, helpSearchResult]);
@@ -97,11 +97,11 @@ export function Search() {
for(let i=0; i < items.length; i++){
Object.keys(items[i]).forEach( (value) => {
if(value != 'element' && value != 'No object selected'){
menuItemsHtmlElement.push( <li key={ 'li-menu-' + i }><a tabIndex='0' id={ 'li-menu-' + i } href={'#'} className={ (items[i]['element'].classList.contains('disabled') == true ? 'dropdown-item menu-groups-a disabled':'dropdown-item menu-groups-a')} key={ 'menu-' + i } onClick={() => {items[i]['element'].click(); toggleDropdownMenu();}}>
menuItemsHtmlElement.push( <li key={ 'li-menu-' + i }><a tabIndex='0' id={ 'li-menu-' + i } href={'#'} className={ (items[i]['element'].classList.contains('disabled') ? 'dropdown-item menu-groups-a disabled':'dropdown-item menu-groups-a')} key={ 'menu-' + i } onClick={() => {items[i]['element'].click(); toggleDropdownMenu();}}>
{value}
<span key={ 'menu-span-' + i }>{refactorPathToMenu(items[i][value])}</span>
</a>
{ ((items[i]['element'].classList.contains('disabled') == true && items[i]['element'].getAttribute('data-disabled') != undefined) ? <i className='fa fa-info-circle quick-search-tooltip' data-toggle='tooltip' title={items[i]['element'].getAttribute('data-disabled')} aria-label='Test data tooltip' aria-hidden='true'></i> : '' )}
{ ((items[i]['element'].classList.contains('disabled') && items[i]['element'].getAttribute('data-disabled') != undefined) ? <i className='fa fa-info-circle quick-search-tooltip' data-toggle='tooltip' title={items[i]['element'].getAttribute('data-disabled')} aria-label='Test data tooltip' aria-hidden='true'></i> : '' )}
</li>);
}
});
@@ -200,7 +200,7 @@ export function Search() {
:''}
<div >
{ (menuSearchResult.fetched == true && isMenuLoading == false ) ?
{ (menuSearchResult.fetched && !isMenuLoading ) ?
<div>
<div className='menu-groups'>
<span className='fa fa-window-maximize'></span> &nbsp;{gettext('MENU ITEMS')} ({menuSearchResult.data.length})
@@ -210,9 +210,9 @@ export function Search() {
{refactorMenuItems(menuSearchResult.data)}
</div> : ( (isMenuLoading) ? (<div className='pad-12'><div className="search-icon">{gettext('Searching...')}</div></div>) : '')}
{(menuSearchResult.data.length == 0 && menuSearchResult.fetched == true && isMenuLoading == false) ? (<div className='pad-12 no-results'><span className='fa fa-info-circle'></span> {gettext('No search results')}</div>):''}
{(menuSearchResult.data.length == 0 && menuSearchResult.fetched && !isMenuLoading) ? (<div className='pad-12 no-results'><span className='fa fa-info-circle'></span> {gettext('No search results')}</div>):''}
{ (helpSearchResult.fetched == true && isHelpLoading == false) ?
{ (helpSearchResult.fetched && !isHelpLoading) ?
<div>
<div className='help-groups'>
<span className='fa fa-question-circle'></span> &nbsp;{gettext('HELP ARTICLES')} {Object.keys(helpSearchResult.data).length > 10 ?
@@ -228,7 +228,7 @@ export function Search() {
})}
{(Object.keys(helpSearchResult.data).length == 0) ? (<div className='pad-12 no-results'><span className='fa fa-info-circle'></span> {gettext('No search results')}</div>):''}
</div> : ( (isHelpLoading && isMenuLoading == false) ? (
</div> : ( (isHelpLoading && !isMenuLoading) ? (
<div>
<div className='help-groups'>
<span className='fa fa-question-circle'></span>