IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixes following code smell reported by SonarQube:

Browse Source 
1) Replace this if-then-else flow by a single return statement
 2) Remove the unnecessary boolean literals.
This commit is contained in:
Akshay Joshi
2022-09-08 19:56:02 +05:30
parent 7086719640
commit b8f63adf41
47 changed files with 193 additions and 598 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
web/pgadmin/misc/cloud/static/js/azure_schema.ui.js
View File

@@ -463,10 +463,7 @@ class AzureDatabaseSchema extends BaseUISchema {
}
validate(data, setErrMsg) {
if (this.validateDbUserName(data, setErrMsg) || this.validateDbPassword(data, setErrMsg)) {
return true;
}
return false;
return this.validateDbUserName(data, setErrMsg) || this.validateDbPassword(data, setErrMsg);
}
get baseFields() {
@@ -729,10 +726,7 @@ class AzureClusterSchema extends BaseUISchema {
return true;
}
if(this.validateProjectDetails(data, setErr) || this.validateInstanceDetails(data, setErr) || this.validateNetworkDetails(data, setErr)){
return true;
}
return false;
return (this.validateProjectDetails(data, setErr) || this.validateInstanceDetails(data, setErr) || this.validateNetworkDetails(data, setErr));
}
}

8
web/pgadmin/misc/cloud/static/js/cloud_db_details_schema.ui.js
View File

@@ -287,8 +287,7 @@ export class StorageSchema extends BaseUISchema {
id: 'storage_IOPS', label: gettext('Provisioned IOPS'), type: 'text',
mode: ['create'],
visible: (state) => {
if(state.storage_type === 'io1') return true;
return false;
return state.storage_type === 'io1';
} , deps: ['storage_type'],
depChange: (state, source) => {
if (source[0] !== 'storage_IOPS') {
@@ -488,7 +487,7 @@ class BigAnimalDatabaseSchema extends BaseUISchema {
setErrMsg('confirm_password', gettext('Password must be 12 characters or more.'));
return true;
}
if (data.high_availability == true && (isEmptyString(data.replicas) || data.replicas <= 0)) {
if (data.high_availability && (isEmptyString(data.replicas) || data.replicas <= 0)) {
setErrMsg('replicas', gettext('Please select number of stand by replicas.'));
return true;
}
@@ -630,8 +629,7 @@ class BigAnimalHighAvailSchema extends BaseUISchema {
{'label': gettext('2'), 'value': 2},
], noEmpty: true,
disabled: (state) => {
if (state.high_availability == true) return false;
return true;
return !state.high_availability;
}
},
];