IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixes following code smell reported by SonarQube:

Browse Source 
1) Replace this if-then-else flow by a single return statement
 2) Remove the unnecessary boolean literals.
This commit is contained in:
Akshay Joshi
2022-09-08 19:56:02 +05:30
parent 7086719640
commit b8f63adf41
47 changed files with 193 additions and 598 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
web/pgadmin/tools/user_management/static/js/UserManagementDialog.jsx
View File

@@ -48,10 +48,7 @@ class UserManagementCollection extends BaseUISchema {
}
isUserNameEnabled(state) {
if (this.authOnlyInternal || state.auth_source == authConstant['INTERNAL']) {
return false;
}
return true;
return !(this.authOnlyInternal || state.auth_source == authConstant['INTERNAL']);
}
isEditable(state) {
@@ -70,9 +67,7 @@ class UserManagementCollection extends BaseUISchema {
first_empty: false,
},
visible: function() {
if (obj.authOnlyInternal)
return false;
return true;
return !obj.authOnlyInternal;
},
editable: function(state) {
return (obj.isNew(state) && !obj.authOnlyInternal);
@@ -96,10 +91,7 @@ class UserManagementCollection extends BaseUISchema {
if (obj.isNew(state))
return true;
if (obj.isEditable(state) && state.auth_source != authConstant['INTERNAL'])
return true;
return false;
return obj.isEditable(state) && state.auth_source != authConstant['INTERNAL'];
}
}, {
id: 'role', label: gettext('Role'), cell: 'select',
@@ -246,9 +238,7 @@ class UserManagementSchema extends BaseUISchema {
id: 'userManagement', label: '', type: 'collection', schema: obj.userManagementCollObj,
canAdd: true, canDelete: true, isFullTab: true, group: 'temp_user',
canDeleteRow: (row)=>{
if (row['id'] == current_user['id'])
return false;
return true;
return row['id'] != current_user['id'];
},
onDelete: (row, deleteRow)=> {
let deletedUser = {'id': row['id'], 'name': !isEmptyString(row['email']) ? row['email'] : row['username']};