1. Placeholder should be inside the controlProps. Change the placeholder from 'Select...' to 'Select an item...'

2. Updated grant wizard screenshot and documentation.
3. Remove '(Beta)' from ERD Tool and PSQL Tool.
This commit is contained in:
Akshay Joshi 2021-09-23 16:17:39 +05:30
parent 0e6794f2f5
commit b9bc628189
12 changed files with 10 additions and 15 deletions

View File

@ -35,7 +35,7 @@ to scroll through the list of all accessible objects.
* The schema in which the object resides in the *Schema* field
* The object name in the *Name* field.
Click the *Next* button to continue, or the *Cancel* button to close the wizard
Click the *Next* button to continue, or the *X* button to close the wizard
without modifying privileges.
.. image:: images/grant_wizard_step2.png
@ -64,7 +64,7 @@ For more information about granting privileges on database objects, see the
`PostgreSQL core documentation <https://www.postgresql.org/docs/current/sql-grant.html>`_.
Click the *Next* button to continue, the *Back* button to select or deselect
additional database objects, or the *Cancel* button to close the wizard without
additional database objects, or the *X* button to close the wizard without
modifying privileges.
Your entries in the *Grant Wizard* tool generate a SQL command; you can review
@ -81,11 +81,6 @@ the *Grant Wizard* tool:
:alt: Grant wizard step three page
:align: center
The commands displayed assign a role named *Bob* *INSERT* and *UPDATE*
privileges *WITH GRANT OPTION* on the *sales_meetings* and the
*sales_territories* tables.
* Click the *Back* button to select or deselect additional database objects,
roles and privileges.
* Click the *Cancel* button to exit without saving work.
* Click the *Finish* button to save selections and exit the wizard.

Binary file not shown.

Before

Width:  |  Height:  |  Size: 60 KiB

After

Width:  |  Height:  |  Size: 119 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 66 KiB

After

Width:  |  Height:  |  Size: 63 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 80 KiB

After

Width:  |  Height:  |  Size: 126 KiB

View File

@ -197,7 +197,7 @@ export default class DomainSchema extends BaseUISchema {
}, {
id: 'typdefault', label: gettext('Default'), cell: 'text',
type: 'text', group: gettext('Definition'),
placeholder: gettext('Enter an expression or a value.'),
controlProps: {placeholder: gettext('Enter an expression or a value.')},
}, {
id: 'typnotnull', label: gettext('Not NULL?'), cell: 'boolean',
type: 'switch', group: gettext('Definition'),

View File

@ -426,7 +426,7 @@ export class ColumnSchema extends BaseUISchema {
{
id: 'typdefault', label: gettext('Default'), cell: 'text',
type: 'text', group: gettext('Definition'),
placeholder: gettext('Enter an expression or a value.'),
controlProps: {placeholder: gettext('Enter an expression or a value.')},
editable: (state) => {
if(!(_.isUndefined(state.inheritedid)
|| _.isNull(state.inheritedid)

View File

@ -97,7 +97,7 @@ define('pgadmin.node.database', [
},{
name: 'generate_erd', node: 'database', module: this,
applies: ['object', 'context'], callback: 'generate_erd',
category: 'erd', priority: 5, label: gettext('Generate ERD (Beta)'),
category: 'erd', priority: 5, label: gettext('Generate ERD'),
}]);
_.bindAll(this, 'connection_lost');

View File

@ -72,7 +72,7 @@ define([
pgAdmin.Browser.add_menus([{
name: 'show_psql_tool', node: this.type, module: this,
applies: ['context'], callback: 'show_psql_tool',
priority: 998, label: gettext('PSQL Tool (Beta)'),
priority: 998, label: gettext('PSQL Tool'),
icon: 'fas fa-terminal',
}]);
}

View File

@ -217,7 +217,7 @@ define('pgadmin.browser.node', [
pgAdmin.Browser.add_menus([{
name: 'show_psql_tool', node: this.type, module: this,
applies: ['context'], callback: 'show_psql_tool',
priority: 998, label: gettext('PSQL Tool (Beta)'),
priority: 998, label: gettext('PSQL Tool'),
icon: 'fas fa-terminal',
}]);
}

View File

@ -766,7 +766,7 @@ export function InputSelect({
menuPortalTarget: document.body,
styles: styles,
inputId: cid,
placeholder: (readonly || disabled) ? '' : controlProps.placeholder || gettext('Select...'),
placeholder: (readonly || disabled) ? '' : controlProps.placeholder || gettext('Select an item...'),
...otherProps,
...props
};

View File

@ -38,7 +38,7 @@ export function initialize(gettext, url_for, $, _, pgAdmin, csrfToken, pgBrowser
applies: ['tools'],
callback: 'showErdTool',
priority: 1,
label: gettext('New ERD Project (Beta)'),
label: gettext('New ERD Project'),
enable: this.erdToolEnabled,
data: {
data_disabled: gettext('The selected tree node does not support this option.'),

View File

@ -49,7 +49,7 @@ export function initialize(gettext, url_for, $, _, pgAdmin, csrfToken, Browser)
applies: ['tools'],
callback: 'psql_tool',
priority: 1,
label: gettext('PSQL Tool (Beta)'),
label: gettext('PSQL Tool'),
enable: this.psqlToolEnabled,
}];