IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix handling of "char" columns. Fixes #2152

Browse Source
This commit is contained in:
Murtuza Zabuawala 2017-02-06 10:59:03 +00:00 committed by Dave Page
parent 4d8683e13a
commit c96da34c28
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/__init__.py
View File

@ -490,6 +490,15 @@ class ColumnsView(PGChildNodeView, DataTypeReader):
after length/precision so we will set flag for after length/precision so we will set flag for
sql template sql template
""" """
# We need to add this exceptional case for manually adding " in type
# in json.loads('"char"') is valid json hence it
# converts '"char"' -> 'char' as string but if we
# send the same in collection json.loads() handles it properly in
# Table & Type nodes, This handling handling is Column node specific
if type == 'char':
type = '"char"'
if '[]' in type: if '[]' in type:
type = type.replace('[]', '') type = type.replace('[]', '')
self.hasSqrBracket = True self.hasSqrBracket = True
@ -710,7 +719,7 @@ class ColumnsView(PGChildNodeView, DataTypeReader):
for k, v in request.args.items(): for k, v in request.args.items():
try: try:
data[k] = json.loads(v, encoding='utf-8') data[k] = json.loads(v, encoding='utf-8')
except ValueError: except (ValueError, TypeError, KeyError):
data[k] = v data[k] = v
# Adding parent into data dict, will be using it while creating sql # Adding parent into data dict, will be using it while creating sql