Incorporate review comments.

This commit is contained in:
Pravesh Sharma 2022-12-14 15:53:19 +05:30 committed by GitHub
parent 3f0eee4c39
commit cc9d519fac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions

View File

@ -207,6 +207,7 @@ export function getNodeView(nodeType, treeNodeInfo, actionType, itemNodeData, fo
ReactDOM.render(
<Theme>
<SchemaView
key={itemNodeData?._id}
formType={formType}
getInitData={initData}
schema={schema}
@ -223,7 +224,6 @@ export function getNodeView(nodeType, treeNodeInfo, actionType, itemNodeData, fo
getSQLValue={getSQLValue}
disableSqlHelp={nodeObj.sqlAlterHelp == '' && nodeObj.sqlCreateHelp == '' && !nodeObj.epasHelp}
disableDialogHelp={nodeObj.dialogHelp == undefined || nodeObj.dialogHelp == ''}
itemNodeData={itemNodeData}
/>
</Theme>, container);
}

View File

@ -866,7 +866,7 @@ const usePropsStyles = makeStyles((theme)=>({
/* If its the properties tab */
function SchemaPropertiesView({
getInitData, viewHelperProps, schema={}, itemNodeData, ...props}) {
getInitData, viewHelperProps, schema={}, ...props}) {
const classes = usePropsStyles();
let defaultTab = 'General';
let tabs = {};
@ -888,7 +888,7 @@ function SchemaPropertiesView({
}).catch(()=>{
setLoaderText('');
});
}, [itemNodeData]);
}, []);
/* A simple loop to get all the controls for the fields */