IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-01-24 07:16:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

Search object UI improvements. Fixes #5493

Browse Source
This commit is contained in:
Aditya Toshniwal 2020-05-18 11:29:12 +05:30 committed by Akshay Joshi
parent 0f56c25893
commit d58c33dec0
4 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
docs/en_US/images/search_objects.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 184 KiB

After

Width:  |  Height:  |  Size: 185 KiB

1
docs/en_US/release_notes_4_22.rst
View File

@ -20,6 +20,7 @@ Housekeeping
| `Issue #5443 <https://redmine.postgresql.org/issues/5443>`_ - Remove support for Python 2.
| `Issue #5444 <https://redmine.postgresql.org/issues/5444>`_ - Cleanup Python detection in the runtime project file.
| `Issue #5455 <https://redmine.postgresql.org/issues/5455>`_ - Refactor pgAdmin4.py so it can be imported and is a lot more readable.
| `Issue #5493 <https://redmine.postgresql.org/issues/5493>`_ - Search object UI improvements.
Bug fixes
*********

7
docs/en_US/search_objects.rst
View File

@ -17,14 +17,17 @@ shortcut (default ALT+SHIFT+S).
The minimum pattern length are 3 characters. The search performed is
non-casesensitive and will find all objets whose name contains the pattern.
You can only search for object names.
You can only search for object names currently. Examples are: abc,
%ab%, ab%c, %%%, etc.
The result is presented in the grid with object name, object type and
the object tree path in the :ref:`browser <tree_control>`. You can double
click on a result row to select the object in the
:ref:`browser <tree_control>`. If the object is greyed out, this means that you
have not enabled those object types in the :ref:`preferences <preferences>`,
so you can't double click on it.
so you can't double click on it. You can click on the ellipsis appended to
the function and procedure names to see there arguments.
You can filter based on a particular object type by selecting one from the
object type dropdown. If the search button is hit when one of the object type

13
web/pgadmin/tools/search_objects/static/js/search_objects_dialog_wrapper.js
View File

@ -64,21 +64,18 @@ export default class SearchObjectsDialogWrapper extends DialogWrapper {
<div class="d-flex flex-column w-100 h-100">
<div class="p-2">
<div class="row">
<div class="col-8 d-flex">
<div class="col-6">
<div class="input-group pgadmin-controls">
<div class="input-group-prepend">
<span class="input-group-text fa fa-search" id="labelSearch" aria-label="` + gettext('Search') + `"></span>
</div>
<input type="search" class="form-control" id="txtGridSearch" placeholder="` + gettext('Type at least 3 characters') + `"
tabindex="0" aria-describedby="labelSearch" aria-labelledby="labelSearch" autocomplete="off">
</div>
<div class="ml-2">
<button class="btn btn-primary btn-search" disabled>`+ gettext('Search') +`</button>
</div>
</div>
<div class="col-4">
<div class="col-4 d-flex">
<select aria-label="` + gettext('Object types') + `" class="node-types"></select>
</div>
<div class="col-2">
<button class="btn btn-primary btn-search w-100" disabled><span class="fa fa-search"></span>&nbsp;`+ gettext('Search') +`</button>
</div>
</div>
</div>
<div class="search-result-container flex-grow-1">