From d7b050830553e50332a01122e097bcf98e5ed789 Mon Sep 17 00:00:00 2001 From: Aditya Toshniwal Date: Wed, 16 Jan 2019 12:34:16 +0530 Subject: [PATCH] Fixed SQL for foreign table options. Fixes #3453 --- docs/en_US/release_notes_4_2.rst | 1 + .../servers/databases/schemas/foreign_tables/__init__.py | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/docs/en_US/release_notes_4_2.rst b/docs/en_US/release_notes_4_2.rst index 14203ebe4..dc46fdbba 100644 --- a/docs/en_US/release_notes_4_2.rst +++ b/docs/en_US/release_notes_4_2.rst @@ -14,5 +14,6 @@ Features Bug fixes ********* +| `Bug #3453 `_ - Fixed SQL for foreign table options. | `Bug #3693 `_ - Proper error should be thrown when server group is created with existing name. | `Bug #3695 `_ - Ensure long string should be wrap in alertify dialogs. \ No newline at end of file diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py index ddb31e79a..2d206bff7 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py @@ -1209,10 +1209,6 @@ class ForeignTableView(PGChildNodeView, DataTypeReader): if db_variables is not None: for row in db_variables: var_name, var_value = row.split("=") - # Because we save as boolean string in db so it needs - # conversion - if var_value == 'false' or var_value == 'off': - var_value = False var_dict = {'option': var_name, 'value': var_value}