Various misc fixes:

- Using the 'gettext' as oppose to '_', which is not defined
- Define missing variables
- Fixed escape character in string with double quote
- Removed some dead code in a test case
- Removed unnecessary self assignment

Includes some fixes for Accessibility improvements
- Use semantic markup to mark emphasized or special text
- Added hidden legend in <fieldset> for better screen reader support
This commit is contained in:
Ashesh Vashi
2020-04-08 14:14:25 +05:30
parent 8fe687eb55
commit d9f6baac72
15 changed files with 28 additions and 59 deletions

View File

@@ -58,7 +58,7 @@ try {
autofocus="autofocus"
aria-label="{{ gettext('Step into') }}"
disabled>
<i class="fa fa-indent sql-icon-lg"></i>
<i class="fa fa-indent sql-icon-lg" aria-hidden="true"></i>
</button>
<button type="button" class="btn btn-sm btn-secondary btn-step-over" id="btn-step-over"
title=""
@@ -66,7 +66,7 @@ try {
tabindex="0"
aria-label="{{ gettext('Step over') }}"
disabled>
<i class="fa fa-outdent sql-icon-lg"></i>
<i class="fa fa-outdent sql-icon-lg" aria-hidden="true"></i>
</button>
<button type="button" class="btn btn-sm btn-secondary btn-continue" id="btn-continue"
title=""
@@ -74,7 +74,7 @@ try {
tabindex="0"
aria-label="{{ gettext('Continue/Start') }}"
disabled>
<i class="fa fa-play-circle sql-icon-lg"></i>
<i class="fa fa-play-circle sql-icon-lg" aria-hidden="true"></i>
</button>
</div>
<div class="btn-group" role="group" aria-label="">
@@ -84,7 +84,7 @@ try {
tabindex="0"
aria-label="{{ gettext('Toggle breakpoint') }}"
disabled>
<i class="fa fa-circle sql-icon-lg"></i>
<i class="fa fa-circle sql-icon-lg" aria-hidden="true"></i>
</button>
<button type="button" class="btn btn-sm btn-secondary btn-clear-breakpoint" id="btn-clear-breakpoint"
title=""
@@ -92,7 +92,7 @@ try {
tabindex="0"
aria-label="{{ gettext('Clear all breakpoints') }}"
disabled>
<i class="fa fa-ban sql-icon-lg"></i>
<i class="fa fa-ban sql-icon-lg" aria-hidden="true"></i>
</button>
</div>
<div class="btn-group" role="group" aria-label="">
@@ -102,7 +102,7 @@ try {
tabindex="0"
aria-label="{{ gettext('Stop') }}"
disabled>
<i class="fa fa-stop-circle sql-icon-lg"></i>
<i class="fa fa-stop-circle sql-icon-lg" aria-hidden="true"></i>
</button>
</div>
</div>