IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed issue related to reducing the if-else statement to single return expression. Reported by SonarQube.

Browse Source
This commit is contained in:
Satish V
2020-06-22 12:58:48 +05:30
committed by Akshay Joshi
parent 6620f9263d
commit daad16ea93
8 changed files with 36 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
web/pgadmin/tools/user_management/static/js/user_management.js
View File

@@ -315,11 +315,7 @@ define([
if (m instanceof Backbone.Collection) {
return true;
}
if (m.isNew() && !m.get('authOnlyInternal')) {
return true;
} else {
return false;
}
return (m.isNew() && !m.get('authOnlyInternal'));
},
}, {
id: 'username',
@@ -395,11 +391,7 @@ define([
if (m instanceof Backbone.Collection) {
return true;
}
if (m.get('id') == userInfo['id']) {
return false;
} else {
return true;
}
return (m.get('id') != userInfo['id']);
},
}, {
id: 'active',
@@ -412,11 +404,7 @@ define([
if (m instanceof Backbone.Collection) {
return true;
}
if (m.get('id') == userInfo['id']) {
return false;
} else {
return true;
}
return (m.get('id') != userInfo['id']);
},
}, {
id: 'newPassword',
@@ -429,11 +417,7 @@ define([
deps: ['auth_source'],
sortable: false,
editable: function(m) {
if (m.get('auth_source') == DEFAULT_AUTH_SOURCE) {
return true;
} else {
return false;
}
return (m.get('auth_source') == DEFAULT_AUTH_SOURCE);
},
}, {
id: 'confirmPassword',
@@ -446,11 +430,7 @@ define([
deps: ['auth_source'],
sortable: false,
editable: function(m) {
if (m.get('auth_source') == DEFAULT_AUTH_SOURCE) {
return true;
} else {
return false;
}
return (m.get('auth_source') == DEFAULT_AUTH_SOURCE);
},
}],
validate: function() {