Fixed following code smells reported by SonarQube:

1) Boolean checks should not be inverted.
 2) Review this redundant assignment.
 3) Extract this nested ternary operation into an independent statement.
 4) Unexpected empty function.
 5) Immediately return this expression instead of assigning it to the temporary variable.
This commit is contained in:
Akshay Joshi
2022-01-17 13:56:01 +05:30
parent 40fa1aff6b
commit e3807ec3d6
39 changed files with 91 additions and 136 deletions

View File

@@ -250,7 +250,7 @@ export default function newConnectionDialogModel(response, sgid, sid, handler, c
},
};
},
build:function() {
build:function() { /*This is intentional (SonarQube)*/
},
prepare:function() {
this.setContent(this.message);
@@ -469,6 +469,5 @@ export default function newConnectionDialogModel(response, sgid, sid, handler, c
},
});
let model = new newConnectionModel();
return model;
return new newConnectionModel();
}