Fixed following code smells reported by SonarQube:

1) Boolean checks should not be inverted.
 2) Review this redundant assignment.
 3) Extract this nested ternary operation into an independent statement.
 4) Unexpected empty function.
 5) Immediately return this expression instead of assigning it to the temporary variable.
This commit is contained in:
Akshay Joshi
2022-01-17 13:56:01 +05:30
parent 40fa1aff6b
commit e3807ec3d6
39 changed files with 91 additions and 136 deletions

View File

@@ -559,8 +559,7 @@ export default class BackupSchema extends BaseUISchema {
setError('file', errmsg);
return true;
} else {
errmsg = null;
setError('file', errmsg);
setError('file', null);
}
}
}

View File

@@ -107,8 +107,7 @@ export default class BackupGlobalSchema extends BaseUISchema {
setError('file', errmsg);
return true;
} else {
errmsg = null;
setError('file', errmsg);
setError('file', null);
}
}
}

View File

@@ -22,7 +22,7 @@ class EmptySchema extends BaseUISchema {
return [];
}
changeColumnOptions() {
/*This is intentional (SonarQube)*/
}
}

View File

@@ -24,7 +24,7 @@ export default class ERDTool {
}
getPreferencesForModule() {
/*This is intentional (SonarQube)*/
}
render() {

View File

@@ -88,6 +88,7 @@ define([
var $container = $('<div class=\'wizard_dlg\' id=\'grantWizardDlg\'></div>');
return {
main: function () {
/*This is intentional (SonarQube)*/
},
setup: function () {
return {

View File

@@ -91,8 +91,7 @@ export default class ImportExportSelectionSchema extends BaseUISchema {
setError('filename', errmsg);
return true;
} else {
errmsg = null;
setError('filename', errmsg);
setError('filename', null);
}
}
}

View File

@@ -61,6 +61,7 @@ export default class ImportExportServersModule {
var $container = $('<div class=\'wizard_dlg\' id=\'importExportServersDlg\'></div>');
return {
main: function () {
/*This is intentional (SonarQube)*/
},
setup: function () {
return {

View File

@@ -460,8 +460,7 @@ export default class RestoreSchema extends BaseUISchema {
setError('file', errmsg);
return true;
} else {
errmsg = null;
setError('file', errmsg);
setError('file', null);
}
}
}