IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Improved the extendability of the SchemaView and DataGridView. (#7876)

Browse Source 
Restructured these modules for ease of maintenance and apply the single
responsibility principle (wherever applicable).

* SchemaView

 - Split the code based on the functionality and responsibility.
 - Introduced a new View 'InlineView' instead of using the
   'nextInline' configuration of the fields to have a better, and
   manageable view.
 - Using the separate class 'SchemaState' for managing the data and
   states of the SchemaView (separated from the 'useSchemaState'
   custom hook).
 - Introduced three new custom hooks 'useFieldValue',
   'useFieldOptions', 'useFieldError' for the individual control to
   use for each Schema Field.
 - Don't pass value as the parameter props, and let the
   'useFieldValue' and other custom hooks to decide, whether to
   rerender the control itself or the whole dialog/view. (single
   responsibility principle)
 - Introduced a new data store with a subscription facility.
 - Moving the field metadata (option) evaluation to a separate place
   for better management, and each option can be defined for a
   particular kind of field (for example - collection, row, cell,
   general, etc).
 - Allow to provide custom control for all kind of Schema field.

* DataGridView

 - Same as SchemaView, split the DataGridView call into smaller,
   manageable chunks. (For example - grid, row, mappedCell, etc).
 - Use context based approach for providing the row and table data
   instead of passing them as parameters to every component
   separately.
 - Have a facility to extend this feature separately in future.
   (for example - selectable cell, column grouping, etc.)
 - Separated the features like deletable, editable, reorder,
   expandable etc. cells using the above feature support.
 - Added ability to provide the CustomHeader, and CustomRow through the
   Schema field, which will extend the ability to customize better.
 - Removed the 'DataGridViewWithHeaderForm' as it has been achieved
   through providing 'CustomHeader', and also introduced
   'DataGridFormHeader' (a custom header) to achieve the same feature
   as 'DataGridViewWithHeaderForm'.
This commit is contained in:
Ashesh Vashi
2024-09-09 14:27:31 +05:30
committed by GitHub
parent e5012ea9c6
commit e9af0c3226
154 changed files with 5429 additions and 3058 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
web/regression/javascript/schema_ui_files/trigger.ui.spec.js
View File

@@ -13,7 +13,7 @@ import {genericBeforeEach, getCreateView, getEditView, getPropertiesView} from '
describe('TriggerSchema', ()=>{
let schemaObj = new TriggerSchema(
let createSchemaObj = () => new TriggerSchema(
{
triggerFunction: [],
columns: [],
@@ -26,27 +26,24 @@ describe('TriggerSchema', ()=>{
);
let getInitData = ()=>Promise.resolve({});
beforeEach(()=>{
genericBeforeEach();
});
it('create', async ()=>{
await getCreateView(schemaObj);
await getCreateView(createSchemaObj());
});
it('edit', async ()=>{
await getEditView(schemaObj, getInitData);
await getEditView(createSchemaObj(), getInitData);
});
it('properties', async ()=>{
await getPropertiesView(schemaObj, getInitData);
await getPropertiesView(createSchemaObj(), getInitData);
});
it('validate', ()=>{
const schemaObj = createSchemaObj();
let state = {};
let setError = jest.fn();
@@ -148,7 +145,7 @@ describe('TriggerSchema', ()=>{
describe('TriggerEventsSchema', ()=>{
let schemaObj = new EventSchema(
let createEventSchemaObj = () => new EventSchema(
{
nodeInfo: {
server: {user: {name:'postgres', id:0}, server_type: 'pg', version: 90400},
@@ -167,18 +164,19 @@ describe('TriggerEventsSchema', ()=>{
});
it('create', async ()=>{
await getCreateView(schemaObj);
await getCreateView(createEventSchemaObj());
});
it('properties', async ()=>{
await getPropertiesView(schemaObj, getInitData);
await getPropertiesView(createEventSchemaObj(), getInitData);
});
it('edit', async ()=>{
await getEditView(schemaObj, getInitData);
await getEditView(createEventSchemaObj(), getInitData);
});
it('validate', ()=>{
const schemaObj = createEventSchemaObj();
let state = {};
let setError = jest.fn();