IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-01-24 07:16:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed an issue where the query tool is not fetching more than 1000 rows for the table does not have any primary key. Fixes #5845

Browse Source
This commit is contained in:
Aditya Toshniwal 2020-09-21 15:36:19 +05:30 committed by Akshay Joshi
parent b0475566ca
commit ed3c692b1f
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/en_US/release_notes_4_27.rst
View File

@ -21,4 +21,5 @@ Bug fixes
| `Issue #5802 <https://redmine.postgresql.org/issues/5802>`_ - Remove maximum length on the password field in the server dialog.
| `Issue #5807 <https://redmine.postgresql.org/issues/5807>`_ - Fixed an issue where a column is renamed and then removed, then the drop SQL query takes the wrong column name.
| `Issue #5830 <https://redmine.postgresql.org/issues/5830>`_ - Fixed reverse engineering SQL where parenthesis is not properly arranged for View/MView definition.
| `Issue #5839 <https://redmine.postgresql.org/issues/5839>`_ - Ensure that multiple extensions can be dropped from the properties tab.
| `Issue #5839 <https://redmine.postgresql.org/issues/5839>`_ - Ensure that multiple extensions can be dropped from the properties tab.
| `Issue #5845 <https://redmine.postgresql.org/issues/5845>`_ - Fixed an issue where the query tool is not fetching more than 1000 rows for the table does not have any primary key.

19
web/pgadmin/tools/sqleditor/utils/is_query_resultset_updatable.py
View File

@ -75,17 +75,16 @@ def is_query_resultset_updatable(conn, sql_path):
is_resultset_updatable = has_oids or (primary_keys is not None and
len(primary_keys) != 0)
if is_resultset_updatable:
column_types = get_columns_types(columns_info=columns_info,
table_oid=table_oid,
conn=conn,
has_oids=has_oids,
is_query_tool=True)
return True, has_oids, primary_keys, \
pk_names, table_oid, column_types
else:
if not is_resultset_updatable:
_set_all_columns_not_editable(columns_info=columns_info)
return return_not_updatable()
column_types = get_columns_types(columns_info=columns_info,
table_oid=table_oid,
conn=conn,
has_oids=has_oids,
is_query_tool=True)
return is_resultset_updatable, has_oids, primary_keys, \
pk_names, table_oid, column_types
else:
raise InternalServerError(SERVER_CONNECTION_CLOSED)