IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add Modified SQL tests for Resource Group. Fixes #4690

Browse Source
This commit is contained in:
Murtuza Zabuawala 2019-09-03 10:18:09 +05:30 committed by Akshay Joshi
parent a68f0702e2
commit eeeb350ed2
6 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/en_US/release_notes_4_13.rst
View File

@ -21,6 +21,7 @@ Housekeeping
| `Issue #4576 <https://redmine.postgresql.org/issues/4576>`_ - Add Reverse Engineered SQL tests for Views.
| `Issue #4600 <https://redmine.postgresql.org/issues/4600>`_ - Add Reverse Engineered SQL tests for Rules.
| `Issue #4619 <https://redmine.postgresql.org/issues/4619>`_ - Add Reverse Engineered and Modified SQL tests for FTS Templates.
| `Issue #4690 <https://redmine.postgresql.org/issues/4690>`_ - Add Modified SQL tests for Resource Group.
Bug fixes
*********

4
web/pgadmin/browser/server_groups/servers/resource_groups/__init__.py
View File

@ -621,10 +621,10 @@ class ResourceGroupView(NodeView):
cpu_rate_limit_flag = False
dirty_rate_limit_flag = False
if 'cpu_rate_limit' in data and data['cpu_rate_limit'] > 0:
if 'cpu_rate_limit' in data and data['cpu_rate_limit'] >= 0:
cpu_rate_limit_flag = True
if 'dirty_rate_limit' in data and data['dirty_rate_limit'] > 0:
if 'dirty_rate_limit' in data and data['dirty_rate_limit'] >= 0:
dirty_rate_limit_flag = True
if cpu_rate_limit_flag or dirty_rate_limit_flag:

1
web/pgadmin/browser/server_groups/servers/resource_groups/tests/ppas/9.4_plus/alter_resource_group_name.msql Normal file
View File

@ -0,0 +1 @@
ALTER RESOURCE GROUP "Rg1_$%{}[]()&*^!@""'`\/#" RENAME TO "Rg2_$%{}[]()&*^!@""'`\/#";

2
web/pgadmin/browser/server_groups/servers/resource_groups/tests/ppas/9.4_plus/alter_resource_group_options.msql Normal file
View File

@ -0,0 +1,2 @@
ALTER RESOURCE GROUP "Rg2_$%{}[]()&*^!@""'`\/#"
SET cpu_rate_limit = 1, dirty_rate_limit = 5;

5
web/pgadmin/browser/server_groups/servers/resource_groups/tests/ppas/9.4_plus/create_resource_group.msql Normal file
View File

@ -0,0 +1,5 @@
CREATE RESOURCE GROUP "Rg1_$%{}[]()&*^!@""'`\/#";
-- Following query will be executed in a separate transaction
ALTER RESOURCE GROUP "Rg1_$%{}[]()&*^!@""'`\/#"
SET cpu_rate_limit = 0, dirty_rate_limit = 0;

12
web/pgadmin/browser/server_groups/servers/resource_groups/tests/ppas/9.4_plus/test.json
View File

@ -5,33 +5,39 @@
"name": "Create Resource groups",
"endpoint": "NODE-resource_group.obj",
"sql_endpoint": "NODE-resource_group.sql_id",
"msql_endpoint": "NODE-resource_group.msql",
"data": {
"name": "Rg1_$%{}[]()&*^!@\"'`\\/#",
"cpu_rate_limit": 0,
"dirty_rate_limit": 0
},
"expected_sql_file": "create_resource_group.sql"
"expected_sql_file": "create_resource_group.sql",
"expected_msql_file": "create_resource_group.msql"
},
{
"type": "alter",
"name": "Alter Resource groups name",
"endpoint": "NODE-resource_group.obj_id",
"sql_endpoint": "NODE-resource_group.sql_id",
"msql_endpoint": "NODE-resource_group.msql_id",
"data": {
"name": "Rg2_$%{}[]()&*^!@\"'`\\/#"
},
"expected_sql_file": "alter_resource_group_name.sql"
"expected_sql_file": "alter_resource_group_name.sql",
"expected_msql_file": "alter_resource_group_name.msql"
},
{
"type": "alter",
"name": "Alter Resource groups options",
"endpoint": "NODE-resource_group.obj_id",
"sql_endpoint": "NODE-resource_group.sql_id",
"msql_endpoint": "NODE-resource_group.msql_id",
"data": {
"cpu_rate_limit": 1,
"dirty_rate_limit": 5
},
"expected_sql_file": "alter_resource_group_options.sql"
"expected_sql_file": "alter_resource_group_options.sql",
"expected_msql_file": "alter_resource_group_options.msql"
},
{
"type": "delete",