From f8771d55852eb66872319dcd6fbb94e397347ea0 Mon Sep 17 00:00:00 2001 From: Murtuza Zabuawala Date: Wed, 21 Feb 2018 17:32:04 +0000 Subject: [PATCH] Fix validation of sequence parameters. Fixes #3014 --- .../templates/sequence/sql/default/create.sql | 32 +++++++++---------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/sequences/templates/sequence/sql/default/create.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/sequences/templates/sequence/sql/default/create.sql index 0444a0d2d..e58507a94 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/sequences/templates/sequence/sql/default/create.sql +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/sequences/templates/sequence/sql/default/create.sql @@ -1,18 +1,16 @@ -{% if data %} -CREATE SEQUENCE {{ conn|qtIdent(data.schema) }}.{{ conn|qtIdent(data.name) }} -{% if data.cycled and data.cycled == True %} - CYCLE -{% endif %} -{% if data.increment is defined %} - INCREMENT {{data.increment}} -{% endif %}{% if data.start is defined %} - START {{data.start}} -{% elif data.current_value is defined %} - START {{data.current_value}} -{% endif %}{% if data.minimum is defined %} - MINVALUE {{data.minimum}} -{% endif %}{% if data.maximum is defined %} - MAXVALUE {{data.maximum}} -{% endif %}{% if data.cache is defined %} +CREATE SEQUENCE {{ conn|qtIdent(data.schema, data.name) }}{% if data.increment is defined and data.cycled %} + + CYCLE{% endif %}{% if data.increment is defined and data.increment is number %} + + INCREMENT {{data.increment}}{% endif %}{% if data.start is defined and data.start is number %} + + START {{data.start}}{% elif data.current_value is defined and data.current_value is number %} + + START {{data.current_value}}{% endif %}{% if data.minimum is defined and data.minimum is number %} + + MINVALUE {{data.minimum}}{% endif %}{% if data.maximum is defined and data.maximum is number %} + + MAXVALUE {{data.maximum}}{% endif %}{% if data.cache is defined and data.cache is number %} + CACHE {{data.cache}}{% endif %}; -{% endif %} +