From f877de6a1f24a65975492bc230d7f2039f16912f Mon Sep 17 00:00:00 2001 From: Murtuza Zabuawala Date: Thu, 31 May 2018 10:10:43 -0400 Subject: [PATCH] Fix an issue where a change to any field in server dialog causes the 'tunnel_identity_file' model value to get included unnecessarily in the update request. Fixes #3389 --- .../browser/server_groups/servers/static/js/server.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/web/pgadmin/browser/server_groups/servers/static/js/server.js b/web/pgadmin/browser/server_groups/servers/static/js/server.js index f84375a20..0ee3ec047 100644 --- a/web/pgadmin/browser/server_groups/servers/static/js/server.js +++ b/web/pgadmin/browser/server_groups/servers/static/js/server.js @@ -847,9 +847,10 @@ define('pgadmin.node.server', [ control: Backform.FileControl, dialog_type: 'select_file', supp_types: ['*'], deps: ['tunnel_authentication', 'use_ssh_tunnel'], disabled: function(model) { - if (!model.get('tunnel_authentication')) { + let file = model.get('tunnel_identity_file'); + if (!model.get('tunnel_authentication') && file) { setTimeout(function() { - model.set('tunnel_identity_file', ''); + model.set('tunnel_identity_file', null); }, 10); } return !model.get('tunnel_authentication') || !model.get('use_ssh_tunnel');