IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2024-12-25 08:21:04 -06:00
Code Issues Packages Projects Releases Wiki Activity

Allow users to scroll and enter input when there is a validation error. Fixes #7172

Browse Source
This commit is contained in:
Aditya Toshniwal 2022-03-04 17:25:36 +05:30 committed by Akshay Joshi
parent 1af431dcc2
commit f9707a8bf5
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/en_US/release_notes_6_6.rst
View File

@ -25,6 +25,7 @@ Bug fixes
| `Issue #6999 <https://redmine.postgresql.org/issues/6999>`_ - Fixed an issue where a warning is flashed every time for an email address when authentication sources are internal and ldap.
| `Issue #7124 <https://redmine.postgresql.org/issues/7124>`_ - Fixed the schema diff issue where tables have different column positions and a column has a default value.
| `Issue #7152 <https://redmine.postgresql.org/issues/7152>`_ - Added comments column for the functions collection node.
| `Issue #7172 <https://redmine.postgresql.org/issues/7172>`_ - Allow users to scroll and enter input when there is a validation error.
| `Issue #7173 <https://redmine.postgresql.org/issues/7173>`_ - Fixed an issue where the User Management dialog is not opening.
| `Issue #7181 <https://redmine.postgresql.org/issues/7181>`_ - Ensure that the user should be able to add new server with unix socket connection.
| `Issue #7202 <https://redmine.postgresql.org/issues/7202>`_ - Ensure that Flask-Security-Too is using the latest version.

11
web/pgadmin/static/js/SchemaView/FormView.jsx
View File

@ -39,6 +39,10 @@ const useStyles = makeStyles((theme)=>({
nestedControl: {
height: 'unset',
},
errorMargin: {
/* Error footer margin */
marginBottom: '36px',
},
sqlTabInput: {
border: 0,
}
@ -368,7 +372,6 @@ export default function FormView({
onChange={(event, selTabValue) => {
setTabValue(selTabValue);
}}
// indicatorColor="primary"
variant="scrollable"
scrollButtons="auto"
action={(ref)=>ref && ref.updateIndicator()}
@ -379,9 +382,13 @@ export default function FormView({
</Tabs>
</Box>
{Object.keys(finalTabs).map((tabName, i)=>{
let contentClassName = null;
if(fullTabs.indexOf(tabName) == -1) {
contentClassName = clsx(classes.nestedControl, stateUtils.formErr.message ? classes.errorMargin : null);
}
return (
<TabPanel key={tabName} value={tabValue} index={i} classNameRoot={clsx(tabsClassname[tabName], isNested ? classes.nestedTabPanel : null)}
className={fullTabs.indexOf(tabName) == -1 ? classes.nestedControl : null}>
className={contentClassName}>
{finalTabs[tabName]}
</TabPanel>
);