Akshay Joshi
0bf6e81faa
Fixed linter error.
2020-10-09 12:09:23 +05:30
Aditya Toshniwal
a4e746c5a4
Ensure that '.sql' extension is added when saving a file with SQL format.
...
refs #4855
2020-10-09 11:46:32 +05:30
Akshay Joshi
300de05a20
Merged the latest code of 'pgcli' used for the autocomplete feature. Fixes #5497
2020-10-01 13:29:46 +05:30
Akshay Joshi
1c70a43b91
Fixed code smells 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-09-29 15:08:14 +05:30
Aditya Toshniwal
c7c199210d
Fixed an issue where file extension is stripped on renaming a file. Fixes #4855
2020-09-29 11:03:38 +05:30
Aditya Toshniwal
f3462e36a4
Fixed cognitive complexity issues reported by SonarQube.
2020-09-23 11:59:14 +05:30
Aditya Toshniwal
bf183bdcff
Change the explain plan SVG colors based on the theme. Fixed some minor color issues in the analysis tab.
2020-09-17 20:17:54 +05:30
Pradip Parkale
8e132eab08
Fixed some accessibility issues. Fixes #5732
2020-09-15 13:03:18 +05:30
Aditya Toshniwal
b82e6dbdb8
1) Added email id validation on the login page.
...
2) Added validation for the file manager.
2020-09-11 19:55:19 +05:30
Khushboo Vashi
31bbdd6a12
Fixed code smell 'String literals should not be duplicated'.
2020-09-03 18:35:58 +05:30
Aditya Toshniwal
974d395a48
Fixed cognitive complexity issues reported by SonarQube.
2020-09-03 18:10:57 +05:30
Ganesh Jaybhay
fd0ed81f7f
Fixed accessibility issues for main panels.
2020-09-01 12:58:23 +05:30
Cyril Jouve
5a253f9053
Change the following to replace Python 2 code with Python 3:
...
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.
2020-08-31 16:45:31 +05:30
Aditya Toshniwal
275c671576
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 12:39:14 +05:30
Neel Patel
b53de0c31d
Updated some more font awesome icons for v5
2020-08-21 14:15:18 +05:30
Nikhil Mohite
19491d79a5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-21 13:52:05 +05:30
Akshay Joshi
fbbbc36221
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 20:26:51 +05:30
Akshay Joshi
103b08c9c5
Define constants for preferences label to fix SonarQube issues.
2020-08-20 17:58:37 +05:30
Dave Page
79e6480513
Added SQL Formatter support in Query Tool. Fixes #2042
2020-08-20 13:05:00 +05:30
Akshay Joshi
b0af385ea0
Fixed an issue where the entire logs is in red text when the user runs backup and restore. Fixes #5604
2020-08-17 17:23:30 +05:30
Akshay Joshi
8f61944386
1) Added special handling for the extension to resolve the dependency.
...
2) Added 'is_sys_obj' to the ignore list of Schema Diff.
3) Font awesome v5 fixes.
2020-08-13 17:48:04 +05:30
Nikhil Mohite
93adf6884f
Upgrade font awesome from v4 to v5. Fixes #5731
2020-08-13 12:04:00 +05:30
Cyril Jouve
36574b25b6
The 'str' object never has attribute decode in Python3, so remove the dead code.
2020-08-12 18:55:35 +05:30
Yogesh Mahajan
3672013ddc
Fixed an issue where the error message does not have a close button on utility dialogs. Fixes #5670
2020-08-07 17:17:51 +05:30
Aditya Toshniwal
d6400bbcae
Replace the generic exception class with a more specific one.
2020-08-07 12:37:00 +05:30
Yogesh Mahajan
43e127de31
Ensure that the original file format should be retained when saving the same file in SQL editor. Fixes #3767
2020-08-03 13:18:04 +05:30
Aditya Toshniwal
536593bf8a
Fixed following SonarQube issues:
...
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
2020-08-03 12:59:51 +05:30
Aditya Toshniwal
a0893fe43b
Fixed code smell 'variable shadows a builtin' reported by SonarQube.
2020-07-28 16:20:26 +05:30
Cyril Jouve
f93cfe8c4c
Remove old Python 2 compatibility code. Fixes #5700
2020-07-27 11:03:13 +01:00
Aditya Toshniwal
505a3ac960
1) Fixed cognitive complexity issues reported by SonarQube.
...
2) Fixed code smell 'Add a nested comment explaining why this method is
empty, or complete the implementation'.
2020-07-24 11:46:30 +05:30
Nikhil Mohite
3983e2c13c
Fix the following issues for High Contrast Theme:
...
1) Schema diff compare button icon is not visible on hover.
2) Schema diff for identical section text is not readable due to the same color as the background.
3) Removed extra variables used for set text color for explain - Analysis section (Issue related dark theme.).
4) Issue related to the disabled toggle button.
refs #5653
2020-07-20 15:12:46 +05:30
Nikhil Mohite
7edcca9b07
Added High Contrast theme support. Fixes #5653
...
Fixed text color issue in explain analyze for the Dark theme. Fixes #5677
2020-07-20 11:51:21 +05:30
Aditya Toshniwal
9d0f3ce90b
Fixed code smell 'potential hiding of variables declared in an outer scope'.
2020-07-16 19:53:39 +05:30
Akshay Joshi
4f34bc0f0e
Added missing dependencies/dependent and corrected some wrongly identified. Fixes #5666
2020-07-14 18:34:50 +05:30
Aditya Toshniwal
357a9179b1
Fixed convention related issues reported by SonarQube.
2020-07-09 18:55:33 +05:30
Satish V
290cf8271b
Fixed code smell 'Variables should not be shadowed'.
2020-07-09 18:35:04 +05:30
Murtuza Zabuawala
2db9242f5c
Fixed accessibility issue where few dialogs are not rendering properly
...
when we zoomed in browser window 200% and screen resolution is low.
Fixes #5662
2020-07-09 18:18:37 +05:30
Pramod Ahire
a6ce78a8c0
Fixed SonarQube issues in css/scss files.
2020-07-06 19:11:43 +05:30
Aditya Toshniwal
45a03dd663
Fixed 'convention' related code smell reported by SonarQube.
2020-07-06 11:48:23 +05:30
Satish V
4c05287677
Fixed SonarQube code smell 'Variables should not be shadowed'.
2020-06-30 17:26:18 +05:30
Satish V
830ac1cc91
Fixed following SonarQube issues:
...
1. Method/Field names should comply with a naming convention.
2. Conditionals should start on new lines
2020-06-26 13:32:45 +05:30
Khushboo Vashi
c7a16a4bd5
Fixed code smells having rule 'Nested blocks of code should not be left empty'.
2020-06-26 13:18:27 +05:30
Aditya Toshniwal
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
Satish V
a1fd9ea3ce
Fixed issue related to extra semicolons and function naming convention reported by SonarQube.
2020-06-24 16:16:12 +05:30
Akshay Joshi
15c621b1d8
Fixed following SonarQube issues:
...
1) TypeError can be thrown as <variable_name> might be null or undefined here.
2) Unexpected duplicate "white-space".
3) Unexpected missing generic font family.
4) Unexpected shorthand "padding" after "padding-left".
2020-06-24 15:57:01 +05:30
Akshay Joshi
bc24e3643f
More code cleanup for SonarQube.
2020-06-18 16:20:34 +01:00
Yogesh Mahajan
6d3f13076f
Fixed 'Comma operator should not be used' issue reported by SonarQube.
2020-06-18 16:17:55 +05:30
Aditya Toshniwal
f0490a54b7
Fixed redundant tagged issue reported by SonarQube.
2020-06-18 11:14:56 +05:30
Akshay Joshi
5ed1e1e5b6
Fixed some sonarqube issues.
2020-06-17 19:30:56 +05:30
Nikhil Mohite
023a1f222f
Remove duplicate properties in CSS and few js standard fixes reported by SonarQube.
2020-06-15 17:15:15 +05:30