Akshay Joshi
0bf6e81faa
Fixed linter error.
2020-10-09 12:09:23 +05:30
Aditya Toshniwal
a4e746c5a4
Ensure that '.sql' extension is added when saving a file with SQL format.
...
refs #4855
2020-10-09 11:46:32 +05:30
Akshay Joshi
1c70a43b91
Fixed code smells 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-09-29 15:08:14 +05:30
Aditya Toshniwal
c7c199210d
Fixed an issue where file extension is stripped on renaming a file. Fixes #4855
2020-09-29 11:03:38 +05:30
Aditya Toshniwal
f3462e36a4
Fixed cognitive complexity issues reported by SonarQube.
2020-09-23 11:59:14 +05:30
Pradip Parkale
8e132eab08
Fixed some accessibility issues. Fixes #5732
2020-09-15 13:03:18 +05:30
Aditya Toshniwal
b82e6dbdb8
1) Added email id validation on the login page.
...
2) Added validation for the file manager.
2020-09-11 19:55:19 +05:30
Khushboo Vashi
31bbdd6a12
Fixed code smell 'String literals should not be duplicated'.
2020-09-03 18:35:58 +05:30
Aditya Toshniwal
974d395a48
Fixed cognitive complexity issues reported by SonarQube.
2020-09-03 18:10:57 +05:30
Cyril Jouve
5a253f9053
Change the following to replace Python 2 code with Python 3:
...
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.
2020-08-31 16:45:31 +05:30
Neel Patel
b53de0c31d
Updated some more font awesome icons for v5
2020-08-21 14:15:18 +05:30
Akshay Joshi
fbbbc36221
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 20:26:51 +05:30
Akshay Joshi
103b08c9c5
Define constants for preferences label to fix SonarQube issues.
2020-08-20 17:58:37 +05:30
Nikhil Mohite
93adf6884f
Upgrade font awesome from v4 to v5. Fixes #5731
2020-08-13 12:04:00 +05:30
Cyril Jouve
36574b25b6
The 'str' object never has attribute decode in Python3, so remove the dead code.
2020-08-12 18:55:35 +05:30
Yogesh Mahajan
3672013ddc
Fixed an issue where the error message does not have a close button on utility dialogs. Fixes #5670
2020-08-07 17:17:51 +05:30
Aditya Toshniwal
d6400bbcae
Replace the generic exception class with a more specific one.
2020-08-07 12:37:00 +05:30
Yogesh Mahajan
43e127de31
Ensure that the original file format should be retained when saving the same file in SQL editor. Fixes #3767
2020-08-03 13:18:04 +05:30
Aditya Toshniwal
536593bf8a
Fixed following SonarQube issues:
...
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
2020-08-03 12:59:51 +05:30
Aditya Toshniwal
a0893fe43b
Fixed code smell 'variable shadows a builtin' reported by SonarQube.
2020-07-28 16:20:26 +05:30
Cyril Jouve
f93cfe8c4c
Remove old Python 2 compatibility code. Fixes #5700
2020-07-27 11:03:13 +01:00
Nikhil Mohite
7edcca9b07
Added High Contrast theme support. Fixes #5653
...
Fixed text color issue in explain analyze for the Dark theme. Fixes #5677
2020-07-20 11:51:21 +05:30
Aditya Toshniwal
9d0f3ce90b
Fixed code smell 'potential hiding of variables declared in an outer scope'.
2020-07-16 19:53:39 +05:30
Aditya Toshniwal
357a9179b1
Fixed convention related issues reported by SonarQube.
2020-07-09 18:55:33 +05:30
Satish V
290cf8271b
Fixed code smell 'Variables should not be shadowed'.
2020-07-09 18:35:04 +05:30
Murtuza Zabuawala
2db9242f5c
Fixed accessibility issue where few dialogs are not rendering properly
...
when we zoomed in browser window 200% and screen resolution is low.
Fixes #5662
2020-07-09 18:18:37 +05:30
Pramod Ahire
a6ce78a8c0
Fixed SonarQube issues in css/scss files.
2020-07-06 19:11:43 +05:30
Aditya Toshniwal
45a03dd663
Fixed 'convention' related code smell reported by SonarQube.
2020-07-06 11:48:23 +05:30
Satish V
4c05287677
Fixed SonarQube code smell 'Variables should not be shadowed'.
2020-06-30 17:26:18 +05:30
Aditya Toshniwal
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
Satish V
a1fd9ea3ce
Fixed issue related to extra semicolons and function naming convention reported by SonarQube.
2020-06-24 16:16:12 +05:30
Akshay Joshi
bc24e3643f
More code cleanup for SonarQube.
2020-06-18 16:20:34 +01:00
Yogesh Mahajan
6d3f13076f
Fixed 'Comma operator should not be used' issue reported by SonarQube.
2020-06-18 16:17:55 +05:30
Akshay Joshi
5ed1e1e5b6
Fixed some sonarqube issues.
2020-06-17 19:30:56 +05:30
Nikhil Mohite
023a1f222f
Remove duplicate properties in CSS and few js standard fixes reported by SonarQube.
2020-06-15 17:15:15 +05:30
Aditya Toshniwal
641f7bbe9d
Some clumsy coding related fixes reported by SonarQube.
2020-06-15 16:50:07 +05:30
Yogesh Jain
cc2e3ece7a
Ensure that file browse home button should point to /Users/akshayjoshi rather than /. Fixes #4279
2020-05-04 12:40:19 +05:30
Akshay Joshi
ad80217593
Remove Python2 references from the source code.
...
refs #5443
Initial patch: Neel Patel
2020-04-30 17:22:48 +05:30
Libor M
36a3d4e53b
Some more gettext() usage fixes:
...
- fixed `%` vs. `.format()`
- unified texts and usage `%s` vs. `{}`/`{0}`
- improved text sentences for translate
- added gettext for next texts
2020-04-20 11:19:09 +05:30
Murtuza Zabuawala
d35433d0b8
Fixed an issue where the query tool unable to load the file which contains the BOM marker. Fixes #3495
2020-04-17 12:40:09 +05:30
Libor M
8254e9f030
Some minor gettext and format fixes.
2020-04-16 12:55:19 +05:30
Libor M
6a9af07f7a
Fixed gettext usage:
...
- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in the dialog.
- improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
- added gettext for text translations.
2020-04-10 14:52:41 +05:30
Ashesh Vashi
d9f6baac72
Various misc fixes:
...
- Using the 'gettext' as oppose to '_', which is not defined
- Define missing variables
- Fixed escape character in string with double quote
- Removed some dead code in a test case
- Removed unnecessary self assignment
Includes some fixes for Accessibility improvements
- Use semantic markup to mark emphasized or special text
- Added hidden legend in <fieldset> for better screen reader support
2020-04-08 14:14:25 +05:30
Libor M
94864104e4
Added and fixed gettext usage for better translation coverage. Fixes #5284
...
1) Fixed usage gettext('') instead of _('') in javascript files.
2) Fixed usage gettext('') instead of `${gettext('')}` in javascript files,
because "pybabel extract" not support extracting from this syntax.
2020-03-24 11:14:05 +05:30
Murtuza Zabuawala
c9500a5122
Set proper focus on tab navigation for file manager dialog. Fixes #5107
...
- Show focus when the Tab key is pressed
- Pressing the Enter key on C:\ drive does not open it on Windows
2020-02-07 11:13:41 +05:30
Murtuza Zabuawala
989aa462f7
Set proper focus on tab navigation for file manager dialog. Fixes #5107 .
...
Initial patch sent by Ganesh Jaybhay
2020-01-31 11:43:30 +05:30
Simon Wimmesberger
9dccd20bb3
Fix an issue where setting STORAGE_DIR to empty should show all the volumes on Windows in server mode. Fixes #5025 .
2020-01-13 13:20:37 +05:30
Aditya Toshniwal
8b99a33e6e
1) Ensure that path file name should not disappear when changing ext from the dropdown in file explorer dialog. Fixes #3812 .
...
2) Fix column resizable issue in the file explorer dialog. Fixes #4827 .
Used tablesorter's resizable widget.
2020-01-10 12:53:32 +05:30
Dave Page
01c7636c75
Update copyright notices for 2020.
2020-01-02 14:43:50 +00:00
Aditya Toshniwal
f1a18749f6
1) Allow screen-reader to read relationship attributes for tab, tabpanels and tables under it. Similar changes are done for subnode controls.
...
2) Add role="img" for font icons.
Fixes #4764
2019-12-17 13:22:36 +05:30