IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-01-09 07:33:19 -06:00
Code Issues Packages Projects Releases Wiki Activity
7,483 Commits 7 Branches 108 Tags 332 MiB
19c8fcd775
Commit Graph

606 Commits

Author SHA1 Message Date
Yogesh Mahajan
63c7d14638
Added capability to deploy PostgreSQL servers on Google Cloud. #5750 2023-03-13 14:56:16 +05:30
Akshay Joshi
3c56c0e4b7 Revert "Update SQLAlchemy, Flask, Flask-SQLAlchemy, and other packages to current versions. #5901" 
This reverts commit 31818bb67a.
 2023-03-09 16:53:43 +05:30
Aditya Toshniwal
31818bb67a
Update SQLAlchemy, Flask, Flask-SQLAlchemy, and other packages to current versions. #5901 
Remove the python version check from the requirements.txt.
 2023-03-08 18:26:51 +05:30
Nikhil Mohite
9da8a188fa
Added support for mounting shared storage in server mode. #5014 2023-03-06 17:03:47 +05:30
Khushboo Vashi
c35d449d7e
Fix query mogrify issue. 2023-03-06 16:57:31 +05:30
Yogesh Mahajan
740164fbd0
Handle errors occurring during decoding UTF-8 encoded query result data which contains ascii characters. #4784 2023-03-02 11:03:17 +05:30
Akshay Joshi
55b917f24b 1) Ensure that when '--pkg resql' is provided then only RESQL test cases should run. 
2) Fixed the RESQL test cases for Sequences. #5810
 2023-02-28 16:24:29 +05:30
Akshay Joshi
a008f9ba79 Fixed an issue where the database server is not connected using a service file. #5889 2023-02-28 13:29:58 +05:30
Khushboo Vashi
b640df5bdd
Fix Query Tool error messages for psycopg3 driver. 2023-02-22 14:07:05 +05:30
Khushboo Vashi
b9cbf08b51
Another try to fix JSON issues. 2023-02-20 11:21:32 +05:30
Khushboo Vashi
5f52bb59dd
Fix json issues (#5865) 2023-02-16 10:46:39 +00:00
Akshay Joshi
a0b8676f61 Fixed an issue where an object of type bytes is not JSON serializable when saving the data from the query tool. 2023-02-15 15:20:18 +05:30
Khushboo Vashi
5e0daccf76 Added support for psycopg3 along with psycopg2. #5011 2023-02-15 11:31:29 +05:30
Matěj Cepl
7a4951f211
Remove dependency on simplejson package. 2023-02-15 11:10:12 +05:30
Akshay Joshi
0fd1e0963e Fixed an issue where pgAdmin failed to connect when the Postgres password included special characters. #5847 2023-02-13 16:49:18 +05:30
Khushboo Vashi
7a18ceab64
Fixed the server heartbeat logging issue when server is removed. #5567 2023-01-30 15:39:34 +05:30
Akshay Joshi
fd1c26408b Modify the logic to show the connection string for the shared servers. #4728 2023-01-24 17:22:54 +05:30
Khushboo Vashi
7dc0c1d05c
Make the heartbeat normal thread to the daemon thread. #5567 2023-01-24 17:22:29 +05:30
Akshay Joshi
a7cf698d09
1) Added support for setting PostgreSQL connection parameters. #4728 
2) Fixed an issue where Kerberos authentication to the server is not imported/exported. #5732
3) Increase the length of the value column of the setting table. #5746
4) Upgrade Flask-Migrate to 4.0.0. #5525
 2023-01-23 17:19:59 +05:30
Khushboo Vashi
6ae91592d1
Fix orphan database connections resulting in an inability to connect to databases. #5567 2023-01-19 15:57:02 +05:30
Aditya Toshniwal
22cc658dca
Fix failing import servers CLI due to vulnerability fix. #5751 2023-01-18 13:19:21 +05:30
Aditya Toshniwal
8b236e7bc8
Ensure that the authenticated users can't access each other's directories and files by providing relative paths. #5734 2023-01-13 12:29:21 +05:30
Akshay Joshi
98184e5835 Update copyright notices for 2023 2023-01-02 11:53:55 +05:30
Akshay Joshi
cddb24bc50 Fixed an error in the collation create script for PG-15. #5606 2022-12-06 12:50:09 +05:30
Aditya Toshniwal
8d74de09cc
Remove all traces of Backbone, Underscore. #5493 2022-11-21 10:54:15 +05:30
Mark Mayo
41508f7f67
python 3 updates 
- Fix super() calls for python 3
- No need to inherit objects.
- No need for u at the start of strings
- Tidied up some brackets and f-strings too
 2022-11-19 10:13:41 +05:30
Aditya Toshniwal
998c0cb7b3
Fixed issue related to reverse proxy. 
1) Fix reverse proxy redirection in server mode.
2) All reverse proxies in desktop mode.
 2022-11-14 18:58:36 +05:30
Yogesh Mahajan
5e98bf96bc
Ensure that the appropriate permissions are set on the key file before trying an SSL connection with the server in server mode. #5424 2022-10-31 17:59:31 +05:30
Nikhil Mohite
abfc30db8b
Ensure that users can use custom characters as CSV field separators/CSV quotes when downloading query results. #5066 2022-10-20 16:28:42 +05:30
Aditya Toshniwal
d50e9f7fc2
Cleanup code left in previous commit. #5065 2022-10-17 15:42:48 +05:30
Aditya Toshniwal
4fc0f288c7
Use SocketIO instead of REST for fetching database tables data in ERD. #5065 2022-10-17 15:24:22 +05:30
aelgn
a62fc2fbff
Added support for IAM token based authentication for AWS RDS or Azure DB. #3491 2022-10-15 14:49:04 +05:30
Yogesh Mahajan
869b90121c
Ensure that the correct value should be returned if an exception occurs while decoding the password. #5367 2022-09-30 15:08:03 +05:30
Akshay Joshi
0b6b2e733a 1) Remove Python's 'Six' package completely. #5357 
2) Replace deprecated @abstractproperty with @property, @abstractmethod.
 2022-09-26 12:47:31 +05:30
Aditya Toshniwal
4d9dfe7d04 Allow script name URLs in the next URL of the login page. 
refs #5343
 2022-09-20 14:44:05 +05:30
Aditya Toshniwal
e2b00dda1b Fixes a redirect vulnerability when the user opens the pgAdmin URL. Fixes #5343 2022-09-19 15:36:10 +05:30
Yogesh Mahajan
cbf5886430 Fixed the following code smells: 
1. Use concise character class syntax
2. Add a "break" statement or remove this "else" clause.
3. Replace this generic exception class with a more specific one.
4. Use a regular expression literal instead of the 'RegExp' constructor.
5. Use the opposite operator ("not in") instead.
 2022-09-10 13:48:14 +05:30
Nikhil Mohite
d967d5046d Fixed 'Remove the unused function parameter' code smell. 2022-09-09 18:36:51 +05:30
Akshay Joshi
3b95a416ca Fixed 'Remove the unnecessary boolean literals' code smell. 2022-09-09 15:23:18 +05:30
Akshay Joshi
1d0ac0f7dc Moved the feature_tests folder into the regression folder. 2022-09-06 13:59:33 +05:30
Akshay Joshi
72f819ec67 Ensure that the dump servers functionality works from setup.py. Fixes #7644 2022-08-31 14:28:48 +05:30
Akshay Joshi
af1e9210b9 Fixed some security hotspots. 2022-08-26 18:58:16 +05:30
Akshay Joshi
084203debc Fixed Securtiy Hotspot reported by SonarQube. 2022-08-12 17:10:26 +05:30
Aditya Toshniwal
cb635f6706 Removing dynamic module loading and replacing it with static loading. Fixes #7492 
Gets rid of all occurrences and usage of get_own_javascripts since it is no longer used.
 2022-06-30 11:06:50 +05:30
Akshay Joshi
2556771c32 The following issues were fixed in Graph Visualiser: 
1) Allow the user to set the row limit and chart line width.
2) Zoom should only be applied to X-axis, not both.
3) On clicking the 'Generate' button, the chart should return to its original zoom level.
4) Negative values are not displayed.

refs #7485
 2022-06-23 14:52:11 +05:30
Akshay Joshi
93bc1f3c57 Added support for visualise the graph using a Line chart in the query tool. Fixes #7485 2022-06-22 17:18:51 +05:30
Akshay Joshi
4a17ad312f Update pgcli to latest release 3.4.1. Fixes #7411 2022-06-02 17:29:58 +05:30
Akshay Joshi
37b19e0be2 Added PG/EPAS 15 and removed 9.6 from the binary path entry in the preferences dialog. 2022-05-25 17:43:48 +05:30
Akshay Joshi
b36004b702 The following are the initial fixes for PG15: 
1) From PG 15 onward, the datlastsysoid has been removed from the table pg_database.
    We have added the constant _DATABASE_LAST_SYSTEM_OID = 16383, all the objects below
    this value are considered to be system objects. Modified the pgAdmin logic accordingly.

 2) Concatenation operator '||' needs a specific typecast to be applied to query variables. Modified SQL's accordingly.

Fixes #7283
 2022-05-17 20:32:17 +05:30
Akshay Joshi
c56fe813a5 Use gettext to wrap some strings. 2022-04-29 16:18:28 +05:30
Khushboo Vashi
5677b1e5f8 Added capability to deploy PostgreSQL servers on EDB BigAnimal. Fixes #7179 2022-04-26 16:41:10 +05:30
Akshay Joshi
faff8d1fb3 Revert "Disable the master password requirement when using alternative authentication sources. Fixes #7012" 
This reverts commit 0c823455a0.
 2022-04-22 15:58:06 +05:30
Khushboo Vashi
0c823455a0 Disable the master password requirement when using alternative authentication sources. Fixes #7012 2022-04-11 13:45:53 +05:30
Aditya Toshniwal
b5b9ee46a1 1) Port query tool to React. Fixes #6131 
2) Added status bar to the Query Tool. Fixes #3253
3) Ensure that row numbers should be visible in view when scrolling horizontally. Fixes #3989
4) Allow removing a single query history. Refs #4113
5) Partially fixed Macros usability issues. Ref #6969
6) Fixed an issue where the Query tool opens on minimum size if the user opens multiple query tool Window quickly. Fixes #6725
7) Relocate GIS Viewer Button to the Left Side of the Results Table. Fixes #6830
8) Fixed an issue where the connection bar is not visible. Fixes #7188
9) Fixed an issue where an Empty message popup after running a query. Fixes #7260
10) Ensure that Autocomplete should work after changing the connection. Fixes #7262
11) Fixed an issue where the copy and paste row does not work if the first column contains no data. Fixes #7294
 2022-04-07 17:36:56 +05:30
Nikhil Mohite
74e794b416 Port preferences dialog to React. Fixes #7149 2022-03-21 13:29:26 +05:30
Akshay Joshi
1af431dcc2 Fixed a schema diff issue in which user mappings were not compared correctly. Fixes #6956 2022-03-04 17:21:30 +05:30
Khushboo Vashi
a7ee4e5909 Acquire a lock regardless of the authentication sources while getting the database server connection. 2022-02-07 11:25:08 +05:30
Akshay Joshi
1013d7ccdd Fixed code smell reported by SonarQube. 2022-01-20 16:58:21 +05:30
Akshay Joshi
4e414f57e6 Fixed code smell 'Default parameters should be last' reported by SonarQube. 2022-01-12 18:40:18 +05:30
Akshay Joshi
c98fb887cc Fixed code smell 'Unexpected empty arrow function' reported by SonarQube. 2022-01-12 17:32:20 +05:30
Akshay Joshi
e38c38cd58 Fixed following SonarQube code smells: 
1) Remove this useless assignment to a variable.
2) Remove the unused local variable.
 2022-01-12 14:53:19 +05:30
Akshay Joshi
7fe1d89891 Fixed import/export servers issue reported during testing. 2022-01-10 16:16:10 +05:30
Akshay Joshi
55dc06de15 Fixed API test case for Import/Export Servers. 2022-01-09 14:47:32 +05:30
Akshay Joshi
4ecd05e33b 1) Fixed import/export servers issue in server mode. 
2) Fixed an issue where files are not showing as per the selected format in
   the file dialog when opened the first time.
 2022-01-07 21:29:17 +05:30
Akshay Joshi
8b13f158ab Fixed review comments for Import/Export Servers. 
refs #4803
 2022-01-05 14:02:49 +05:30
Akshay Joshi
2786f7ac5a Update copyright notices for 2022 2022-01-04 13:54:25 +05:30
Akshay Joshi
9dd957a2aa Added support to import/export server groups and servers from GUI. Fixes #4803 2022-01-04 12:27:17 +05:30
Nikhil Mohite
bef692d431 Fixed an issue where On-demand rows throw an error when any row cell is edited 
and saved it then scroll to get more rows.

Fixes #7005
 2021-11-28 13:26:40 +05:30
Akshay Joshi
d644b4f94e 1) Replace Flask-BabelEx with Flask-Babel. Fixes #6088 
2) Upgrade Flask to version 2. Fixes #7010
 2021-11-24 17:22:57 +05:30
Akshay Joshi
d2a7f7fffe Fixed API test cases for PG 14 2021-10-20 18:39:42 +05:30
Khushboo Vashi
a726635290 1) Added support for authentication via the web server (REMOTE_USER). Fixes #6657 
2) Fixed OAuth2 integration redirect issue. Fixes #6719

Initial patch for 6657 sent by: Tom Schreiber
 2021-10-12 14:52:30 +05:30
Akshay Joshi
522a92586a Added PG/EPAS 14 binary path entry in the preferences dialog. 2021-09-20 14:59:05 +05:30
Akshay Joshi
eeff75ba20 Remove GPDB support completely. Fixes #6692 2021-09-09 13:09:53 +05:30
Yogesh Mahajan
c7fd1ae535 Enables pgAdmin to retrieve user permissions in case of nested roles which helps to terminate the session for AWS RDS. Fixes #6641 2021-08-24 17:01:06 +05:30
Aditya Toshniwal
fbc6c30b62 Set PSQLRC and PSQL_HISTORY env vars to apt. user storage path in the server mode. Fixes #6691 2021-08-23 16:19:01 +05:30
Akshay Joshi
accc941818 Fixed no attribute '_asdict' error when connecting the database server. Fixes #6663 2021-08-20 13:47:31 +05:30
Akshay Joshi
508f97b08e Rename the "Resize by data?" to "Columns sized by" and disabled the 'Maximum column width' 
button if 'Columns sized by' is set to 'Column data'. Fixes #6622
 2021-07-27 15:17:06 +05:30
Khushboo Vashi
48ca83f31d Added support for OAuth 2 authentication. Fixes #5940 
Initial patch sent by: Florian Sabonchi
 2021-07-06 13:22:58 +05:30
Rahul Shirsat
9fdda038a9 Resolve the log in issue for a user having a non-existing email id 
1) Added CHECK_EMAIL_DELIVERABILITY & SECURITY_EMAIL_VALIDATOR_ARGS.
  2) Added test cases for deliverability check.

Fixes #6550
 2021-07-05 12:55:40 +05:30
Akshay Joshi
ef67409d61 Highlighted long running queries on the dashboards. Fixes #1975 2021-07-01 18:10:55 +05:30
Ashesh Vashi
9574f43f87 Refactor the registry class logic and remove duplicate code for the same functionality. 2021-06-24 11:30:11 +05:30
Akshay Joshi
16d2a3096a 1) Fixed an issue where the binary path is not correctly parsed for version 9.6. Fixes #6534 
2) Added the default binary path in the container. 
3) Fixed the typo in the documentation.
 2021-06-15 19:49:46 +05:30
Akshay Joshi
c2ed799113 If the binary path contains '' then show as it is on GUI if the path contains valid utilities. 2021-06-14 19:23:26 +05:30
Pradip Parkale
3d685ef96c Updated variable name as per review comments. 2021-06-14 16:42:27 +05:30
Akshay Joshi
2fdde6218a Fixed binary path issue on Windows platform. refs #5370 2021-06-14 15:01:49 +05:30
Pradip Parkale
e3190b86ab Fixed an issue where a decimal number is appended for character varying fields while downloading the data in CSV format. Fixes #6520 2021-06-11 19:29:20 +05:30
Akshay Joshi
c86a2b643a 1) Binary path set to the default location in which we install the binaries. 
2) Validate path not working if there is a space in the binary path.
3) Handle the case when the path contains '$DIR'. 

refs #5370
 2021-06-10 22:49:05 +05:30
Akshay Joshi
5a086a9173 Fixed API test cases failed due to wrong handling of default binary path. 2021-06-08 13:24:17 +05:30
Nikhil Mohite
e1067ffe67 Ensure that the Query Tool connection string should not be changed as per the 'Query Tool tab title'. Fixes #6404 2021-06-07 22:07:51 +05:30
Akshay Joshi
07eb541806 1) Added logic to set the appropriate default binary path if DEFAULT_BINARY_PATH is 
set in the config and the user not updated the preferences.
2) Remove 'gpdb' from DEFAULT_BINARY_PATH.
3) Fixed API test cases. 

refs #5370
 2021-06-07 20:36:34 +05:30
Akshay Joshi
4bc4ca1ba9 1) Added browse button to select the binary path in the Preferences. Fixes #1561 
2) Added support to set the binary path for the different database server versions. Fixes #5370
 2021-06-04 17:55:35 +05:30
Yogesh Mahajan
2d58f60a53 Modifies the way to execute feature tests in parallel and it should be configured in Server Mode. 2021-05-27 11:01:25 +05:30
Yogesh Mahajan
faa49687be Added support to rotate the pgadmin log file on the basis of Size and Age. Fixes #6395 2021-05-25 20:18:46 +05:30
Nikhil Mohite
3ddf941cd7 Added support to launch PSQL for the connected database server. Fixes #2341 2021-05-25 20:12:57 +05:30
Khushboo Vashi
7275ce906e 1) Fixed an issue where the user is not warned if Kerberos ticket expiration 
is less than 30 min while initiating a global backup. Fixes #6444

2) Ensure that proper identification should be there when the server is
   connected using Kerberos or without Kerberos. Fixes #6445
 2021-05-14 12:33:01 +05:30
Khushboo Vashi
72f3730c34 Added support to connect PostgreSQL servers via Kerberos authentication. Fixes #6158 2021-05-03 16:10:45 +05:30
Pradip Parkale
5a302684f7 Fixed an issue where long float values cause the rendering issue on the UI side. 
It's a regression of the original commit for 6341.

refs #6341
 2021-04-26 17:16:48 +05:30
Pradip Parkale
5894001eb2 Fixed an issue where CSV download quotes the numeric columns. Fixes #6341 2021-04-22 17:35:51 +05:30
Pradip Parkale
8ae8fea6d2 Ensure that Backup and Restore should work on shared servers as some cases were failing due to initial changes. 
Fixes #6385
 2021-04-22 17:29:04 +05:30
Nikhil Mohite
68132e2a8f Fixed an issue where adding/updating records fails if the table name contains percent sign. 
refs #4438
 2021-03-12 11:59:45 +05:30
Rahul Shirsat
9d8360641f Use schema qualification while accessing the catalog objects. 
refs #3976
 2021-03-12 11:17:25 +05:30
Akshay Joshi
8c7417b735 Fixed regressions from the last commit. 2021-03-03 11:46:47 +05:30
Akshay Joshi
008bc6da28 Fixed some SonarQube issues. 2021-03-02 14:53:05 +05:30
Nikhil Mohite
8279e7e01c Ensure that the user should be able to kill the session from Dashboard if the user has a 'pg_signal_backend' role. Fixes #6159 2021-02-26 12:50:30 +05:30
Pradip Parkale
731ba32e81 1) Added SSL support for creating a subscription. Fixes #6201 
2) Fixed an issue where the user is not able to create the subscription. Fixes #6230
3) Fixed a couple of issues raised during testing of logical replication.
 2021-02-19 14:56:45 +05:30
Nikhil Mohite
36f76f5e2c Fixed autocomplete issue where it is not showing any suggestions if the schema name contains escape characters. Fixes #6045. 2021-01-29 11:45:38 +05:30
Khushboo Vashi
c0ef0a893d 1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457 
2) Fixed incorrect log information for AUTHENTICATION_SOURCES. Fixes #5829
 2021-01-18 16:32:10 +05:30
Nikhil Mohite
d4a3e4d92c Fixed issues reported by SonarQube. 2021-01-18 13:02:19 +05:30
Aditya Toshniwal
0c8226ff39 Added ERD Diagram support with basic table fields, primary key, foreign key, and DDL SQL generation. Fixes #1802 2021-01-16 17:06:50 +05:30
Akshay Joshi
f0debdd513 Revert "1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457" 
This reverts commit 6ead597b43.
 2021-01-14 14:46:59 +05:30
Khushboo Vashi
6ead597b43 1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457 
2) Fixed incorrect log information for AUTHENTICATION_SOURCES. Fixes #5829
 2021-01-14 13:46:48 +05:30
Rahul Shirsat
d55555c544 Fixed an issue where sequences are not created. Fixes #6128 
refs #6084
 2021-01-11 17:29:08 +05:30
Akshay Joshi
b372f08a59 Update copyright notices for 2021 2021-01-04 15:34:45 +05:30
Rahul Shirsat
cb0a914099 Ensure that the 'template1' database should not be visible after pg_upgrade. Fixes #5875 2020-12-16 11:37:19 +05:30
Akshay Joshi
c4d9ef9210 Added connected pgAdmin user and connection name in the log file. Fixes #6052 
Patch By: Nico T
 2020-12-14 12:24:06 +05:30
Rahul Shirsat
6475a70514 Ensure that the macro query result should be download properly. Fixes #5965 2020-12-14 11:58:53 +05:30
Akshay Joshi
296d22ad83 Updated version of 'sqlparse' as pgcli updated and tested it. 2020-12-14 11:39:50 +05:30
Nikhil Mohite
2793747d3c 1) Added support for dynamic tab size. Fixes #4231 
2) Fixed an issue where a long file name is not visible on the process watcher dialog. Fixes #5950
 2020-11-04 17:45:28 +05:30
Ganesh Jaybhay
08c4deba5a Added following security enhancements: 
1) Added ALLOWED_HOSTS list to limit the host address.
  2) Added CSP and HSTS security header.
  3) Hide the webserver/ development framework version.

Fixes #5919
 2020-10-20 17:14:45 +05:30
Nikhil Mohite
be7bb81a19 Allow user to change the database connection from an open query tool tab. Fixes #3794 2020-10-01 13:29:46 +05:30
Akshay Joshi
300de05a20 Merged the latest code of 'pgcli' used for the autocomplete feature. Fixes #5497 2020-10-01 13:29:46 +05:30
Akshay Joshi
1c70a43b91 Fixed code smells 'Define a constant instead of duplicating this literal' reported by SonarQube. 2020-09-29 15:08:14 +05:30
Murtuza Zabuawala 
9e69e13468 Fixed typo in 'get_storage_directory' function. 2020-09-17 20:15:42 +05:30
Aditya Toshniwal
b82e6dbdb8 1) Added email id validation on the login page. 
2) Added validation for the file manager.
 2020-09-11 19:55:19 +05:30
Aditya Toshniwal
796a8a013a 1) Changing the state of the react directly is not recommended, so avoid changing it directly. 
2) Fixed API test cases.
 2020-09-09 13:08:58 +05:30
Aditya Toshniwal
535739c0c7 Fixed cognitive complexity issues reported by SonarQube. 2020-09-09 11:25:43 +05:30
Nikhil Mohite
72f0e87367 Fixed cognitive complexity issues reported by SonarQube. 2020-09-09 11:20:17 +05:30
Pradip Parkale
4da4a05611 Fixed code smell 'Remove duplicates string literals'. 2020-09-07 17:56:02 +05:30
Khushboo Vashi
31bbdd6a12 Fixed code smell 'String literals should not be duplicated'. 2020-09-03 18:35:58 +05:30
Pradip Parkale
b562ab7681 Added shared server support for admin users. Fixes #4979 2020-09-03 12:59:28 +05:30
Aditya Toshniwal
8f3bdf1cf3 Fixed cognitive complexity issues reported by SonarQube. 2020-09-02 14:39:54 +05:30
Cyril Jouve
5a253f9053 Change the following to replace Python 2 code with Python 3: 
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.
 2020-08-31 16:45:31 +05:30
Yogesh Mahajan
3984544bdb Fixed code smell 'String literals should not be duplicated'. 2020-08-28 18:17:27 +05:30
Nikhil Mohite
d2577e32e6 Fixed cognitive complexity issues reported by SonarQube. 2020-08-25 18:13:01 +05:30
Akshay Joshi
103b08c9c5 Define constants for preferences label to fix SonarQube issues. 2020-08-20 17:58:37 +05:30
Khushboo Vashi
cc5a7ea334 Fixed code smell 'String literals should not be duplicated'. 
Create a constant.py file which contains the common Constants.
 2020-08-19 14:16:02 +05:30
Cyril Jouve
36574b25b6 The 'str' object never has attribute decode in Python3, so remove the dead code. 2020-08-12 18:55:35 +05:30
Aditya Toshniwal
caeea7940a Fixed errors occurring when saving preferences, regression of SonarQube fixes. 2020-08-12 17:42:53 +05:30
Yogesh Mahajan
1f70385a4e Fixed an issue where conversion of bytea to the binary string results in an error. Fixes #5567 2020-08-11 15:31:14 +05:30
Aditya Toshniwal
8129df42da Fixed cognitive complexity issues reported by SonarQube. 2020-08-11 15:13:35 +05:30
Cyril Jouve
7a0bfecfc5 Use Python3 'ipaddress' module to validate the IPv4 and IPv6 addresses. 2020-08-10 15:57:25 +05:30
Aditya Toshniwal
d6400bbcae Replace the generic exception class with a more specific one. 2020-08-07 12:37:00 +05:30
Akshay Joshi
aac0da4cbc Fixed ssh tunnel hang issue when the user tries to disconnect the server. Fixes #4361 2020-08-06 16:16:37 +05:30
Aditya Toshniwal
aa679e06b2 Replace the generic exception class with a more specific one to fix SonarQube issues. 2020-08-05 12:41:28 +05:30
Aditya Toshniwal
536593bf8a Fixed following SonarQube issues: 
- Remove this assignment to the local variable, the value is never used.
  - Rename local variables to match the regular expression
  - Add logic to this except clause or eliminate it and rethrow the exception automatically.
  - Rename fields to match the regular expression
  - Extract this nested conditional expression into an independent statement.
  - Change this default value to "None" and initialize this parameter inside the function/method.
  - Update this function so that its implementation is not identical to __repr__
  - Refactor this method to not always return the same value
  - Reraise this exception to stop the application as the user expects
  - Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
  - Remove this redundant continue.
  - Remove this unused function declaration
  - Remove this identity check; it will always be False.
 2020-08-03 12:59:51 +05:30
Nikhil Mohite
eb2c554601 Fixed cognitive complexity issues reported by SonarQube. 2020-08-03 12:46:34 +05:30
Aditya Toshniwal
56cf64ad22 Fixed following SonarQube issues: 
- Refactor functions to not always return the same value.
  - Rename "cls" to "self" or add the missing "self" parameter.
  - Remove useless assignment to variables.
 2020-07-30 14:04:22 +05:30
Cyril Jouve
f93cfe8c4c Remove old Python 2 compatibility code. Fixes #5700 2020-07-27 11:03:13 +01:00
Yogesh Mahajan
dd27e08a98 Fixed code smell 'Unused local variables should be removed'. 2020-07-24 12:15:29 +05:30
Aditya Toshniwal
505a3ac960 1) Fixed cognitive complexity issues reported by SonarQube. 
2) Fixed code smell 'Add a nested comment explaining why this method is
   empty, or complete the implementation'.
 2020-07-24 11:46:30 +05:30