Murtuza Zabuawala
f0202228d0
Increase the default size of the Grant Wizard to enable it to properly display privileges at the default size on smaller displays. Fixes #2013
2017-06-21 11:08:23 +01:00
Dave Page
9829d74a04
Correct the v10 template path.
2017-06-20 12:04:13 +01:00
Murtuza Zabuawala
34518d328e
No need for the menu icon to link to the homepage, as pgAdmin is a SPA. Fixes #2479
2017-06-20 10:28:35 +01:00
Murtuza Zabuawala
d2ba57c1ab
Properly handle bytea[], and 'infinity'::real/real[]. Fixes #2498 . Fixes #2502 .
2017-06-20 10:19:11 +01:00
Khushboo Vashi
1ee555e468
Ensure the feature tests use the correct test settings database. Fixes #2486
2017-06-16 10:17:38 +01:00
Ashesh Vashi
900ccebb50
Using client-side implementation of 'url_for' in the settings module.
2017-06-16 08:57:23 +05:30
Ashesh Vashi
5c140b3f58
Using client-side 'url_for' implementation in the user management
...
module.
2017-06-16 00:16:30 +05:30
Ashesh Vashi
e65b605912
Using client-side 'url_for' implementation in the import/export module.
2017-06-16 00:00:17 +05:30
Ashesh Vashi
07580b8444
Using client-side 'url_for' implementation in the maintenance module.
2017-06-15 23:50:53 +05:30
Surinder Kumar
2a87585665
Fix script options which were inadvertently broken in the query tool tab naming patch.
2017-06-15 12:19:47 +01:00
Murtuza Zabuawala
d70c3003d3
Add double precision[] tests to the query tool.
2017-06-15 11:54:17 +01:00
Murtuza Zabuawala
8376d33d77
Fix canceling of Grant Wizard on Windows. Fixes #2142
2017-06-15 11:42:13 +01:00
Surinder Kumar
fdc9eed514
Ensure text editors render in an appropriate place on the results grid. Fixes #2477
2017-06-14 12:18:27 +01:00
Surinder Kumar
2b4a8ed89c
Un-break the feature tests. Fixes from Surinder and myself.
2017-06-14 09:59:11 +01:00
Joao Pedro De Almeida Pereira
4b846ae4e0
Fix the JS Bundler test to work when there are multiple servers defined in a test run.
2017-06-14 09:37:20 +01:00
Dave Page
cb97722fc3
Temporarily disable the Javascript bundler test until it handle more than one run.
2017-06-13 14:21:41 +01:00
Surinder Kumar
57d866f7b7
Use a more sensible name for Query Tool tabs. Fixes #2482
2017-06-13 11:34:24 +01:00
Akshay Joshi
794b70daea
Fixed issue of opening file manager dialog from Query Tool.
2017-06-13 15:48:12 +05:30
Joao Pedro De Almeida Pereira
a9ce9c9717
Skip a test that uses the COLLATE option on PG versions below 9.1 (e.g. Greenplum).
2017-06-13 10:27:09 +01:00
Shruti B Iyer
1208206bc0
Initial re-vamp of the History tab.
2017-06-13 09:50:41 +01:00
Khushboo Vashi
16a15bf934
Fix the fix for RM2324.
2017-06-13 09:18:44 +01:00
Ashesh Vashi
0243d886c3
Using client-side 'url_for' implementation in the Grant-Wizard module.
2017-06-13 11:47:55 +05:30
Ashesh Vashi
f9a3878220
Using client-side 'url_for' implementation in the restore module.
2017-06-13 11:00:17 +05:30
Ashesh Vashi
4a46f7b1eb
Using client-side 'url_for' implementation in the backup module.
2017-06-13 10:59:11 +05:30
Ashesh Vashi
1a7c9d5ca1
Using client-side 'url_for' implementation in the module - bgprocess
...
(background-processes).
2017-06-13 09:18:48 +05:30
Shruti B Iyer
f1acad85db
Add a missing translation call.
2017-06-12 17:20:40 +01:00
Shruti B Iyer
3f4f8b9e77
Add linting support, and, well, lint.
2017-06-12 16:55:14 +01:00
Shruti B Iyer
659eb1c1e8
Bring React into the tree, and add linting and bundling framework for the JS etc.
2017-06-12 16:51:54 +01:00
Surinder Kumar
af43ccfc07
Teach dialogues about Escape to cancel, Enter to Save/OK, and F1 for help. Fixes #1535
2017-06-12 16:43:29 +01:00
Murtuza Zabuawala
ec5bc23dfd
Allow editing of the WITH ADMIN option of role membership. Fixes #2086
2017-06-12 13:58:51 +01:00
Murtuza Zabuawala
3743c6e86e
Refresh the SQL editor view on resize to ensure the contents are re-rendered for the new viewport. Fixes #2078
2017-06-12 13:25:52 +01:00
Murtuza Zabuawala
c435d48885
Properly handle trigger functions with parameters. Fixes #2043
2017-06-12 13:19:49 +01:00
Atul Sharma
49cd578816
Fix error on the stats tab with PG10. Also, rename the 10.0_plus template directory to 10_plus to match the new versioning. Fixes #2450
2017-06-12 12:53:09 +01:00
Khushboo Vashi
8bd8ae001b
Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for Table, Column, Foreign Table and Type node. Fixes #2324
...
Note that this doesn't add full support for PostGIS types to the table/column dialogues, which still can't handle the typmod usage. It does bring support to parity with pgAdmin 3 though.
2017-06-12 12:49:17 +01:00
Ashesh Vashi
fd3ddbeafb
Implementation of the client side 'url_for(...)' function.
...
Created a url_for function module to be used by different javascript
modules to use the same functionality of flask at client side.
A python module can expose the list of endpoints, used by its
javascripts, by overriding the 'get_exposed_url_endpoints(self)'
function.
In this patch, we have modified all the browser modules to use this
function. It will allow us to move the majority of the javascript
modules of browser nodes from templates directory to the static
directory.
TODO::
- Move these javascripts modules to the static directory.
- Use this function in all the applicable javascript modules.
e.g. tools, miscellaneous modules
2017-06-12 12:01:25 +05:30
Surinder Kumar
49976b1934
Fine tune result grid column sizing now we don't have checkboxes.
2017-06-09 09:24:20 +01:00
Sarah McAlear
ee4a847784
Use the correct font for the treeview.
2017-06-09 09:09:39 +01:00
Surinder Kumar
73c6f1ca3b
A little leanup of the styling of the edit grid
2017-06-08 17:06:34 +01:00
Harshal Dhumal
aa400cbc12
Fix integer/numeric validation on various dialogues. Fixes #2421
2017-06-08 14:59:26 +01:00
Murtuza Zabuawala
3bcbc50525
Fix the handling of double precision[] type. Fixes #1928
2017-06-08 14:50:51 +01:00
Surinder Kumar
c9b717ed68
Set focus on the first enabled field when a dialogue is opened. Fixes #1533
2017-06-08 14:37:31 +01:00
Sarah McAlear
01bfa88309
Improvements to the Query Results grid:
...
- Improve the UI
- Allow copy/paste from sets of rows, columns or arbitrary blocks of cells
Patch by Matt, Shruti, Joao and Sarah @ Pivotal
Fixes #2476
2017-06-08 13:31:36 +01:00
Surinder Kumar
2fddf750e6
Retain column sizing in the query tool results grid when the same query is re-run multiple times in a row. Fixes #1971
2017-06-08 12:41:56 +01:00
Murtuza Zabuawala
678b891ff7
Fix an intermittent error seen during result polling. Fixes #2470
2017-06-08 12:34:14 +01:00
Murtuza Zabuawala
b149fe371e
Fix various issues with pgAgent job steps and schedules:
...
1) Error on clicking SQL panel when Schedule OR Step node is selected in browser. Fixes #1888
2) Error while dropping Schedule OR Step node. Fixes #1889
3) Newly created Schedule/Step node was not displaying in browser. Fixes #1890
2017-06-08 12:30:00 +01:00
Surinder Kumar
88737248ab
Fix a couple of missing greys.
2017-06-07 16:31:47 +01:00
Surinder Kumar
63c093248d
Allow users to remove default values from columns properly. Fixes #2461
2017-06-07 14:33:28 +01:00
George Gelashvili
f89aec867a
Resolve the PG datatype feature test flakiness and make for a nice buttery crust.
2017-06-07 14:26:42 +01:00
George Gelashvili
8d8e7dab3c
Extract row staging into it's own module with tests.
2017-06-07 14:17:10 +01:00
Shruti B Iyer
0d05385585
Update the styling to use the set of grays defined in the WIP style guide.
2017-06-07 13:57:49 +01:00
Murtuza Zabuawala
495a3cedb0
List packages in PPAS 9.2-9.4 when creating synonyms. Fixes #1813
2017-06-07 13:44:36 +01:00
Khushboo Vashi
b134ae2cb4
Fix the RE-SQL for for views to properly qualify trigger function names. Fixes #2381
2017-06-07 13:40:11 +01:00
Ashesh Vashi
ae80976689
Using the client-side translation using the client-side 'gettext'
...
implementation.
This is the first step towards 'Avoid creating the javascript modules
using Jinja templates'.
2017-06-07 15:53:05 +05:30
Murtuza Zabuawala
7e9f82bc17
Prevent attempts to debug procedures with variadic arguments. Fixes #1466
2017-06-06 12:58:52 +01:00
Surinder Kumar
beda7ebbf2
Add feature tests for the View Data tool.
2017-06-06 12:54:20 +01:00
Murtuza Zabuawala
9803468a77
Properly display security labels on EPAS 9.2+. Fixes #1575
2017-06-06 11:46:49 +01:00
Murtuza Zabuawala
cd3484d936
Make $ quoting consistent. Fixes #1525
2017-06-06 11:40:25 +01:00
Surinder Kumar
b82e001478
Ensure that boolean checkboxes cycle values in the correct order. Fixes #2448
2017-06-06 11:29:18 +01:00
Murtuza Zabuawala
bf06d82870
Fix validation for external and range types. Fixes #1795
2017-06-06 11:24:10 +01:00
Murtuza Zabuawala
e6aa3e1494
Fix default values and SQL formatting for event triggers. Fixes #1229
2017-06-06 11:19:40 +01:00
Dave Page
4c2004d479
Correct the validation logic when modifying indexes/exclusion constraints. Fixes #2113
2017-06-06 11:15:51 +01:00
Khushboo Vashi
d21cbb8b1f
Handle composite primary keys correctly when deleting rows in the Edit Grid. Fixes #2425
2017-06-06 09:58:47 +01:00
Murtuza Zabuawala
4b74a5ff35
Enable dialogue help buttons on Language and Foreign Table dialogues. Fixes #2116
2017-06-06 09:52:44 +01:00
Murtuza Zabuawala
0bc9997a95
Properly refresh the parent node when renaming children. Fixes #2355
2017-06-06 09:50:05 +01:00
Dave Page
9e98ded06c
Display and allow toggling of trigger enable/disable status from the trigger dialogue. Fixes #2386
2017-06-05 17:11:21 +01:00
Murtuza Zabuawala
3f150f3f4e
Handle procedure flags (IMMUTABLE STRICT SECURITY DEFINER PARALLEL RESTRICTED) properly in RE-SQL on EPAS. Fixes #2280
2017-06-05 17:04:55 +01:00
Murtuza Zabuawala
a4d86d24e6
Cache statistics more reliably. Fixes #2357
2017-06-05 17:01:03 +01:00
Surinder Kumar
456096092d
Avoid re-rendering the edit grid for every row that is pasted.
2017-05-30 16:22:11 +01:00
Surinder Kumar
1f26953504
Cleanup handling of default/null values when data editting. FIxes #2400
2017-05-27 14:51:02 -04:00
Murtuza Zabuawala
8aabee352c
Import the ordereddict module for Python 2.6
2017-05-26 12:34:05 -04:00
Murtuza Zabuawala
2c9af4784e
Allow creation of ENUM types with no members. Fixes #2426
2017-05-26 12:21:23 -04:00
Murtuza Zabuawala
dba64e77f1
Order columns in multi-column pkeys correctly. Fixes #2417
2017-05-26 11:04:32 -04:00
Murtuza Zabuawala
45d423c0ce
Ensure the last placeholder is included when generating UPDATE scripts for tables. Fixes #2436
2017-05-26 10:59:09 -04:00
Murtuza Zabuawala
a45bb905f5
Pass the database ID to the query tool when using the Script options. Fixes #2435
2017-05-26 10:57:31 -04:00
Khushboo Vashi
3216eca4a8
Add feature tests to ensure that data types are properly rendered in the query tool.
2017-05-26 10:46:58 -04:00
Dave Page
2f097cd016
Fix typo in freshly added check.
2017-05-25 17:10:41 -04:00
Murtuza Zabuawala
e9da157cc7
Add numerous missing checks to ensure objects really exist when we think they do. Fixes #2427
2017-05-25 16:28:04 -04:00
Dave Page
04ce72a6ae
Fix RE-SQL for rules which got the table name wrong in the header and DROP statement. Fixes #2422
2017-05-19 12:21:29 +01:00
Murtuza Zabuawala
eb18320950
Improve error handling in cases where the user tries to rename or create a server group that would duplicate an existing group. Fixes #2414
2017-05-17 15:57:38 +01:00
Dave Page
17de7db70b
Fix server stats display for EPAS 9.2, where inet needs casting to text for concatenation. Fixes #1831
2017-05-17 15:53:13 +01:00
Murtuza Zabuawala
a3226b1eb5
Reverse engineer SQL for table-returning functions correctly. Fixes #1851
2017-05-17 15:49:56 +01:00
Murtuza Zabuawala
655d5888a6
Various FTS dictionary cleanups. Fixes #1126
2017-05-17 14:13:05 +01:00
Surinder Kumar
1db81da020
Fix JS error when selecting a single grid cell.
2017-05-16 08:44:29 +01:00
Dave Page
be42b67f79
Ensure all required directories are created before we start logging.
2017-05-15 15:59:47 +01:00
Surinder Kumar
d7d4bf475b
Various improvements to the NULL/DEFAULT handling in the data editor. Fixes #2399
2017-05-15 15:04:16 +01:00
Murtuza Zabuawala
1cb2a62fa8
Ensure object names are properly escaped for external process management. Fixes #2405
2017-05-15 13:01:12 +01:00
Murtuza Zabuawala
2ad14b379e
Validate table presence in SQL and Properties route handles. Fixes #2395
2017-05-15 10:15:09 +01:00
Joao Pedro De Almeida Pereira
3bf17d9df4
1) Splits the SQL query used to retrieve the Dependents, Dependencies, and Roles SQL file into multiple versioned files.
...
2) Add Unit Tests for each file.
3) Add ORDER BY into Copy Selection Feature test to ensure the results are retrieved always in the same order
4) Renamed the Scenario of the xss_checks_pgadmin_debugger_test and skip it for versions less than 9.1
5) Deleted unused __init__.py files.
2017-05-15 10:40:46 +05:30
Surinder Kumar
0e7efc0cf8
Track disabled rows properly in the edit grid.
2017-05-12 16:42:06 +01:00
Murtuza Zabuawala
aea0d93390
Hide menu options for creating objects, if the object type is set to hidden. Includes Jasmine tests. Fixes #2225
2017-05-12 12:10:46 +01:00
Dave Page
dd318e679d
Minor colour tweaks for highlighted rows in the data editor. These are likely to be changed again when we overhaul and standardise the colouring, but at least now they're using colours from the style guide.
2017-05-12 11:29:46 +01:00
Surinder Kumar
4f9628ed43
Improve handling of nulls and default values in the data editor. Fixes #2257
2017-05-12 10:53:57 +01:00
Murtuza Zabuawala
05787fdba9
Properly handle non-ASCII column names in CSV. Fixes #2314
2017-05-12 10:38:23 +01:00
Murtuza Zabuawala
94cbd70370
Don't change the trigger icon back to "enabled" when the trigger is updated when it's disabled. Fixes #2271
2017-05-10 09:48:21 +01:00
Murtuza Zabuawala
9452e0699e
Allow creation of tables with pure numeric names. Fixes #2284
2017-05-10 09:40:32 +01:00
Andrei Antonov
cbf2de6c27
HTML escape the label, when setting the collection node count along
...
with the label of the tree-nodes.
2017-05-10 13:26:18 +05:30
Murtuza Zabuawala
13f4432bbd
Support loading files with Unicode BOMs. Fixes #2369
2017-05-09 12:06:49 +01:00
Neel Patel
d0e9c82fea
Fixes #2328
...
1) Fixed issue of opening Query Tool and Debugger in new Tab with QT 5.8 and annulen webkit
2) Moved unload event of window from javascript files to html.
3) Change alertify messages for debugger.
4) Closed all connections created by debugger. Previously only one connection has been closed.
2017-05-09 13:03:44 +05:30
Murtuza Zabuawala
63d42745ef
Fix various issues in CSV file download feature:
...
1) To handle non-ascii filenames which we set from table name. Fixes #2314
2) To handle non-ascii query data. Fixes #2253
3) To dump JSON type columns properly in csv. Fixes #2360
2017-05-08 13:36:11 +01:00
Harshal Dhumal
a80f760933
Only reconnect to databases that were previously connected. Fixes #2292
2017-05-08 12:36:51 +01:00