Aditya Toshniwal
505a3ac960
1) Fixed cognitive complexity issues reported by SonarQube.
...
2) Fixed code smell 'Add a nested comment explaining why this method is
empty, or complete the implementation'.
2020-07-24 11:46:30 +05:30
Aditya Toshniwal
bd15d2d0f7
Fixed CSRF errors when pgAdmin opened in an iframe on safari browser. Fixes #5675
2020-07-17 15:31:04 +05:30
Khushboo Vashi
bd9dc97b4f
Fixed code smell 'Functions, methods, and lambdas should not have too many parameters' reported by SonarQube.
2020-07-14 19:23:50 +05:30
Ashesh Vashi
1889c256e1
Fixed a typo in the psycopg2 driver in fetching result with
...
'execute_scalar' while attempting to reconnect.
2020-07-13 22:45:01 +05:30
Aditya Toshniwal
357a9179b1
Fixed convention related issues reported by SonarQube.
2020-07-09 18:55:33 +05:30
Yogesh Mahajan
3c08e618bd
Fixed an issue where CSV download quotes numeric columns. Fixes #5463
2020-07-09 18:11:46 +05:30
Akshay Joshi
102d6e7a9a
Fixed an issue where panels get disappeared. Regression of SonarQube fix.
2020-06-29 14:05:07 +05:30
Akshay Joshi
b91f6f0f5c
Fixed an issue where the semicolon is misplaced in RLS Policy SQL.
...
Fixed one regression issue introduced by renaming the method 'gc' to 'gc_timeout'.
2020-06-26 19:24:54 +05:30
Satish V
830ac1cc91
Fixed following SonarQube issues:
...
1. Method/Field names should comply with a naming convention.
2. Conditionals should start on new lines
2020-06-26 13:32:45 +05:30
Pradip Parkale
5206dafb35
Fixed code smells having rule 'Rename class name to match the regular expression'.
2020-06-26 13:23:23 +05:30
Khushboo Vashi
c7a16a4bd5
Fixed code smells having rule 'Nested blocks of code should not be left empty'.
2020-06-26 13:18:27 +05:30
Aditya Toshniwal
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
Satish V
a1fd9ea3ce
Fixed issue related to extra semicolons and function naming convention reported by SonarQube.
2020-06-24 16:16:12 +05:30
Yogesh Mahajan
caebdcfa91
Ensure that the query tool should display the proper error message while terminating the active session. Fixes #3591
2020-06-22 17:09:10 +05:30
Aditya Toshniwal
df05efd7d9
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation.
2020-06-17 17:15:09 +05:30
Aditya Toshniwal
641f7bbe9d
Some clumsy coding related fixes reported by SonarQube.
2020-06-15 16:50:07 +05:30
Yogesh Mahajan
92d9c41da7
Fixed connection and version number detection issue when the database server is upgraded. Fixes #5507
2020-06-04 18:18:11 +05:30
Satish V
d22e276586
Ensure that proper error should be displayed for the deleted node. Fixes #3669
2020-06-03 11:26:26 +05:30
Yogesh Mahajan
09b76b306c
Fixed typo in exception keyword. Fixes #5539
2020-05-28 18:11:41 +05:30
Khushboo Vashi
0f56c25893
Changed the user identity from email to username in the log file.
...
refs #5452
2020-05-18 11:01:20 +05:30
Akshay Joshi
c0451cd454
Added connected pgAdmin user and connection name in the log file. Fixes #5452
...
Patch By: Nico T
2020-05-13 17:43:21 +05:30
Akshay Joshi
0620fafb6c
Fixed PEP8 issues discovered after pycodestyle gets upgraded.
2020-05-13 17:14:32 +05:30
Akshay Joshi
46e9924ebb
Fixed Unicode decode error 'utf-8' codec can't decode byte. Fixes #5510
...
It's a regression of commit id: 04d6d4e2ccc129baa698471ce0680ccabe2282be
2020-05-12 17:22:22 +05:30
Yogesh Mahajan
1294c089a8
Implement Selenium Grid to run multiple tests across different browsers, operating systems, and machines in parallel. Fixes #5255
2020-05-11 12:11:31 +05:30
Ashesh Vashi
e73e2d2502
Fixed the errors, and warnings reported by pylama.
...
TODO::
- Don't use unicode in Python 3 for removing the support of Python 2 (
psycopg2 driver - __init__.py, server_manager.py).
- Merge the lastest pgcli (version: 3.0.0) for SQL autocompletion.
2020-05-08 14:13:38 +05:30
Khushboo Vashi
d68e6bd892
Remove Python2 modules.
...
refs #5443
2020-05-08 12:28:21 +05:30
Dave Page
04d6d4e2cc
Remove support for Python 2. Fixes #5443
2020-05-04 14:58:49 +01:00
Akshay Joshi
ad80217593
Remove Python2 references from the source code.
...
refs #5443
Initial patch: Neel Patel
2020-04-30 17:22:48 +05:30
Dave Page
86afec860f
Remove Python 2 support from the Python tests.
...
refs #5443
2020-04-30 12:56:45 +05:30
Khushboo Vashi
0f6abcc7fa
Fixed an issue where the user is not able to create a server if login with an LDAP account. Fixes #5439
...
Improved LDAP error messages.
2020-04-27 15:33:19 +05:30
Akshay Joshi
4c616f32eb
1) Fixed feature test and API test cases.
...
2) Added logic to exclude RESQL test cases.
2020-04-22 13:57:32 +05:30
Ashesh Vashi
d9c84edf9a
A valid ip address can be IPv4/IPv6
2020-04-14 18:45:45 +05:30
Libor M
6a9af07f7a
Fixed gettext usage:
...
- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in the dialog.
- improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
- added gettext for text translations.
2020-04-10 14:52:41 +05:30
Ashesh Vashi
1a34f61b24
Moved the ip-address check functionality to a separate file to improve
...
the maintainability of the code.
2020-04-08 16:50:14 +05:30
Aditya Toshniwal
c9d04684ce
Ensure that all the transactions should be canceled before closing the connections when a server is disconnected using pgAdmin. Fixes #5142
2020-02-28 14:12:44 +05:30
Aditya Toshniwal
915b09255c
Added Python 3.8 support. Fixes #5179
...
1) Upgraded passlib==1.7.1 to passlib==1.7.2
2) Replace unmaintained Flask-Security with maintained Flask-Security-Too package, which is also compatible with python 3.8
3) Other compatibility code changes.
2020-02-18 12:10:38 +05:30
Akshay Joshi
2ae279a382
Remove the deprecated 'is_xhr' parameter of flask.request object.
2020-02-10 12:31:52 +05:30
Khushboo Vashi
45f2e35a99
Added Schema Diff tool to compare two schemas and generate the difference script.
...
Currently supported objects are Table, View, Materialized View, Function and Procedure.
Backend comparison of two schemas implemented by: Akshay Joshi
Fixes #3452 .
2020-01-10 15:42:09 +05:30
Pradip Parkale
ed279cac31
Improve the test framework to run for multiple classes defined in a single file. Fixes #5071 .
2020-01-10 11:48:36 +05:30
Dave Page
01c7636c75
Update copyright notices for 2020.
2020-01-02 14:43:50 +00:00
Aditya Toshniwal
4ed2d74d9c
1) Fix network disconnect issue while establishing the connection via SSH Tunnel and it impossible to expand the Servers node. Fixes #4724 .
...
2) Fix server connection drops out issue in query tool. Fixes #4818
3) Fix VPN network disconnect issue where pgAdmin4 hangs on expanding the Servers node. Fixes #4926 .
4) Ensure that the Servers collection node should expand independently of server connections. Fixes #4933 .
Set the default connection timeout to 10 seconds instead of 0.
2019-11-26 09:04:41 +05:30
Akshay Joshi
de878b3198
Refactored code of table and it's child nodes.
...
1) Remove duplicate logic.
2) Child node specific logic should be inside the child node and table node gets the required information from the respective child node.
Note:- Refactoring of columns node still in progress.
Fixes #4807
2019-11-15 14:45:55 +05:30
Akshay Joshi
f22134dabd
Ensure that the superuser should be able to create database and role, as the superuser
...
overrides all the access restrictions.
Fixes #4792 Fixes #4878
2019-11-14 18:14:53 +05:30
Yosry Muhammad
687204771c
Add support in query history to show internal queries generated by pgAdmin during save data operations. Fixes #4612
2019-08-16 17:17:12 +05:30
Aditya Toshniwal
db7a2e3023
Add a --modules option to the RE-SQL test suite to allow testing of specific object types. Fixes #4560
2019-08-06 13:43:49 +01:00
Dave Page
3f4d5a687b
Rename horribly named function.
2019-07-12 13:00:23 +01:00
Akshay Joshi
776884860e
Ensure parameter values are quoted when needed when editing roles. Fixes #4393
2019-07-04 15:00:29 +01:00
Aditya Toshniwal
0d42f8026c
Fix SSH tunnel password decryption. Fixes #4320
2019-06-25 07:06:04 -04:00
Aditya Toshniwal
6e8ebbd375
Allow editing of data where a primary key column includes a % sign in the value. Fixes #4036
...
Fix an XSS issue seen in View/Edit data mode if a column name includes HTML. Fixes #4367
2019-06-20 12:21:37 +01:00
Akshay Joshi
9e65c971a3
Add a framework for testing reversed engineered SQL and CRUD API endpoints. Fixes #4202
2019-06-18 14:28:25 +01:00