Yogesh Mahajan
6d3f13076f
Fixed 'Comma operator should not be used' issue reported by SonarQube.
2020-06-18 16:17:55 +05:30
Aditya Toshniwal
a278e8b1e6
Fixed the master password issue, introduced in the last commit.
2020-06-18 15:38:38 +05:30
Aditya Toshniwal
f0490a54b7
Fixed redundant tagged issue reported by SonarQube.
2020-06-18 11:14:56 +05:30
Akshay Joshi
5ed1e1e5b6
Fixed some sonarqube issues.
2020-06-17 19:30:56 +05:30
Yogesh Mahajan
7c12ade161
Fixed issue related to shadowing variables reported by SonarQube.
2020-06-17 17:08:23 +05:30
Yogesh Mahajan
2ae5c0ec4f
Fixed an issue where select all checkbox only selects the first 50 tables. Fixes #4226
2020-06-16 11:05:10 +05:30
Khushboo Vashi
8ab358ccec
Fix following issues reported by SonarQube:
...
1) Properties of variables with "null" or "undefined" values should not be accessed
2) Variables should not be self-assigned
3) "in" should not be used with primitive types
2020-06-15 16:50:07 +05:30
Dave Page
85e89c869a
Cleanup some code smells identified by SonarQube.
2020-06-10 16:42:59 +01:00
Aditya Toshniwal
eb971a0320
Update Codemirror version to the latest which allows us to set screen reader labels on Codemirror editor.
...
refs #5197
2020-06-08 12:26:12 +05:30
Satish V
d22e276586
Ensure that proper error should be displayed for the deleted node. Fixes #3669
2020-06-03 11:26:26 +05:30
Akshay Joshi
9b8902dfb8
Fixed the SQL help issue for EDB Postgres Advanced Server. Fixes #4099
2020-05-22 14:11:58 +05:30
Satish V
9338bdcb3a
Fixed an issue where the newly added table is not alphabetically added to the tree. Fixes #5434
...
Fixed an issue when renaming the column not added in the proper order. Fixes #5450
2020-05-08 12:52:03 +05:30
Satish V
b80784f5a1
Fixed an issue where the user should not be able to add columns in the creation order after 50 columns.
...
Regression of the initial patch.
Fixes #5043
2020-04-27 18:01:09 +05:30
Aditya Toshniwal
90849fe29b
Fixed mouse click issue where it does not select an object in Browser unless the pointer is over the object. Fixes #4180
2020-04-24 11:32:11 +05:30
Satish V
2e29f3fd6d
Fixed an issue where columns names should be visible in the order of their creation in the browser tree. Fixes #5043
2020-04-23 16:42:42 +05:30
Ashesh Vashi
637c80c38b
Recreate the node item in the tree, when 'id' has been changed of the node.
...
Fixes #5053
2020-04-23 11:11:15 +05:30
Khushboo Vashi
6e5dbf7beb
Added multiple drop/delete functionality for the table constraints. Fixes #3900
2020-04-22 18:47:13 +05:30
Aditya Toshniwal
05abb9e430
Ensure that the query tool context menu should work on the collection nodes. Fixes #5415
2020-04-20 18:50:20 +05:30
Libor M
36a3d4e53b
Some more gettext() usage fixes:
...
- fixed `%` vs. `.format()`
- unified texts and usage `%s` vs. `{}`/`{0}`
- improved text sentences for translate
- added gettext for next texts
2020-04-20 11:19:09 +05:30
Pradip Parkale
a05acb4f99
Fixed tab key navigation for some dialogs. Fixes #5371
2020-04-14 13:32:03 +05:30
Nagesh Dhope
d9574f3caa
Fixes following OSX native keyboard shortcuts in Query Tool:
...
1) option+arrow (L/R) should skip by "word"
2) option+arrow (up/down) should go up/down one line
3) shift+option+arrow (L/R) should select/highlight by "word"
2020-04-10 15:21:56 +05:30
Libor M
6a9af07f7a
Fixed gettext usage:
...
- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in the dialog.
- improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
- added gettext for text translations.
2020-04-10 14:52:41 +05:30
Pradip Parkale
33deacacee
Ensure that the grant wizard should be closed on pressing the ESC key. Fixes #4206
2020-04-07 13:48:56 +05:30
Aditya Toshniwal
e1f990190e
Added search object functionality. Fixes #2172
2020-04-06 17:33:07 +05:30
Pradip Parkale
8ceeb39268
Fixed tab key navigation issue for parameters in table dialog. Fixes #5275
2020-04-06 13:13:21 +05:30
Vishal Sawale
99a72e529b
Fixed some accessibility issues:
...
1) Added missing search filter label in backgrid.
2) broken aria issue for objects menu.
2020-04-03 17:11:46 +05:30
Pradip Parkale
13b65c9a6a
Fixed tab key navigation issue for Grant Wizard. Fixes #5241
...
1) Added entry for .scss to change the shadow of 'ajs-close' button.
2) allow the user to use the keyboard to update the Backgrid cell DateTime picker control.
2020-03-30 17:31:50 +05:30
Libor M
94864104e4
Added and fixed gettext usage for better translation coverage. Fixes #5284
...
1) Fixed usage gettext('') instead of _('') in javascript files.
2) Fixed usage gettext('') instead of `${gettext('')}` in javascript files,
because "pybabel extract" not support extracting from this syntax.
2020-03-24 11:14:05 +05:30
Aditya Toshniwal
9bad590e9e
Improvements in the UI for both default and dark themes. Fixes #5133
...
Improve the style of the highlighted code after query execution for Dark mode. Fixes #4996 .
Changed background pattern for geometry viewer to use #fff for all themes. Fixes #5077
Changed the color of selected and hovered item for Select2 dropdown, also tweak the appearance of the tags in multi-select boxes. Fixes #4955
Fixed Firefox monospaced issue by updating the font to the latest version. Fixes #5184
2020-02-24 14:11:00 +05:30
Nagesh Dhope
b6173c9d7b
Added tab navigation on close buttons for all the panels and create/properties dialog.
...
Added tab navigation for scroll left and scroll right buttons on the main window.
Fixes #4601
2020-02-04 11:30:33 +05:30
Pradip Parkale
210bbfdbe1
1) Added labels and titles after parsing and validating all the pgAdmin4 web pages for accessibility. Fixes #4770
...
2) Fixed an issue where Save Password control disappears after clicking on it while creating a server. Fixes #5116
2020-01-31 14:21:35 +05:30
Aditya Toshniwal
0da23b837d
Set input controls as read-only instead of disabled will allow tab navigation in the properties tab and also allow screen readers to read it. Fixes #4993
2020-01-31 12:37:44 +05:30
Nagesh Dhope
f167d77b61
Allow screen-reader to read label & description of non-textable elements. Fixes #4762 .
...
Allow screen-reader to identify the alert errors. Fixes #4763
Added role alertdialog for confirm and alert dialog.
Added role status for all status bars/banners.
Added role alert for error bars.
Added aria-labelledby for charts on each dashboard.
Added tabindex for each chart so that it is navigable using tab key.
2020-01-28 11:32:11 +05:30
Aditya Toshniwal
fde8e4054a
Fixed an issue where Grant wizard unable to handle multiple objects when the query string parameter exceeds its limit. Fixes #4511
2020-01-20 17:53:21 +05:30
Akshay Joshi
b4b54d6b94
Fixed API test cases for missing language pack and jasmin test case.
2020-01-20 16:14:12 +05:30
Aditya Toshniwal
8c3bba65e5
Logout the pgAdmin session when no user activity of mouse move, click or keypress. Fixes #5000 .
...
Introduced two config params:
1. USER_INACTIVITY_TIMEOUT - Interval in seconds for the timeout. Default is 0-Zero which means disabled.
2. OVERRIDE_USER_INACTIVITY_TIMEOUT - If set to true, tools like query tool or debugger will override USER_INACTIVITY_TIMEOUT
and will not allow the application to timeout if a query is running for a long time.
2020-01-15 18:07:46 +05:30
Aditya Toshniwal
d4ee869281
Fixed broken tags and tokenizer options of select2. Regression of #5038
...
With the change of data adapter, we have configured adapters for tags and tokenizers.
We also renamed the method onDemandLoad to showOnScroll to avoid confusion.
2020-01-06 12:47:56 +05:30
Dave Page
01c7636c75
Update copyright notices for 2020.
2020-01-02 14:43:50 +00:00
Aditya Toshniwal
febbd729ec
Ensure that constraints, indexes, rules, triggers, and compound triggers should be created on partitions. Fixes #4842 .
2020-01-01 12:59:48 +05:30
Aditya Toshniwal
737f8375fb
Added support for on-demand loading of items in Select2. Fixes #5038 .
2020-01-01 11:24:16 +05:30
Nagesh Dhope
8c4dff057f
Added aria-label attribute wherever missing for accessibility.
2020-01-01 10:37:17 +05:30
Aditya Toshniwal
f1a18749f6
1) Allow screen-reader to read relationship attributes for tab, tabpanels and tables under it. Similar changes are done for subnode controls.
...
2) Add role="img" for font icons.
Fixes #4764
2019-12-17 13:22:36 +05:30
Aditya Toshniwal
11bf5fc679
Fix an issue where clicking on an empty textbox like fill factor or comments, considers it as change and enabled the save button. Fixes #4506 .
2019-12-11 14:35:14 +05:30
Aditya Toshniwal
6e2cf8ced2
Changed the open query tool and data filter icons. Fixes #4990 .
2019-12-06 19:27:55 +05:30
Aditya Toshniwal
0a67b2ecb9
Added aria-label to provide an invisible label where a visible label cannot be used. Fixes #4772 .
2019-12-03 12:47:42 +05:30
Khushboo Vashi
d476343b99
Enhance the logic to change the label from 'Delete/Drop' to 'Remove' for the server and server group node. Fixes #4923
2019-12-03 11:52:02 +05:30
Khushboo Vashi
cccc6e5676
Added role=status attribute to all the status messages for accessibility. Fixes #4773 .
2019-12-02 14:15:31 +05:30
Rahul Shirsat
d98e86d3df
Warn the user on changing the definition of Materialized View about the loss of data and its dependent objects. Fixes #4396
2019-12-02 11:25:51 +05:30
Fahar Abbas
623ff4f91f
Allow drag and drop functionality for all the nodes under the database node, excluding collection nodes. Fixes #4435
2019-12-02 09:35:20 +05:30
Aditya Toshniwal
3ff4dfd02d
Fix issue where the Reset button does not get enabled till all the mandatory fields are provided in the dialog. Fixes #3538
2019-11-15 11:51:06 +05:30