Commit Graph

475 Commits

Author SHA1 Message Date
Akshay Joshi
c8c5f83dfe Add support to save and clear SSH Tunnel password. Fixes #3511 2018-08-06 15:56:46 +05:30
Akshay Joshi
52fc0846cd pgAdmin4 should work with python 3.7, Fixes #3458 2018-08-06 15:35:03 +05:30
Akshay Joshi
8f45e6fe68 View Data->Filtered Rows dialog should be displayed. Fixes #3527 2018-08-02 18:15:58 +05:30
Aditya Toshniwal
f7e43d5e50 Realtime preference handling for the Dashboards and Debugger. Fixes #3294 2018-07-24 16:31:44 +01:00
Aditya Toshniwal
c353135a3a Add support for INCLUDE columns on indexes and index constraints with PG 11+. Fixes #3462 2018-07-19 13:13:37 +01:00
Akshay Joshi
1fc82d328c Fix backup in directory format on Windows. 2018-07-17 13:04:28 +01:00
Akshay Joshi
ba8f745f70 Exclude system columns in Import/Export. Fixes #3448 2018-07-17 13:01:40 +01:00
Khushboo Vashi
8869fd6eb3 Fix a number of debugger execution issues. Fixes #3191
1. EPAS packages' function/procedure does not honour INOUT arguments, it converts INOUT to OUT.

2.  Packages' functions and procedures are not getting listed in their respected nodes in some scenarios like procedure having INOUT argument and function with void return type

3. The Reverse engineering SQL is not correct for Packages' functions/procedures

4. In case of INOUT argument, debugger asks for mendatory input which should not.

5. Re-executing a procedure whilst direct debugging doesn't work.
2018-07-17 12:51:24 +01:00
Aditya Toshniwal
41a8333145 Replace deprecated success, error callbacks in $.ajax call with new functions .done and .fail. 2018-07-09 13:54:00 +01:00
Aditya Toshniwal
bdb7e3fde2 Infrastructure and changes to the Query Tool for realtime preference handling. Refs #3294
Highlights of this patch include:
- Changes will affect SQL Editors in Create dialog boxes, SQL tab of the main screen, Query tool, History entries in the query tool, Query tool opened in New Tab/Window
- All the components of SQL editor will refer to single source of preferences which is cached in the Browser object. All other redundant ajax get preference calls are removed.
- SQL editor will not refer template JS variables anymore, once all the references are removed the template variables will also be removed.
- Code refactoring wherever possible.
- Covered JS test cases wherever possible.
2018-07-05 11:38:43 +01:00
Khushboo Vashi
d56f1b17f3 Fix restoring of restore options for sections. Fixes #3362 2018-07-02 15:53:19 +01:00
Khushboo Vashi
28e0220e97 Fix restoring of restore options for sections. Fixes # 2018-07-02 15:52:15 +01:00
Murtuza Zabuawala
d53c47e1cf Cleanup and fix handling of Query Tool Cancel button status. Fixes #3319 2018-07-02 15:43:36 +01:00
Murtuza Zabuawala
b390c033cf Fix debugging of procedures in EPAS packages. Fixes #3457 2018-06-29 15:20:33 +01:00
Khushboo Vashi
fb1ef9ac0b Properly support backups in Directory format. Fixes #3309 2018-06-29 15:14:37 +01:00
Akshay Joshi
08e4cdf2ac Updated extension upgrade message. Fixes #3445 2018-06-26 11:53:46 +05:30
Dave Page
5bdd80e3da Correct version comparison, per Khushboo. 2018-06-25 16:41:34 +01:00
Akshay Joshi
cf29e8df90 Require v1.1 of the pldbgapi extension to debug on EPAS 11. 2018-06-25 16:01:53 +01:00
Akshay Joshi
4a71c6d7af Various EPAS/PG11 function & procedure fixes. Fixes #3421. Fixes #3422 2018-06-25 14:58:02 +01:00
Aditya Toshniwal
df85392bbf Fix handling of SQL_ASCII data in the query tool. Fixes #3289. Fixes #3250 2018-06-21 08:26:01 -04:00
Akshay Joshi
7a06acb678 Allow the connection timeout to be configured on a per-server basis. Fixes #3388 2018-06-19 19:58:46 -04:00
Khushboo Vashi
ba8829b64f Further Python 2.6 fixes. 2018-06-15 15:03:53 +01:00
Khushboo Vashi
d1902cd639 Add Python API tests for execution of external utilities such as pg_dump. 2018-06-15 11:36:07 +01:00
Akshay Joshi
b48145f01f Add an option to auto-complete keywords in upper case. Fixes #2686 2018-06-15 10:18:56 +01:00
Khushboo Vashi
d1ecba56b8 Function and procedure support for PG11. Fixes #3362 2018-06-13 15:03:17 +01:00
Akshay Joshi
419f9069ae Move the notifications tab between messages and history as it seems more natural there. 2018-06-06 09:23:33 +01:00
Joao De Almeida Pereira
7dd6372eeb Extract the tests and refactor some of the methods.
Extract some of the ACI Tree functionalities, and decouple it from the
main source. Also - create some abstractions from the repeated code
around the enable/disable the schema children object create/edit/delete
functionalities, and also created the dialog wrappers for backup and
restore dialogs.

Reviewed by: Khushboo and Ashesh
Refactored by: Ashesh
2018-06-05 16:42:59 +05:30
Aditya Toshniwal
920934759f Handle a potential error case in the connection status monitoring.
When you disconnect the server with an open sqleditor tab, exception
 occurs at the back end. Also, after connecting server, the sqleditor
 is not able to connect back because of the exception.
2018-06-05 11:57:56 +01:00
Akshay Joshi
38ee39ae7a Add support for LISTEN/NOTIFY in the query tool. Fixes #3204 2018-05-30 21:58:28 -04:00
Akshay Joshi
2b4605a9d3 Ensure backup/restore/maintenance work via SSH tunnels. Fixes #3355 2018-05-30 21:25:42 -04:00
Aditya Toshniwal
9f13865777 Update jQuery to 3.3.1. Fixes #3271
Patch by Aditya, with test enhancements from Anthony and Joao at Pivotal.
2018-05-25 16:26:37 +01:00
Aditya Toshniwal
6492dacbb2 Ensure the debugger container has focus when loaded. Fixes #3295 - this time on Firefox too! 2018-05-18 11:33:42 +01:00
Anthony Emengo
ab27b9d118 Fix template handling in tests for Windows. 2018-05-14 15:47:38 +01:00
Khushboo Vashi
ba23ba9b8b Ensure the debugger container has focus when loaded. Fixes #3295 2018-05-09 14:26:50 +01:00
Aditya Toshniwal
5b86a67a41 Fixed query tool keyboard issue where arrow keys were not behaving as expected for execute options dropdown. Fixes #3298 2018-05-09 13:05:22 +05:30
Khushboo Vashi
567f764234 Backup, Maintenance and Restore should not be started if database name contains "=" symbol. Fixes #1220 #1221 2018-05-07 15:09:12 +05:30
Akshay Joshi
b7fb01ab04 Add support for SSH tunneled connections. Fixes #1447 2018-05-04 11:27:27 +01:00
Ashesh Vashi
b653b742ed Close button added to the alertify message box, which pops up in case of backend error. Fixes #3290 2018-04-24 18:57:31 +05:30
Murtuza Zabuawala
c08adb5567 Catch errors when trying to EXPLAIN an invalid query. Fixes #3257 2018-04-12 10:50:57 +01:00
Murtuza Zabuawala
f5e474e4ec Ensure the query tool will open properly under MS Edge. 2018-04-10 11:09:59 +01:00
Murtuza Zabuawala
fa1854bd85 Allow sorting when viewing/editing data. Fixes #1894 2018-04-05 16:25:17 +01:00
Murtuza Zabuawala
a705fb46a8 Refactor and simplify query tool connection error handling code. Fixes #3235 2018-04-04 11:20:36 +01:00
Murtuza Zabuawala
be055ce57d Update Python and JS modules. Fixes #3154 2018-04-04 10:47:01 +01:00
Khushboo Vashi
7805170783 Add the ability to enable/disable UI animations. Fixes #1978 2018-04-03 14:52:13 +01:00
Joao Pedro De Almeida Pereira
94e1e46201 Show more granular timing info in the query tool history panel. Fixes #3244 2018-04-03 14:11:11 +01:00
Akshay Joshi
637f3b9d1a Fix a number of broken connection detection scenarios. 2018-03-21 08:38:18 +00:00
Murtuza Zabuawala
9ea118ca57 Ensure the file manager properly escapes file & directory names. Fixes #3196 2018-03-19 10:58:12 +00:00
Khushboo Vashi
63ba3402e8 Ensure SSL options are pushed down to external tools like pg_dump. Fixes #3122 2018-03-15 07:35:47 -04:00
Dave Page
3c686d3fbe PEP-8 fixes 2018-03-13 17:30:07 -04:00
Khushboo Vashi
802269910c Fix unicode handling in the external process tools and show the complete command in the process viewer. Fixes #2963. Fixes #3157. 2018-03-13 16:45:20 -04:00
Joao Pedro De Almeida Pereira
876ce1799a Skip tests where appropriate on GPDB. Fixes #3190
Victoria & Joao @ Pivotal.
2018-03-13 15:32:35 -04:00
Joao Pedro De Almeida Pereira
83477224cb Use test methods with @patch rather than directly. 2018-03-09 13:25:35 +00:00
Khushboo Vashi
7796a47b12 Fix test case for Python 2. 2018-03-08 10:21:24 +00:00
Khushboo Vashi
f86c313c18 More hardening of the query tool tests. 2018-03-08 09:12:48 +00:00
Khushboo Vashi
1136e37cf0 Make the poll query test a little more robust. 2018-03-07 16:48:32 +00:00
Khushboo Vashi
ae5c13188d Insert rows correctly when a table has OIDs and a Primary Key in uppercase. Fixes #3135 2018-03-07 16:06:23 +00:00
Khushboo Vashi
d3c303e455 Ensure all messages are retrieved from the server in the Query Tool. Fixes #3094 2018-03-07 13:38:27 +00:00
Joao Pedro De Almeida Pereira
427314cfdf Support for external tables in GPDB. Fixes #3168 2018-03-02 16:49:25 +00:00
Murtuza Zabuawala
92a0bb605d Ensure we can edit grid values in the debugger using keyboard shortcuts. Fixes #3153 2018-03-02 15:05:04 +00:00
Murtuza Zabuawala
efcf87636d Fix typo/thinko in access key definition. 2018-03-02 14:49:06 +00:00
Neethu Mariya Joy
0c48b79ce7 Allow copying of SQL from the dashboard tables. Fixes #3137 2018-03-02 14:39:12 +00:00
Neethu Mariya Joy
7471dea458 Allow text selection/copying from disabled CodeMirror instances. Fixes #2309 2018-03-02 13:46:06 +00:00
Murtuza Zabuawala
da7f088508 Handle opening of non-UTF8 compatible files. Fixes #3129 2018-03-02 13:36:50 +00:00
Murtuza Zabuawala
a9de043fef Add keyboard shortcuts for the Query Tool. Fixes #2900 2018-02-27 14:32:03 +00:00
Harshal Dhumal
aa1849c13a Support tab navigation in dialogs. Fixes #2898 2018-02-27 11:18:36 +00:00
Joao Pedro De Almeida Pereira
2332630af8 PEP8 fixes for the tools module. 2018-02-23 11:57:44 +00:00
Harshal Dhumal
c91a597df9 Fix alignment issues in keyboard shortcut options. Fixes #3080 2018-02-20 16:49:59 +00:00
Murtuza Zabuawala
96165044ae Ensure we can properly update rows with upper-case primary key columns. Fixes #3105 2018-02-19 11:37:31 +00:00
Murtuza Zabuawala
30868614ff Show button shortcut keys in the debugger on tooltips. 2018-02-19 11:05:34 +00:00
Joao Pedro De Almeida Pereira
9c382e4d23 Fix tests for Python 3.x 2018-02-09 14:39:39 +00:00
Murtuza Zabuawala
942ac733a4 Configurable shortcuts in the Debugger. Fixes #2901 2018-02-09 12:43:27 +00:00
Joao Pedro De Almeida Pereira
e16a952753 Support EXPLAIN on Greenplum. Fixes #3097
- Extract SQLEditor.execute and SQLEditor._poll into their own files and add test around them
 - Extract SQLEditor backend functions that start executing query to their own files and add tests around it
 - Move the Explain SQL from the front-end and now pass the Explain plan parameters as a JSON object in the start query call.
 - Extract the compile_template_name into a function that can be used by the different places that try to select the version of the template and the server type
2018-02-09 11:54:42 +00:00
Murtuza Zabuawala
25647c16ba Ensure we capture notices raised by queries. Fixes #3027 2018-02-02 15:23:33 +01:00
Harshal Dhumal
e0da9c5a0c Significantly improve connection loss detection and handling in the query tool. Fixes #2815 2018-02-01 14:29:18 +01:00
Murtuza Zabuawala
c6e405ce72 Prevent the filter dialog CodeMirror from overflowing onto the button bar of the dialog. Fixes #3067 2018-01-31 10:12:04 +00:00
Murtuza Zabuawala
bc836aa374 Ensure the user can use keyboard shortcuts after using button controls such as Cancel, Open and Save. Fixes #3054 2018-01-29 13:43:35 +00:00
Murtuza Zabuawala
393ce53d2d Fix PEP8 issues in the Tools module. Fixes #3063 2018-01-26 16:54:21 +00:00
Murtuza Zabuawala
abcb8c36a3 Fix connection status indicator on IE/FF. Fixes #3046 2018-01-25 13:30:13 +00:00
Murtuza Zabuawala
97760d65c2 Add keyboard navigation in Query tool module via Tab/Shift-Tab key. Fixes #2896
Note:
1) Once the keyboard shortcut infrastructure is ready we will add generic shortcut to focus out from CodeMirror editor and set foucs to next element, Right now there is no way of doing this, For testing purpose you can manually focus out from CodeMirror and click on data output panel to continue navigate using Tab key.
2) As of now inner panel's are not getting focused on Tab/Shift-Tab keys but once RM#2895 patch gets committed it will start working automatically as it's inherited code which will add tabindex tag automatically on each newly created wcDocker panel.
2018-01-25 12:27:13 +00:00
Murtuza Zabuawala
0e41b3364b Support keyboard navigation in the debugger. Fixes #2897
In passing, fix injection of variable values. Fixes #2981
2018-01-23 11:58:10 +00:00
Ashesh Vashi
404f1cc8ef Fixing the javascript file after running pga_eslint.js script 2018-01-17 13:24:25 +05:30
Murtuza Zabuawala
8520871bc6 Monitor connection and transaction status in the query tool. Fixes #2475 2018-01-12 14:34:39 +00:00
Ashesh Vashi
c32eb6bd37 Fixed the warnings/errors reported by eslint for all the static
javascripts.
2018-01-12 13:00:14 +05:30
Khushboo Vashi
def2df9028 Fix view data for views/mat views. Fixes #2993 2018-01-10 09:32:42 +00:00
Dave Page
89821c0d19 Update copyright notices for 2018. 2018-01-05 10:42:50 +00:00
Murtuza Zabuawala
36d779df5d Add tab indexes for debugger controls. 2017-12-18 09:23:11 +00:00
Harshal Dhumal
55254a649f Re-hash the way that we handle rendering of special types such as arrays. Fixes #2782. Fixes #2822. 2017-12-13 11:53:27 +00:00
Khushboo Vashi
0c5a5ba9c2 Add support for editing data in tables with OIDs but no primary keys. Fixes #2849.
This patch also updates the editor to retrieve all row values on save, thus immediately showing default values and allowing subsequent editing without a refresh.
2017-12-13 10:28:31 +00:00
Murtuza Zabuawala
136ed0d3e2 Fix debugging of self-referencing functions. Fixes #2524 2017-12-05 13:32:06 +09:00
Murtuza Zabuawala
bac9c77c4e Cleanup some inconsistent error dialog titles. Fixes #2098 2017-12-02 05:12:40 +00:00
Murtuza Zabuawala
389cf01af7 Cleanup the layout of the filter data dialogue. Fixes #2924 2017-11-30 10:53:48 +00:00
Akshay Joshi
ea82d92e41 Do not show success message, when there is an error saving the data in
the DataGrid.

Fixes #2907
2017-11-30 13:01:30 +05:30
Akshay Joshi
281b6c91b5 Using the correct type name (along with the internal name) while
generating the query for update/insert table data (Data grid).

Modified by Ashesh for array support.

Fixes #2830
2017-11-30 13:01:30 +05:30
Murtuza Zabuawala
f10733e8d4 Ensure the auto-complete selection list can display longer names. Fixes #2726 2017-11-29 11:14:24 +00:00
Khushboo Vashi
5bfa450a5f Allow form validation messages to be close in case the eclipse anything on the form. Fixes #2859 2017-11-28 14:10:12 +00:00
Murtuza Zabuawala
9ae4a03784 Allow changing of the users password without leaving the app. Fixes #2891 2017-11-28 10:55:54 +00:00
Harshal Dhumal
05a00f4ac8 Make the "Save Changes" prompts in the query tool optional. Fixes #2845 2017-11-23 09:20:59 +00:00
Murtuza Zabuawala
38f111d969 Ensure the scroll location is retains in the query tool data grid if the user changes tab and then returns. Fixes #2875 2017-11-23 09:07:46 +00:00
Murtuza Zabuawala
fdb4fa454a Honour whitespace properly in the data grid. Fixes #2880 2017-11-22 16:48:36 +00:00
Murtuza Zabuawala
1bc318f091 Ensure newly added rows cannot be editted until we have key values. Fixes #RM2886 2017-11-22 16:38:18 +00:00