Commit Graph

1219 Commits

Author SHA1 Message Date
Khushboo Vashi
ca8b5c68fd Remove Backgrid and Backform. Fixes #6134 2022-09-10 14:22:49 +05:30
Aditya Toshniwal
b128ba2f57 Fixed a couple of SonarQube issues. 2022-09-10 14:04:28 +05:30
Yogesh Mahajan
cbf5886430 Fixed the following code smells:
1. Use concise character class syntax
2. Add a "break" statement or remove this "else" clause.
3. Replace this generic exception class with a more specific one.
4. Use a regular expression literal instead of the 'RegExp' constructor.
5. Use the opposite operator ("not in") instead.
2022-09-10 13:48:14 +05:30
Nikhil Mohite
d967d5046d Fixed 'Remove the unused function parameter' code smell. 2022-09-09 18:36:51 +05:30
Akshay Joshi
3b95a416ca Fixed 'Remove the unnecessary boolean literals' code smell. 2022-09-09 15:23:18 +05:30
Akshay Joshi
b8f63adf41 Fixes following code smell reported by SonarQube:
1) Replace this if-then-else flow by a single return statement
 2) Remove the unnecessary boolean literals.
2022-09-08 19:56:02 +05:30
Akshay Joshi
7086719640 Fixed SonarQube issues. 2022-09-08 18:08:58 +05:30
Nikhil Mohite
0c9c57e608 1. Resolved resize window issue for DDL result panel.
2. Updated the Screenshots.
3. Updated server group title to bold.

refs #6133
2022-09-08 15:24:43 +05:30
Akshay Joshi
18b77f15dd Remove Alertify from pgAdmin completely. Fixes #7619 2022-09-08 15:16:48 +05:30
Nikhil Mohite
e1942d8c9e 1) Port schema diff to React. Fixes #6133
2) Remove SlickGrid.
2022-09-07 19:20:03 +05:30
Yogesh Mahajan
ad59380676 Fixed an issue with the non-visibility of columns added prior to import/export data. Fixes #7649 2022-09-07 17:40:52 +05:30
Aditya Toshniwal
0f46f070ed Port the remaining components of the ERD Tool to React. Fixes #7343
1. Make use of MUI styles and remove SCSS.
2. Use the new common components for buttons and tooltips, so that they are consistent.
3. UI design should be aligned with the query tool.
4. Remove tippyjs and Alertify dependencies.
2022-09-06 18:09:13 +05:30
Akshay Joshi
e58b9c767b Port search object dialog to React. Fixes #7622 2022-08-30 17:08:12 +05:30
Yogesh Mahajan
71a4b20d90 Fixed some SonarQube issues. 2022-08-30 14:21:33 +05:30
Akshay Joshi
fe0577be5f Ensure that the Import/Export server menu option is visible. Fixes #7646 2022-08-26 14:38:50 +05:30
Dave Page
a84118823e Title case tab label 2022-08-25 13:47:59 +01:00
Aditya Toshniwal
f2cc897f2f 1. Fixed an issue where copy and pasting a row in the results grid doesn't set the default for boolean. Fixes #7579
2. Fixed an issue where the History tab is getting blank and showing an error after some queries are executed. Fixes #7468
3. Fixed query tool view data crash.
2022-08-22 14:33:38 +05:30
Aditya Toshniwal
09e2c0eac0 1. Explain plan crashes query tool after SonarQube fixes.
2. Fix XSS issue in query tool.
3. Process details for cloud process not showing complete command.
4. Confirm dialog before removing processes.
2022-08-18 18:42:03 +05:30
Aditya Toshniwal
306b184e11 1. Fixed an issue where Alt-Shift-Q didn't work after creating a new query. Fixes #7575
2. Fixed an issue where the Query Editor loses focus when saving a query (Alt+s). Fixes #7521
3. Ensure that an error is thrown if clipboard access is not provided and change the copy rows shortcut. Fixes #7452
2022-08-17 17:23:44 +05:30
Akshay Joshi
da927f4897 1) Autocomplete on keypress should be set to False by default.
2) Update the documentation for the locked option in user management.
2022-08-17 14:38:37 +05:30
Akshay Joshi
f771d3a4bb Conditionally pin Flask version based on Python version. 2022-08-17 12:21:05 +05:30
Akshay Joshi
d4fdd4601e 1) Pin Flask version 2.1.*
2) Fixed API test cases that failed due to a change in the Werkzeug version.
3) Change password issue is fixed.
2022-08-17 11:54:16 +05:30
Akshay Joshi
ef91207669 1) Fixed an issue where an existing user is deleted and recreated again in the User Management dialog. Fixes #7618
2) Fixed preferences issue when changing themes.
3) Added validation for user names that already exist.
2022-08-16 17:28:45 +05:30
Khushboo Vashi
d45072fae5 Ensure that rename panel should work on view/edit panels. Fixes #7540 2022-08-16 15:31:55 +05:30
Akshay Joshi
485265979e Fixed an issue email already exists and disable the 'Locked' switch when its value is false. Fixes #7618 2022-08-16 15:25:25 +05:30
Akshay Joshi
2d27a97b8c Fixed improper parsing of HTTP requests in Pallets Werkzeug v2.1.0 and below (CVE-2022-29361). Fixes #7602 2022-08-16 12:20:01 +05:30
Akshay Joshi
06d454473c Fixed an issue where an invalid email error was not visible on the GUI. Fixes #7609 2022-08-14 08:48:58 +05:30
Akshay Joshi
1e94c3bd81 Fixed Security Hotspot reported by SonarQube. 2022-08-14 07:09:45 +05:30
Akshay Joshi
084203debc Fixed Securtiy Hotspot reported by SonarQube. 2022-08-12 17:10:26 +05:30
Nikhil Mohite
b34078c6d2 Fixed SonarQube issues 2022-08-12 12:19:11 +05:30
Aditya Toshniwal
c2b23465cc 1) Added support to show all background processes in separate panel. Fixes #3709
2) Port process watcher to React. Fixes #7404
2022-08-11 10:49:45 +05:30
Akshay Joshi
271b6d91fc Port User Management dialog to React. Fixes #7345 2022-08-11 10:25:52 +05:30
Aditya Toshniwal
8b7ce2c276 Port change user password and 2FA dialog to React. Fixes #7568 2022-08-10 18:02:54 +05:30
Nikhil Mohite
9c418188ee Fixed SonarQube issues. 2022-08-10 15:05:20 +05:30
Aditya Toshniwal
f5793e9a7a Fixed SonarQube issues. 2022-08-09 15:42:16 +05:30
Yogesh Mahajan
f96653e9af Fixed an issue with rendering geometry when selecting a complete column. Fixes #7586 2022-08-09 13:28:09 +05:30
Akshay Joshi
d1c94ac73d Fixed SonarQube issues. 2022-08-05 18:58:03 +05:30
Akshay Joshi
53887c32bf Port change ownership dialog to React. Fixes #7590 2022-08-05 14:11:17 +05:30
Akshay Joshi
95312f2d14 1) Ensure that autocomplete does not appear when navigating code using arrow keys. Fixes #7573
2) Fixed an issue where autocomplete is not working after clearing the query editor. Fixes #7563
2022-08-01 14:38:32 +05:30
Akshay Joshi
81b0d1138b Remove Alertify dialog from Grant Wizard, Import/Export Servers and Cloud. 2022-07-28 10:14:04 +05:30
Aditya Toshniwal
a7fd7d67b3 1. Intermittently failing test cases.
2. Dialog vertical position should be more on the upper side.
3. File not supported error is not showing.

refs #7313
2022-07-25 11:48:27 +05:30
Akshay Joshi
3e3f06c55d Fixed an issue where Autocomplete did not work after pressing CTRL/CMD + Space
for the second time and autocomplete on keypress is off. Fixes #7563
2022-07-22 18:49:46 +05:30
Yogesh Mahajan
3f8c36789f Fixed copy command error on Windows in Import/Export data.
refs #7428
2022-07-21 13:07:42 +05:30
Akshay Joshi
631a08189a 1) Improved autocomplete loading indicator.
2) Avoid too many ajax requests per key press.

refs #4488
2022-07-20 18:02:45 +05:30
Aditya Toshniwal
4808df5e95 1) Port the file/storage manager to React. Fixes #7313
2) Allow users to delete files/folders from the storage manager. Fixes #4607
3) Allow users to search within the file/storage manager. Fixes #7389
4) Fixed an issue where new folders cannot be created in the save dialog. Fixes #7524
2022-07-19 15:27:47 +05:30
Akshay Joshi
4585597388 Added option to trigger autocomplete on key press in the query tool. Fixes #4488 2022-07-19 11:55:37 +05:30
Yogesh Mahajan
8f73956d1e Fixed API test cases.
refs #7428
2022-07-18 18:15:46 +05:30
Yogesh Mahajan
8f2bda2309 1) Preserve the settings set by the user in the import/export data dialog. Fixes #7428
2) Fixed the JSON editor issue of hiding the first record. Fixes #7520
2022-07-18 10:54:03 +05:30
Aditya Toshniwal
9dde195af4 Ensure that notices should not disappear from the messages tab. Fixes #7512 2022-07-14 18:05:36 +05:30
Aditya Toshniwal
1fecf70123 Ensure that geometry should be shown for all the selected cells. Fixes #7519 2022-07-14 17:38:42 +05:30
Akshay Joshi
50c930f5fa Make the controls on the Graph Visualiser collapsible and reorganize the controls. 2022-07-07 14:10:10 +05:30
Akshay Joshi
9cdcad7a88 1) Keep the selected columns for the X and Y-axis.
2) Lighten the color of the stacked line chart.
2022-07-06 18:58:15 +05:30
Akshay Joshi
7414394ceb Fixed the following issues in the Graph Visualiser:
1) Change all theme's color codes.
 2) Bar graph for the first and last labels on the X-axis does not display all the bars.
 3) Make the graphs always start from zero on the Y-axis.
2022-07-05 18:44:20 +05:30
Akshay Joshi
8b62cd1f04 Added support for visualise the graph using a Pie chart in the query tool. Fixes #7487 2022-07-05 10:47:17 +05:30
Aditya Toshniwal
239e3bb6f1 Some more theme related fixes. 2022-07-04 14:26:33 +05:30
Aditya Toshniwal
9c45a62b53 Fixed jasmine test cases introduced by the theme patch. 2022-07-01 15:01:51 +05:30
Nikhil Mohite
9c745db413 Enable the start debugging button once execution is completed. Fixes #7517 2022-07-01 12:41:06 +05:30
Aditya Toshniwal
86b30b3c83 Theme component usage has been fixed, a component should never be wrapped in multiple Theme components. 2022-06-30 15:18:20 +05:30
Akshay Joshi
b92e2fcfc9 Added support for visualizing the graphs using Stacked Line, Bar, and Stacked Bar charts in the query tool. Fixes #7486 2022-06-30 12:38:48 +05:30
Aditya Toshniwal
cb635f6706 Removing dynamic module loading and replacing it with static loading. Fixes #7492
Gets rid of all occurrences and usage of get_own_javascripts since it is no longer used.
2022-06-30 11:06:50 +05:30
Aditya Toshniwal
524626b895 Ensure that the file name should be reflected on the query tool for the new tab title. 2022-06-28 18:21:08 +05:30
Yogesh Mahajan
d4657dcd32 Fixed module import issue.
refs #7506
2022-06-28 11:28:55 +05:30
Akshay Joshi
f905dc07cf Reset the zoom to original when chart object is created. Fixed an error on Windows. 2022-06-28 10:25:38 +05:30
Nikhil Mohite
35fb3bb38f Fixed the typo in the layout id for the Debugger.
refs #6132
2022-06-27 16:34:04 +05:30
Pradip Parkale
e95eb14651 Fixed an issue where the connection wasn't being closed when the user switched
to a new connection and closed the query tool. Fixes #7461

Fixed the 'Show activity?' issue which was missed during Dashboard porting.
2022-06-23 18:15:16 +05:30
Akshay Joshi
2556771c32 The following issues were fixed in Graph Visualiser:
1) Allow the user to set the row limit and chart line width.
2) Zoom should only be applied to X-axis, not both.
3) On clicking the 'Generate' button, the chart should return to its original zoom level.
4) Negative values are not displayed.

refs #7485
2022-06-23 14:52:11 +05:30
Akshay Joshi
93bc1f3c57 Added support for visualise the graph using a Line chart in the query tool. Fixes #7485 2022-06-22 17:18:51 +05:30
Nikhil Mohite
41ceda01d0 Fixed an issue where Debugger is not getting started if arguments loaded from SQLite database. Fixes #6132 2022-06-22 11:16:50 +05:30
Nikhil Mohite
4e3783c544 Fixed the following issues in the debugger:
1. If debugger arguments are array debugger sets the null value to parameters.
 2. Popup screen is not being closed if debug Package procedure/Function and select Null option.
 3. Updated validation for debugger argument of the array type parameter.

refs #6132
2022-06-20 19:05:26 +05:30
Nikhil Mohite
2adca6bbc4 1) Added mouse over indication for breakpoint area in the Debugger. Fixes #2647
2) Added search text option to the Debugger panel. Fixes #2648
3) Port Debugger to React. Fixes #6132
2022-06-15 11:37:54 +05:30
Aditya Toshniwal
5c1493bd7e Fixed an issue where there is no setting to turn off notifications in the Query Tool. Fixes #7423 2022-06-13 14:32:07 +05:30
Aditya Toshniwal
725726f083 Ensure that the Query Editor should be focused when switching between query tool tabs. Fixes #7441 2022-06-13 14:26:01 +05:30
Aditya Toshniwal
f615ef30f9 Skip the history records if the JSON info can't be parsed instead of showing 'No history'. Fixes #7468 2022-06-13 11:43:26 +05:30
Aditya Toshniwal
4c50940634 Fixed some issues related to the dropdown background color. Fixes #7374 2022-05-30 17:05:48 +05:30
Aditya Toshniwal
b507eb8857 Fixed an issue when switching between connections in the Query Tool dropdown,
the background and foreground colors should be changed. Fixes #7374
2022-05-26 15:31:18 +05:30
Aditya Toshniwal
aaab5c51a7 Fixed an issue where the data grid scroll is not reset when a query is executed. 2022-05-25 17:53:52 +05:30
Aditya Toshniwal
1e1e1f027a Fixed an issue where geometry is not visible when a single cell is selected. Fixes #7394 2022-05-24 17:08:02 +05:30
Aditya Toshniwal
c5ca45c461 Ensure that null values are accepted for the numeric columns in react-data-grid. Fixes #7405 2022-05-24 15:02:06 +05:30
Aditya Toshniwal
04fa7dee68 Added missing toggle case keyboard shortcuts to the query tool. Fixes #7399 2022-05-24 14:54:43 +05:30
Akshay Joshi
efe613d13e Fixed an issue where comments on domain constraints were not visible when selecting a domain node. Fixes #7403 2022-05-24 14:50:33 +05:30
Aditya Toshniwal
6d26d5833f Added support for multi-cell selection in the query tool grid. Fixes #7380 2022-05-24 11:39:34 +05:30
Akshay Joshi
4f7bcc2919 Added the ability to detect and warn users about bidirectional Unicode characters. Fixes #7002 2022-05-23 16:04:21 +05:30
Aditya Toshniwal
5e0dfff42a Ensure that the editor position should not get changed once it is opened. Fixes #7393 2022-05-18 13:52:09 +05:30
Akshay Joshi
b36004b702 The following are the initial fixes for PG15:
1) From PG 15 onward, the datlastsysoid has been removed from the table pg_database.
    We have added the constant _DATABASE_LAST_SYSTEM_OID = 16383, all the objects below
    this value are considered to be system objects. Modified the pgAdmin logic accordingly.

 2) Concatenation operator '||' needs a specific typecast to be applied to query variables. Modified SQL's accordingly.

Fixes #7283
2022-05-17 20:32:17 +05:30
Aditya Toshniwal
2d8aff6ca0 Fixed an issue with geometry window zoom mouse scroll not working. Fixes #7373 2022-05-17 18:58:49 +05:30
Aditya Toshniwal
fbe7b56054 Fixed an issue where a popup for unsaved changes appears when clicking on the
open file button for a blank query editor. Fixes #7376
2022-05-17 18:56:15 +05:30
Aditya Toshniwal
cb05d2924f Fixed an issue where an error message fills the entire window if the query is long. Fixes #7388 2022-05-17 18:52:19 +05:30
Akshay Joshi
44f9ba4a57 Port connect server password dialog to React. Fixes #7337 2022-05-16 16:21:14 +05:30
Aditya Toshniwal
ca8e14455f Fixed the following issues:
1. Feature test cases for the new query tool.
 2. Query tool panel rename is not persisting.
2022-05-12 18:29:09 +05:30
Aditya Toshniwal
1135821870 Fix Query tool issues:
1. Warning/Confirm dialogs should be inside the query tool.
2. The Help button in View/Edit data should open the corresponding help page.
3. Disable execute options when query tool in transaction.
4. Grid not loading more than 10000 rows. react-data-grid issue, PR sent. Use a fork till then.
5. NOTICE messages should not be part of Notifier success popups.

Fixes #7350
2022-05-09 12:39:29 +05:30
Nikhil Mohite
5ebc9d7d2e Ensure the Copy button is enabled when columns or rows are selected in the query tool results. 2022-05-05 09:52:14 +01:00
Aditya Toshniwal
64ffed0ddb 1. Filter dialog doesn't work in edit mode (getting back end errors), reverting it back to create mode of SchemaView.
2. Enable the copy button when a cell is selected.
3. Exclude, Include related fixes.
2022-04-29 16:29:46 +05:30
Akshay Joshi
c56fe813a5 Use gettext to wrap some strings. 2022-04-29 16:18:28 +05:30
Akshay Joshi
7b66777600 Fixed an issue where Import/Export Servers did not work in languages other than English. 2022-04-29 12:00:52 +05:30
Aditya Toshniwal
38f642d361 Ensure that the "Save results" button should be disabled when there are no rows.
refs #6131
2022-04-28 18:01:54 +05:30
Akshay Joshi
6e2ee9a21f Port data filter dialog to React. Fixes #7340 2022-04-28 12:04:56 +05:30
Akshay Joshi
1bee39a67e Fixed ERDInitialize API test case. 2022-04-26 18:23:24 +05:30
Aditya Toshniwal
0795b22ae6 Fixed the following issues for the new query tool:
1) In Dark mode > Replace/Find dialogue forward & reverse buttons are stuck to each other.
 2) In Dark/High contrast mode > Checkbox is not visible for false value.
 3) Wrap toolbar when size goes very small.
 4) Replace functionality does not work when tried in sequence 2 times. Codemirror search is not cyclic. So, changes are made to always search from the start.
 5) Replace all does not work when tried in sequence 2 times. Same reason as above.
 6) Fix broken macros $SELECTION$ feature.
 7) Make query history SQL readonly.
 8) The Filter dialog save button should be disabled when opened.
2022-04-26 16:27:53 +05:30
Aditya Toshniwal
3d1a9624c1 Fixed an issue where the drag and drop table in ERD throws an error. Fixes #7333 2022-04-26 16:25:42 +05:30
Akshay Joshi
4f9eaf850d Updated documentation for the new query tool.
refs #6131
2022-04-26 16:18:28 +05:30