Pradip Parkale
b562ab7681
Added shared server support for admin users. Fixes #4979
2020-09-03 12:59:28 +05:30
Yogesh Mahajan
3e35dc95e5
Improve code coverage and API test cases for Tables. Fixes #5774 .
2020-09-03 12:35:56 +05:30
Aditya Toshniwal
8f3bdf1cf3
Fixed cognitive complexity issues reported by SonarQube.
2020-09-02 14:39:54 +05:30
Cyril Jouve
5a253f9053
Change the following to replace Python 2 code with Python 3:
...
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.
2020-08-31 16:45:31 +05:30
Aditya Toshniwal
11d5613866
Fixed RESQL test cases for Roles module.
2020-08-28 18:22:25 +05:30
Yogesh Mahajan
3984544bdb
Fixed code smell 'String literals should not be duplicated'.
2020-08-28 18:17:27 +05:30
Yogesh Mahajan
e226b2fa75
Adjusted the height of jobstep code block to use maximum space. Fixes #5426 .
2020-08-28 14:00:49 +05:30
Aditya Toshniwal
28b637c99c
Fixed RE-SQL test cases failed due to the previous commit.
...
Introduces a new key - replace_regex_pattern to synchronize the
expected SQL with the backend SQL based on the regex string
2020-08-27 19:08:00 +05:30
Aditya Toshniwal
53a5410337
Fixed cognitive complexity issues and added some more RESQL test cases for roles module.
2020-08-27 13:09:22 +05:30
Yogesh Mahajan
f3bde7b5f1
Ensure that schema names starting with 'pg' should be visible in browser tree when standard_conforming_strings is set to off. Fixes #4216
2020-08-26 18:16:16 +05:30
Yogesh Mahajan
8fcf527632
Improve code coverage and API test cases for Columns and Constraints (Index, Foreign Key, Check, Exclusion). Fixes #5332
2020-08-26 12:35:22 +05:30
Dave Page
4eb17afe4e
Warn the user when connecting to a server that is older than pgAdmin supports. Fixes #5772
2020-08-25 17:18:43 +01:00
Nikhil Mohite
d2577e32e6
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 18:13:01 +05:30
Akshay Joshi
e2ac6187dc
Fixed Jenkins build failure due to API test case failed.
2020-08-25 14:14:48 +05:30
Akshay Joshi
df9aaf19c2
Fixed string indices must be integers issue for PostgreSQL < 9.3. Fixes #5766
2020-08-25 13:38:24 +05:30
Aditya Toshniwal
275c671576
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 12:39:14 +05:30
Pradip Parkale
86bbc3a9e8
Ensure that the user should be able to drop the database even if it is connected. Fixes #5722
2020-08-25 12:37:50 +05:30
Nikhil Mohite
b3d49c61a5
Fixed incorrect reverse engineering SQL for Foreign key when creating a table. Fixes #5748
2020-08-25 12:31:58 +05:30
Pradip Parkale
7f947f146c
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 12:28:55 +05:30
Akshay Joshi
52d0241a17
Fixed an issue where schema diff is not working when providing the options to Foreign Data Wrapper, Foreign Server, and User Mapping. Fixes #5754
2020-08-24 12:11:09 +05:30
Neel Patel
b53de0c31d
Updated some more font awesome icons for v5
2020-08-21 14:15:18 +05:30
Nikhil Mohite
19491d79a5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-21 13:52:05 +05:30
Akshay Joshi
fbbbc36221
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 20:26:51 +05:30
Rahul Shirsat
7f3e8596e3
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 18:34:49 +05:30
Akshay Joshi
103b08c9c5
Define constants for preferences label to fix SonarQube issues.
2020-08-20 17:58:37 +05:30
Khushboo Vashi
cc5a7ea334
Fixed code smell 'String literals should not be duplicated'.
...
Create a constant.py file which contains the common Constants.
2020-08-19 14:16:02 +05:30
Nikhil Mohite
4b56962c1b
Fixed cognitive complexity issues reported by SonarQube.
2020-08-19 13:41:53 +05:30
Akshay Joshi
63df19ee1c
Fixed following schema diff issues:
...
1) Avoid template databases from the Database drop-down list.
2) Exclude system schemas while comparing two databases.
3) Escape group name for XSS.
2020-08-13 14:12:37 +05:30
Nikhil Mohite
93adf6884f
Upgrade font awesome from v4 to v5. Fixes #5731
2020-08-13 12:04:00 +05:30
Cyril Jouve
36574b25b6
The 'str' object never has attribute decode in Python3, so remove the dead code.
2020-08-12 18:55:35 +05:30
Aditya Toshniwal
7dd313f5fc
Fixed an issue where debugger doesn't work if the search path is set other than 'public'. Fixes #4123
2020-08-12 14:24:40 +05:30
Aditya Toshniwal
8129df42da
Fixed cognitive complexity issues reported by SonarQube.
2020-08-11 15:13:35 +05:30
Akshay Joshi
082b968bbc
Fixed following schema diff issues:
...
1) Wrong SQL generated for the columns having different data type.
2) Added 'castfunc' in the ignore list.
2020-08-11 14:42:32 +05:30
Rahul Shirsat
2907a79dd7
Added missing comments in reverse engineering SQL for each column of a View. Fixes #3791
2020-08-11 11:30:47 +05:30
Akshay Joshi
46af290b85
Fixed API test cases for packages.
2020-08-10 18:13:00 +05:30
Nikhil Mohite
9d006d0ec5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-10 16:30:07 +05:30
Cyril Jouve
7a0bfecfc5
Use Python3 'ipaddress' module to validate the IPv4 and IPv6 addresses.
2020-08-10 15:57:25 +05:30
Rahul Shirsat
604937cf66
Fixed an issue where 'ALTER VIEW' statement is missing when the user sets the default value of a column for View. Fixes #5664
2020-08-10 15:27:57 +05:30
Akshay Joshi
4f74609ecf
Modified schema diff tool to compare two databases instead of two schemas. Fixes #5126
2020-08-10 15:13:34 +05:30
Nikhil Mohite
9ad7476a34
Corrected DROP SQL syntax for catalog. Fixes #5713
2020-08-07 16:58:38 +05:30
Akshay Joshi
518b13c779
Added the 'ORDER BY' clause for the privileges type to fix schema diff issue. Fixes #5689
2020-08-07 16:30:03 +05:30
Aditya Toshniwal
d6400bbcae
Replace the generic exception class with a more specific one.
2020-08-07 12:37:00 +05:30
Nikhil Mohite
1122e06f48
Fixed cognitive complexity issues reported by SonarQube.
2020-08-06 12:38:35 +05:30
Nikhil Mohite
6a406f466d
Fixed cognitive complexity issues reported by SonarQube.
2020-08-05 13:00:44 +05:30
Aditya Toshniwal
aa679e06b2
Replace the generic exception class with a more specific one to fix SonarQube issues.
2020-08-05 12:41:28 +05:30
Akshay Joshi
5ce2773658
Ensure that the Dictionaries drop-down shows all the dictionaries in the FTS configuration dialog. Fixes #5429
2020-08-04 15:48:20 +05:30
Akshay Joshi
87d08de3a0
Corrected the syntax as per jinja standards. refs #5632
2020-08-03 13:08:29 +05:30
Aditya Toshniwal
536593bf8a
Fixed following SonarQube issues:
...
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
2020-08-03 12:59:51 +05:30
Satish V
318d712c4f
Improve code coverage and API test cases for Schemas. Fixes #5327
2020-08-03 12:38:38 +05:30
Aditya Toshniwal
56cf64ad22
Fixed following SonarQube issues:
...
- Refactor functions to not always return the same value.
- Rename "cls" to "self" or add the missing "self" parameter.
- Remove useless assignment to variables.
2020-07-30 14:04:22 +05:30
