Akshay Joshi
b91f6f0f5c
Fixed an issue where the semicolon is misplaced in RLS Policy SQL.
...
Fixed one regression issue introduced by renaming the method 'gc' to 'gc_timeout'.
2020-06-26 19:24:54 +05:30
Nikhil Mohite
115657a465
Fixed following SonarQube issues:
...
1) Refactor function to reduce its Cognitive Complexity.
2) Rename variable to match the regular expression ^[_a-z][a-z0-9_]*$.
2020-06-26 15:03:50 +05:30
Satish V
8e28e0a32b
Improve code coverage and API test cases for Domain and Domain Constraints. Fixes #5326
2020-06-26 14:15:09 +05:30
Satish V
830ac1cc91
Fixed following SonarQube issues:
...
1. Method/Field names should comply with a naming convention.
2. Conditionals should start on new lines
2020-06-26 13:32:45 +05:30
Pradip Parkale
5206dafb35
Fixed code smells having rule 'Rename class name to match the regular expression'.
2020-06-26 13:23:23 +05:30
Khushboo Vashi
c7a16a4bd5
Fixed code smells having rule 'Nested blocks of code should not be left empty'.
2020-06-26 13:18:27 +05:30
Yogesh Mahajan
707ff450b5
Fixed following SonarQube issues:
...
1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation,
6. A while loop should be used instead of a 'for' loop.
2020-06-26 13:12:07 +05:30
Diego Augusto Molina
6a63279396
Ensure that the OWNER should be quoted for foreign tables, procedures, and trigger functions.
2020-06-26 12:28:36 +05:30
Aditya Toshniwal
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
Satish V
a1fd9ea3ce
Fixed issue related to extra semicolons and function naming convention reported by SonarQube.
2020-06-24 16:16:12 +05:30
Nikhil Mohite
db9d684524
Fixed 'Rename local variable to match the regular expression' issue reported by SonarQube.
2020-06-24 16:08:14 +05:30
Akshay Joshi
15c621b1d8
Fixed following SonarQube issues:
...
1) TypeError can be thrown as <variable_name> might be null or undefined here.
2) Unexpected duplicate "white-space".
3) Unexpected missing generic font family.
4) Unexpected shorthand "padding" after "padding-left".
2020-06-24 15:57:01 +05:30
Yogesh Mahajan
cdf1c7a2a6
Fixed parallel test execution failure by handling slowness when multiple sessions are logged in concurrently.
2020-06-23 18:43:54 +05:30
Akshay Joshi
d265ed9729
Fixed an issue while creating RLS Policy with the name having space. Fixes #5620
2020-06-23 14:28:21 +05:30
Murtuza Zabuawala
c064eb0795
Fix an issue where RLS Policy dialog help is not working.
2020-06-23 14:13:08 +05:30
Yogesh Mahajan
caebdcfa91
Ensure that the query tool should display the proper error message while terminating the active session. Fixes #3591
2020-06-22 17:09:10 +05:30
Pradip Parkale
6012f49919
Added policy event 'ALL' in events drop-down list.
2020-06-22 17:09:10 +05:30
Yogesh Mahajan
34fbe756e8
1) Fixes parallel test execution failures.
...
2) Added capability to pass browser-name via command line for parallel execution.
2020-06-22 13:05:13 +05:30
Satish V
daad16ea93
Fixed issue related to reducing the if-else statement to single return expression. Reported by SonarQube.
2020-06-22 12:58:48 +05:30
Aditya Toshniwal
6620f9263d
Fixed issues reported by SonarQube with tag 'bad-practice'.
2020-06-22 12:18:59 +05:30
Identifier Anonymous
9e40995ab0
Update Japanese translation.
2020-06-22 11:58:15 +05:30
Domenico Sgarbossa
ecdd95d15a
Update Italian translation.
2020-06-22 11:55:32 +05:30
Aditya Toshniwal
d6b22f1f4c
Fixed an issue where the search object is unable to locate inherited tables and constraint filters are not working. Fixes #5492
2020-06-22 11:53:00 +05:30
Akshay Joshi
7ce7808093
Update message catalogs.
2020-06-19 18:01:32 +05:30
Akshay Joshi
bc24e3643f
More code cleanup for SonarQube.
2020-06-18 16:20:34 +01:00
Yogesh Mahajan
6d3f13076f
Fixed 'Comma operator should not be used' issue reported by SonarQube.
2020-06-18 16:17:55 +05:30
Satish V
905be1d894
Replace if-then-else statement by a single return statement, issue reported by SonarQube.
2020-06-18 15:51:01 +05:30
Aditya Toshniwal
a278e8b1e6
Fixed the master password issue, introduced in the last commit.
2020-06-18 15:38:38 +05:30
Aditya Toshniwal
f0490a54b7
Fixed redundant tagged issue reported by SonarQube.
2020-06-18 11:14:56 +05:30
Akshay Joshi
5ed1e1e5b6
Fixed some sonarqube issues.
2020-06-17 19:30:56 +05:30
Aditya Toshniwal
df05efd7d9
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation.
2020-06-17 17:15:09 +05:30
Yogesh Mahajan
7c12ade161
Fixed issue related to shadowing variables reported by SonarQube.
2020-06-17 17:08:23 +05:30
Akshay Joshi
cb268075c2
1) Added option to ignore the whitespaces while comparing objects in schema diff. Fixes #5468
...
2) Added server group name while selecting servers in schema diff. Fixes #5500
3) Fixed an issue where two identical tables showing different by schema diff tool. Fixes #5584
2020-06-17 16:27:51 +05:30
Satish V
d43518cb3c
Fixed following issues reported by SonarQube:
...
1) Replace this if-then-else statement by a single return statement. (clumsy)
2) 'switch' statements should have at least 3 'case' clauses. (bad practice)
2020-06-16 15:00:51 +05:30
Aditya Toshniwal
3e00fe2b0f
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. Reported by SonarQube
2020-06-16 11:14:57 +05:30
Yogesh Mahajan
2ae5c0ec4f
Fixed an issue where select all checkbox only selects the first 50 tables. Fixes #4226
2020-06-16 11:05:10 +05:30
Yogesh Mahajan
697f4aec95
Fixed issue related to shadowing variables reported by SonarQube.
2020-06-16 10:47:40 +05:30
Nikhil Mohite
023a1f222f
Remove duplicate properties in CSS and few js standard fixes reported by SonarQube.
2020-06-15 17:15:15 +05:30
Akshay Joshi
a21e6448ce
Fixed RESQL test cases, regression of RLS policy.
2020-06-15 17:10:25 +05:30
Satish V
eb1b17b636
Fix 'expressions evaluated to true/false always' issue reported by SonarQube.
2020-06-15 16:50:07 +05:30
Mishika Singh
38cd3327f3
Ensure that pgadmin should be able to connect to the server which has password more than 1000 characters. Fixes #5592
2020-06-15 16:50:07 +05:30
Khushboo Vashi
8ab358ccec
Fix following issues reported by SonarQube:
...
1) Properties of variables with "null" or "undefined" values should not be accessed
2) Variables should not be self-assigned
3) "in" should not be used with primitive types
2020-06-15 16:50:07 +05:30
Aditya Toshniwal
641f7bbe9d
Some clumsy coding related fixes reported by SonarQube.
2020-06-15 16:50:07 +05:30
Pradip Parkale
18277543b6
Added support of Row Security Policies. Fixes #5516
2020-06-15 15:44:59 +05:30
Aditya Toshniwal
8c20f0c0d2
Some clumsy coding related fixes reported by SonarQube.
2020-06-12 15:24:17 +05:30
Satish V
ee1ea47e88
Fixed issue 'expects 4 arguments, but 5 were provided' reported by SonarQube.
2020-06-12 15:15:07 +05:30
Satish V
82c4a4a03e
Improve code coverage and API test cases for Collations. Fixes #5325
2020-06-11 11:12:41 +05:30
Dave Page
21efe6f902
Remove blank line at EOF.
2020-06-10 17:03:08 +01:00
Dave Page
5c60dcd501
Remove blank line at EOF.
2020-06-10 17:02:39 +01:00
Dave Page
85e89c869a
Cleanup some code smells identified by SonarQube.
2020-06-10 16:42:59 +01:00
