Yogesh Mahajan
80ab596992
Fixed the SoanrQube code smell 'Variables should not be shadowed'.
2020-07-03 14:33:30 +05:30
Khushboo Vashi
b5f0190799
Fixed the SonarQube Code smells having Rule 'Functions, methods and lambdas should not have too many parameters'.
2020-07-03 14:24:54 +05:30
Aditya Toshniwal
3d5a2046c4
Fixed jasmin test cases failed due to last commit.
2020-07-03 12:57:53 +05:30
Aditya Toshniwal
341c3aded6
Fixed dark theme-related CSS and modify the color codes. Fixes #5287
...
Fixed backgrid row hover issue where on hover background color is set for edit and delete cell only. Fixes #5470
2020-07-03 11:47:40 +05:30
Aditya Toshniwal
dd4dc19add
Fixed issue where dialog sizes snapping to the default widths.
2020-07-03 11:26:06 +05:30
Nikhil Mohite
1ab257d512
Fixed Cognitive Complexity code smell reproted by SonarQube.
2020-07-03 11:15:41 +05:30
Nikhil Mohite
2ec8051303
Remove the duplicate code for tab indent and add the logic into codemirror.
2020-07-03 10:47:39 +05:30
Akshay Joshi
ec30e6ace7
Comment out the 'yarn audit' command to fix the vulnerability found in the 'lodash' package. No fix is currently available.
2020-07-02 16:21:56 +05:30
Aditya Toshniwal
ced296939f
Fixed an issue where the user is able to edit properties when some of the collection nodes are selected. Fixes #5629
2020-07-02 16:21:56 +05:30
Yogesh Mahajan
1802f8a3f8
Ensure that the referenced table should be displayed on foreign key constraints. Fixes #5530
2020-07-02 16:21:56 +05:30
Pradip Parkale
8b10315e2a
Added hints for 'Using' and 'With check' options of RLS Policy node.
2020-07-02 16:21:56 +05:30
Dave Page
e0fa4a6cb2
Fix typo. Fixes #5517
2020-07-02 09:32:31 +01:00
Ashesh Vashi
1366dd1fcd
Show horizontal scrollbar when needed in the menubar in the lower
...
resolution, when navbar button is visible.
Added appropriate CSS in the .navbar-collapse class to show scrollbar
in screen resolution (992px widith)
2020-07-02 11:21:23 +05:30
Akshay Joshi
0850db2a9b
Fixed database connection issue, regression of SonarQube fixes.
2020-07-01 17:32:22 +05:30
Akshay Joshi
a881e4e3f8
Fix PEP8
2020-07-01 15:33:51 +05:30
Nikhil Mohite
192a446131
Fixed API test cases failing due to updating the server manager instance.
2020-07-01 15:29:59 +05:30
Pradip Parkale
b30c590866
Fixed SonarQube code smell 'Rename function and variable name to match the regular expression'.
2020-07-01 13:50:51 +05:30
Yogesh Mahajan
6dd3ca31be
Fixed SonarQube code smell 'Variables should not be shadowed'.
2020-07-01 13:43:00 +05:30
Nikhil Mohite
c2e875d54b
Fixed tab indent issue on a selection of lines is deleting the content when 'use spaces == true' in the preferences. Fixes #4235
2020-07-01 13:34:48 +05:30
Pradip Parkale
979f806161
1) Added RLS Policy support in Schema Diff. Fixes #5601
...
2) Fixed 'cant execute empty query' issue when remove the value of
'USING' or 'WITH CHECK' option of RLS Policy. Fixes #5631
2020-07-01 12:44:28 +05:30
Ashesh Vashi
3102a8d24b
Fix the dialog size when zoom level is changed of the browser.
...
The screen.width & screen.height does not reflect the values of the
height and width respectively when zoom level is changed for the
browser. It is better to review the calculated height and width based
on the window.innerHeight and window.innerWidth and re-evaluate them.
2020-07-01 11:49:43 +05:30
Ashesh Vashi
21d57b1f10
Do not let browser autocomplete the password field while connecting a
...
database server.
Set the autocomplete attribute of the password field to 'new-password'
to let browser know, we require a new password for the password, and do
not autocomplete it.
2020-07-01 11:26:52 +05:30
Nikhil Mohite
c873218c32
Added support for schema level restriction. Fixes #5583
...
Allow user to edit the connection properties when the database server
is already connected.
2020-06-30 19:15:23 +05:30
Satish V
4c05287677
Fixed SonarQube code smell 'Variables should not be shadowed'.
2020-06-30 17:26:18 +05:30
Nikhil Mohite
6713bc068b
Fixed SonarQube code smells 'Refactor this function to reduce its Cognitive Complexity'.
2020-06-30 17:06:55 +05:30
Akshay Joshi
46d26cd029
Remove extra brackets from reverse engineering SQL of RLS Policy. Fixes #5621
2020-06-30 16:11:02 +05:30
Zhang Jie
88db5ec4d5
Remove extra brackets from reverse engineering SQL of trigger.
2020-06-30 16:07:55 +05:30
Akshay Joshi
102d6e7a9a
Fixed an issue where panels get disappeared. Regression of SonarQube fix.
2020-06-29 14:05:07 +05:30
Rahul Shirsat
7add777b21
Add proper indentation to the code while generating functions, procedures, and trigger functions. Fixes #3851
2020-06-29 12:36:28 +05:30
Paresh More
2db518c9c6
Fixed an issue where installation of pgadmin4 not working on 32-bit Windows. Fixes #5630
2020-06-29 10:22:04 +05:30
Akshay Joshi
b91f6f0f5c
Fixed an issue where the semicolon is misplaced in RLS Policy SQL.
...
Fixed one regression issue introduced by renaming the method 'gc' to 'gc_timeout'.
2020-06-26 19:24:54 +05:30
Nikhil Mohite
115657a465
Fixed following SonarQube issues:
...
1) Refactor function to reduce its Cognitive Complexity.
2) Rename variable to match the regular expression ^[_a-z][a-z0-9_]*$.
2020-06-26 15:03:50 +05:30
Satish V
8e28e0a32b
Improve code coverage and API test cases for Domain and Domain Constraints. Fixes #5326
2020-06-26 14:15:09 +05:30
Satish V
830ac1cc91
Fixed following SonarQube issues:
...
1. Method/Field names should comply with a naming convention.
2. Conditionals should start on new lines
2020-06-26 13:32:45 +05:30
Pradip Parkale
5206dafb35
Fixed code smells having rule 'Rename class name to match the regular expression'.
2020-06-26 13:23:23 +05:30
Khushboo Vashi
c7a16a4bd5
Fixed code smells having rule 'Nested blocks of code should not be left empty'.
2020-06-26 13:18:27 +05:30
Yogesh Mahajan
707ff450b5
Fixed following SonarQube issues:
...
1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation,
6. A while loop should be used instead of a 'for' loop.
2020-06-26 13:12:07 +05:30
Diego Augusto Molina
6a63279396
Ensure that the OWNER should be quoted for foreign tables, procedures, and trigger functions.
2020-06-26 12:28:36 +05:30
Aditya Toshniwal
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
Satish V
a1fd9ea3ce
Fixed issue related to extra semicolons and function naming convention reported by SonarQube.
2020-06-24 16:16:12 +05:30
Nikhil Mohite
db9d684524
Fixed 'Rename local variable to match the regular expression' issue reported by SonarQube.
2020-06-24 16:08:14 +05:30
Akshay Joshi
15c621b1d8
Fixed following SonarQube issues:
...
1) TypeError can be thrown as <variable_name> might be null or undefined here.
2) Unexpected duplicate "white-space".
3) Unexpected missing generic font family.
4) Unexpected shorthand "padding" after "padding-left".
2020-06-24 15:57:01 +05:30
Yogesh Mahajan
cdf1c7a2a6
Fixed parallel test execution failure by handling slowness when multiple sessions are logged in concurrently.
2020-06-23 18:43:54 +05:30
Akshay Joshi
d265ed9729
Fixed an issue while creating RLS Policy with the name having space. Fixes #5620
2020-06-23 14:28:21 +05:30
Akshay Joshi
18b3cc2683
Initialize pointer variables with Q_NULLPTR.
2020-06-23 14:23:28 +05:30
Murtuza Zabuawala
c064eb0795
Fix an issue where RLS Policy dialog help is not working.
2020-06-23 14:13:08 +05:30
Akshay Joshi
c2268c82ee
Update version for release.
2020-06-22 17:42:46 +05:30
Yogesh Mahajan
caebdcfa91
Ensure that the query tool should display the proper error message while terminating the active session. Fixes #3591
2020-06-22 17:09:10 +05:30
Pradip Parkale
6012f49919
Added policy event 'ALL' in events drop-down list.
2020-06-22 17:09:10 +05:30
Yogesh Mahajan
d2f4a62bf3
Documentation of Row Level Security Policies. Fixes #5581
2020-06-22 17:09:10 +05:30