Khushboo Vashi
413709fc78
Simplify cookie domain/path settings, per discussion. Instead of trying to be smart, just let the user specify them in the config, e.g.
...
COOKIE_DEFAULT_DOMAIN = None
SESSION_COOKIE_DOMAIN = None
2018-03-23 10:14:02 +00:00
Khushboo Vashi
534f1f35fe
Appropriately set the cookie path. Fixes #3197
2018-03-19 17:09:19 +00:00
Murtuza Zabuawala
34f1ebc88e
Ensure the host parameter is correctly pickup up from the service file. Fixes #3200
2018-03-19 12:38:44 +00:00
Dave Page
93d44d5643
Revert "Ensure the cookie domain and path are properly set. Fixes #3197 "
...
This reverts commit 9c4edb4a28
.
Jenkins really doesn't like this.
2018-03-15 14:54:14 -04:00
Khushboo Vashi
9c4edb4a28
Ensure the cookie domain and path are properly set. Fixes #3197
2018-03-15 13:59:29 -04:00
Joao Pedro De Almeida Pereira
876ce1799a
Skip tests where appropriate on GPDB. Fixes #3190
...
Victoria & Joao @ Pivotal.
2018-03-13 15:32:35 -04:00
Victoria Henry
6b03cb78af
Refactor server dialogue validation for better unit testing.
...
Victoria & Joao @ Pivotal.
2018-03-13 14:47:32 -04:00
Dave Page
156b308fd3
Fix template paths for Windows. Fixes #3139
...
Joint work from Joao and Murtuza.
2018-03-13 12:45:14 -04:00
Murtuza Zabuawala
03b772bf64
Add support for connecting using pg_service.conf files. Fixes #3140
2018-03-12 16:45:56 -04:00
Murtuza Zabuawala
985a004766
Fix SQL generated when dropping NOT NULL from a "char" column. Fixes #2989
2018-03-09 15:23:49 +00:00
Joao Pedro De Almeida Pereira
3a6994f719
Final PEP-8 fixes
2018-03-08 09:33:43 +00:00
Murtuza Zabuawala
abf0b1a7ae
Allow admins to disable the use of Gravatar if they choose. Fixes #3037
2018-03-07 16:35:33 +00:00
Joao Pedro De Almeida Pereira
d1ab47c10c
Disable function statistics on Greenplum. Fixes #3176
2018-03-07 11:52:02 +00:00
Murtuza Zabuawala
06ff05762e
PEP8 fixes. Fixes #3175
2018-03-07 11:47:01 +00:00
Joao Pedro De Almeida Pereira
427314cfdf
Support for external tables in GPDB. Fixes #3168
2018-03-02 16:49:25 +00:00
Khushboo Vashi
905cdafe90
PEP8 changes for the FDW modules.
2018-03-02 14:46:13 +00:00
Murtuza Zabuawala
8964e511bf
PEP8 fixes for the Casts, Event triggers, Extensions and Languages modules. Fixes #3161
2018-03-02 11:59:11 +00:00
Harshal Dhumal
7cdb489a47
Fix handling of tie/datetime array types when adding columns to a table. Fixes #3079
2018-03-02 11:51:53 +00:00
Murtuza Zabuawala
78e2ff4f56
Ensure the pgAgent job start/end time grid fields synchronise with the subnode control and validate correctly. Fixes #3073
2018-03-02 11:11:26 +00:00
Murtuza Zabuawala
cca6504d54
PEP8 fixes. Fixes #3156
2018-02-27 15:38:50 +00:00
Murtuza Zabuawala
f5afd5fdb4
Fix block indent/outdent with configurable width. Fixes #3002
2018-02-27 15:20:30 +00:00
Harshal Dhumal
055f7abc9e
PEP8 fixes for the server and server group modules.
2018-02-27 11:22:14 +00:00
Harshal Dhumal
aa1849c13a
Support tab navigation in dialogs. Fixes #2898
2018-02-27 11:18:36 +00:00
Joao Pedro De Almeida Pereira
3be22383b8
Fix function reserve SQL for GPDB. Fixes #3150
2018-02-27 11:05:15 +00:00
Murtuza Zabuawala
6753cd7334
PEP8 fixes for the pgAgent and Tables nodes (and subnodes). Fixes #3148
2018-02-26 19:24:17 +00:00
Harshal Dhumal
43d3e0ca64
PEP8 fixes.
2018-02-26 15:58:48 +00:00
Joao Pedro De Almeida Pereira
5ebd9ee8d3
Fix table statistics for Greenplum. Fixes #3059
2018-02-26 09:38:00 +00:00
Murtuza Zabuawala
54dd6aae83
Add a test for sequence validation.
2018-02-23 12:02:57 +00:00
Murtuza Zabuawala
55875f0cfa
PEP8 cleanups for the sequences module.
2018-02-21 17:37:34 +00:00
Murtuza Zabuawala
51cc04b5b0
Fix tablespace tests for Python 3.x. Fixes #3138
2018-02-21 17:34:18 +00:00
Murtuza Zabuawala
f8771d5585
Fix validation of sequence parameters. Fixes #3014
2018-02-21 17:32:04 +00:00
Khushboo Vashi
b49d625c2d
Don't depend on standards_conforming_strings being enabled. Fixes #3077
2018-02-21 17:18:00 +00:00
Joao Pedro De Almeida Pereira
ba70634e5f
Hide tablespace node on GPDB. Fixes #3107
2018-02-20 17:40:56 +00:00
Harshal Dhumal
c91a597df9
Fix alignment issues in keyboard shortcut options. Fixes #3080
2018-02-20 16:49:59 +00:00
Khushboo Vashi
9a498c2877
Ensure column names on indexes on views are properly quoted in RE-SQL. Fixes #3066
2018-02-20 16:47:33 +00:00
Khushboo Vashi
c85e14dc25
Add missing reverse-engineered SQL header and drop statement for sequences. Fixes #3081
2018-02-19 11:41:19 +00:00
Joao Pedro De Almeida Pereira
15862e903a
Fix creation of tables and columns in GPDB. Fixes #3099
2018-02-19 10:40:10 +00:00
Khushboo Vashi
258b064963
Add configurable shortcut keys for various common options in the main window. Fixes #2899
2018-02-09 12:07:57 +00:00
Joao Pedro De Almeida Pereira
e16a952753
Support EXPLAIN on Greenplum. Fixes #3097
...
- Extract SQLEditor.execute and SQLEditor._poll into their own files and add test around them
- Extract SQLEditor backend functions that start executing query to their own files and add tests around it
- Move the Explain SQL from the front-end and now pass the Explain plan parameters as a JSON object in the start query call.
- Extract the compile_template_name into a function that can be used by the different places that try to select the version of the template and the server type
2018-02-09 11:54:42 +00:00
Navnath Gadakh
db92907fe9
Fix quoting of function names in RE-SQL. Fixes #3060
2018-02-09 10:15:41 +00:00
Dave Page
4d69764869
Don't quote variable values used by SET. It's usually going to be wrong. Fixes #3027
2018-02-02 14:58:29 +01:00
Khushboo Vashi
262d01bf01
Add keyboard navigation options for the main browser windows. Fixes #2895
2018-02-02 14:28:37 +01:00
Harshal Dhumal
2042f89ce0
Don't include sizes on primitive datatypes that shouldn't have them when modifying columns. Fixes #3052
2018-02-01 16:27:36 +01:00
Murtuza Zabuawala
6ad44cb51e
Fix on-click handling of treeview nodes that wasn't refreshing SQL/Dependencies/Dependents in some circumstances. Fixes #3058
2018-02-01 14:44:12 +01:00
Harshal Dhumal
e0da9c5a0c
Significantly improve connection loss detection and handling in the query tool. Fixes #2815
2018-02-01 14:29:18 +01:00
Joao Pedro De Almeida Pereira
de1c767e88
Update the regression tests to fix issues with Python 3.5 and PG 9.2. Fixes #3057
2018-01-26 16:45:09 +00:00
Joao Pedro De Almeida Pereira
7c985695b7
Correct display of RE-SQL for partitioned tables in Greenplum. Fixes #3050
2018-01-25 12:37:17 +00:00
Joao Pedro De Almeida Pereira
65337daeba
Display functions in Greenplum. Fixes #3044
2018-01-23 11:10:46 +00:00
Joao Pedro De Almeida Pereira
678699c408
Display partitions in Greenplum. Fixes #3036
2018-01-23 10:41:36 +00:00
Joao Pedro De Almeida Pereira
284adbbb90
Correctly display SQL of multiple objects on the SQL tab in GPDB.
2018-01-22 11:04:49 +00:00
Khushboo Vashi
ca80cfa04a
Ensure clickable images/buttons have appropriate tooltips for screen readers. Fixes #2904
2018-01-22 10:37:56 +00:00
Joao Pedro De Almeida Pereira
56e922f5ab
Support Properties on Greenplum databases. Fixes #3015
2018-01-15 14:44:40 +05:30
Murtuza Zabuawala
8520871bc6
Monitor connection and transaction status in the query tool. Fixes #2475
2018-01-12 14:34:39 +00:00
Joao Pedro De Almeida Pereira
ed3e374df6
Support server and database statistics on Greenplum. Fixes #3004
2018-01-12 10:02:46 +00:00
Ashesh Vashi
c32eb6bd37
Fixed the warnings/errors reported by eslint for all the static
...
javascripts.
2018-01-12 13:00:14 +05:30
Murtuza Zabuawala
aec86970f2
Add ALT tags to images for accessibility. Fixes #2902
2018-01-08 12:43:36 +00:00
Dave Page
89821c0d19
Update copyright notices for 2018.
2018-01-05 10:42:50 +00:00
Khushboo Vashi
711fbd5144
Allow use of transition tables in PG 10 triggers. Fixes #2933
2018-01-03 16:25:03 +00:00
Murtuza Zabuawala
0810c681c3
Ensure the switch animation is consistent on the table dialogue and avoid displaying an error incorrectly. Fixes #2624
2018-01-03 15:32:44 +00:00
Murtuza Zabuawala
e21f1e3291
Prevent multiple connections to new slow-to-respond servers being initiated in error. Fixes #2928
2018-01-03 14:49:08 +00:00
Khushboo Vashi
49dfd6fe31
Ensure invalid options can't be selected on triggers on views. Fixes #2945
2018-01-03 14:32:00 +00:00
Khushboo Vashi
e64bc2a821
Show complete SQL for FTS dictionaries. Fixes #2949
2018-01-03 13:16:11 +00:00
Khushboo Vashi
107795db10
Ensure column collation isn't lost when changing field size. Fixes #2779
2017-12-13 15:44:10 +00:00
Murtuza Zabuawala
c5d1fc8189
Ensure the datatype cache is updated when a domain is added. Fixes #2778
2017-12-13 15:17:17 +00:00
Dave Page
b2e844c0ad
Fix label inconsistency spotted by Susan.
2017-12-13 14:59:15 +00:00
Murtuza Zabuawala
4246a3b22f
Ensure password changes are successful if authenticating using a pgpass file. Fixes #2720
2017-12-13 13:28:07 +00:00
Khushboo Vashi
0c5a5ba9c2
Add support for editing data in tables with OIDs but no primary keys. Fixes #2849 .
...
This patch also updates the editor to retrieve all row values on save, thus immediately showing default values and allowing subsequent editing without a refresh.
2017-12-13 10:28:31 +00:00
Murtuza Zabuawala
f5718b9d56
Misc fixes for the pgAgent module:
...
1) User was allowed to enter start date ahead of end date while scheduling a job. Fixes #2921
2) Datetime picker was not displaying in the grid (sub-node collection control). Fixes #1749
3) Fixed UI issue where validation error was not displaying properly for Datetime control.
2017-12-06 12:25:45 +09:00
Harshal Dhumal
1a4e21e6dd
Fix regression tests for password reset in server mode
2017-11-30 13:16:59 +00:00
Harshal Dhumal
35a5cf22d5
Refuse password changes (and tell the user) if the notification email cannot be sent. Fixes #2892
2017-11-30 11:16:38 +00:00
Murtuza Zabuawala
2995d6e9c5
Fix the width of Role dialogue so tabs don't wrap.
2017-11-30 10:58:27 +00:00
Khushboo Vashi
5bfa450a5f
Allow form validation messages to be close in case the eclipse anything on the form. Fixes #2859
2017-11-28 14:10:12 +00:00
Murtuza Zabuawala
9ae4a03784
Allow changing of the users password without leaving the app. Fixes #2891
2017-11-28 10:55:54 +00:00
Navnath Gadakh
035c134fed
Cleanup properly after running the Foreign Table test cases.
2017-11-28 09:44:28 +00:00
Navnath Gadakh
80c4a3fb1a
Use sufficiently long random strings in test objects to avoid conflicts.
2017-11-27 12:01:50 +00:00
Murtuza Zabuawala
d614c88ada
Ensure we don't show the full path on the server when using virtual filesystem roots in server mode for SSL certs. Fixes #2866
2017-11-27 11:25:50 +00:00
Murtuza Zabuawala
b284572afe
Allow connections to be coloured in the treeview and query tool. Fixes #1383 . Fixes #2802
2017-11-21 16:28:01 +00:00
Murtuza Zabuawala
dd8e2fe8a6
Quote the owner name when creating types. Fixes #2787
2017-11-21 11:32:27 +00:00
Murtuza Zabuawala
5fd3a7dd3d
Display relevant error messages when access is denied creating a schema. Fixes #2094
2017-11-20 13:31:03 +00:00
Harshal Dhumal
051788d040
Fix a referenced before assignment bug in connection management. Fixes #2868
2017-11-16 12:40:00 +00:00
Khushboo Vashi
88cd68c2b9
Add an option to manually count rows in tables to render the properties. Fixes #2846
2017-11-07 20:27:10 -05:00
Alexander Lakhin
187ab22d90
Further missing translation fixes. Stats now:
...
1481 of 1831 messages (80%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1694 of 1831 messages (92%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1748 of 1831 messages (95%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1750 of 1831 messages (95%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1436 of 1831 messages (78%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
2017-11-06 19:49:20 -05:00
Chethana Kumar
2be418706d
Updated colours of tree view icons, which is to be more comfortable in identifying.
2017-11-06 13:03:03 +05:30
Alexander Lakhin
f15f46592a
Tag some translations that were not, well, tagged. Current stats:
...
1481 of 1777 messages (83%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1694 of 1777 messages (95%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1472 of 1777 messages (82%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1750 of 1777 messages (98%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1436 of 1777 messages (80%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
2017-11-05 08:32:26 -05:00
Dave Page
b2186db562
Revert "Fix a number of cases where strings were not properly marked for translation."
...
This reverts commit 1f23838a4c
due to unintended side
effects it caused - specifically, expanding Databases on the treeview displayed
Servers again
2017-11-03 16:45:20 +00:00
Alexander Lakhin
1f23838a4c
Fix a number of cases where strings were not properly marked for translation.
2017-11-03 13:10:42 +00:00
Khushboo Vashi
f73ce2dfc3
Ensure estimated rows are included correctly in CREATE script for functions. Fixes #2651
2017-11-02 09:47:31 +00:00
Murtuza Zabuawala
897bf4857a
Fix counted rows display in table properties. Fixes #2836
2017-11-02 09:35:44 +00:00
Alexander Lakhin
23d431fb54
Remove more exclamation marks from error messages.
2017-11-01 15:18:07 +00:00
Alexander Lakhin
9be1364d1a
Various string improvements and fixes.
2017-11-01 12:58:19 +00:00
Dave Page
890fece73a
Fix check constraint regression tests.
2017-10-16 16:01:07 +01:00
Murtuza Zabuawala
784f3f59d8
Fix name of 'check-constraints' to follow the usual singular convention.
2017-10-16 15:40:15 +01:00
Murtuza Zabuawala
0cb57848f8
Ensure auto-indent honours the spaces/tabs config setting. Fixes #2780
2017-10-16 15:37:03 +01:00
Neel Patel
56e1fd85f4
Ensure line numbers form CodeMirror don't appear on top of menus. Fixes #2738
2017-10-12 10:07:18 +01:00
Harshal Dhumal
04beec1309
Fix various issues that could cause an exception on startup. Fixes #2713
2017-10-10 09:50:47 +01:00
Murtuza Zabuawala
2f5a2b2392
Only allow specification of a pgpass file if libpq >= 10. Fixes #2768
2017-10-10 09:31:27 +01:00
Akshay Joshi
5a132a547f
Ensure using an alternate role to connect to a database doesn't cause an error when checking recovery state. Fixes #2742
2017-09-28 15:09:49 +01:00
Murtuza Zabuawala
f855ed88ce
Allow selection of SSL certificates and pgpass files in connection properties. Fixes #2649 . Fixes #2650
2017-09-28 10:02:33 +01:00
Chethana Kumar
62c9376546
Improve icon alignment.
2017-09-22 14:29:34 +01:00
Akshay Joshi
13665f68d8
Fix validation message styling on thegrant wizard. Fixes #2673
2017-09-20 11:34:01 +01:00