Akshay Joshi
419f9069ae
Move the notifications tab between messages and history as it seems more natural there.
2018-06-06 09:23:33 +01:00
Aditya Toshniwal
920934759f
Handle a potential error case in the connection status monitoring.
...
When you disconnect the server with an open sqleditor tab, exception
occurs at the back end. Also, after connecting server, the sqleditor
is not able to connect back because of the exception.
2018-06-05 11:57:56 +01:00
Akshay Joshi
38ee39ae7a
Add support for LISTEN/NOTIFY in the query tool. Fixes #3204
2018-05-30 21:58:28 -04:00
Anthony Emengo
ab27b9d118
Fix template handling in tests for Windows.
2018-05-14 15:47:38 +01:00
Akshay Joshi
b7fb01ab04
Add support for SSH tunneled connections. Fixes #1447
2018-05-04 11:27:27 +01:00
Ashesh Vashi
b653b742ed
Close button added to the alertify message box, which pops up in case of backend error. Fixes #3290
2018-04-24 18:57:31 +05:30
Murtuza Zabuawala
c08adb5567
Catch errors when trying to EXPLAIN an invalid query. Fixes #3257
2018-04-12 10:50:57 +01:00
Murtuza Zabuawala
f5e474e4ec
Ensure the query tool will open properly under MS Edge.
2018-04-10 11:09:59 +01:00
Murtuza Zabuawala
fa1854bd85
Allow sorting when viewing/editing data. Fixes #1894
2018-04-05 16:25:17 +01:00
Murtuza Zabuawala
a705fb46a8
Refactor and simplify query tool connection error handling code. Fixes #3235
2018-04-04 11:20:36 +01:00
Murtuza Zabuawala
be055ce57d
Update Python and JS modules. Fixes #3154
2018-04-04 10:47:01 +01:00
Khushboo Vashi
7805170783
Add the ability to enable/disable UI animations. Fixes #1978
2018-04-03 14:52:13 +01:00
Joao Pedro De Almeida Pereira
94e1e46201
Show more granular timing info in the query tool history panel. Fixes #3244
2018-04-03 14:11:11 +01:00
Akshay Joshi
637f3b9d1a
Fix a number of broken connection detection scenarios.
2018-03-21 08:38:18 +00:00
Murtuza Zabuawala
9ea118ca57
Ensure the file manager properly escapes file & directory names. Fixes #3196
2018-03-19 10:58:12 +00:00
Joao Pedro De Almeida Pereira
876ce1799a
Skip tests where appropriate on GPDB. Fixes #3190
...
Victoria & Joao @ Pivotal.
2018-03-13 15:32:35 -04:00
Joao Pedro De Almeida Pereira
83477224cb
Use test methods with @patch rather than directly.
2018-03-09 13:25:35 +00:00
Khushboo Vashi
7796a47b12
Fix test case for Python 2.
2018-03-08 10:21:24 +00:00
Khushboo Vashi
f86c313c18
More hardening of the query tool tests.
2018-03-08 09:12:48 +00:00
Khushboo Vashi
1136e37cf0
Make the poll query test a little more robust.
2018-03-07 16:48:32 +00:00
Khushboo Vashi
ae5c13188d
Insert rows correctly when a table has OIDs and a Primary Key in uppercase. Fixes #3135
2018-03-07 16:06:23 +00:00
Khushboo Vashi
d3c303e455
Ensure all messages are retrieved from the server in the Query Tool. Fixes #3094
2018-03-07 13:38:27 +00:00
Joao Pedro De Almeida Pereira
427314cfdf
Support for external tables in GPDB. Fixes #3168
2018-03-02 16:49:25 +00:00
Neethu Mariya Joy
0c48b79ce7
Allow copying of SQL from the dashboard tables. Fixes #3137
2018-03-02 14:39:12 +00:00
Neethu Mariya Joy
7471dea458
Allow text selection/copying from disabled CodeMirror instances. Fixes #2309
2018-03-02 13:46:06 +00:00
Murtuza Zabuawala
da7f088508
Handle opening of non-UTF8 compatible files. Fixes #3129
2018-03-02 13:36:50 +00:00
Murtuza Zabuawala
a9de043fef
Add keyboard shortcuts for the Query Tool. Fixes #2900
2018-02-27 14:32:03 +00:00
Joao Pedro De Almeida Pereira
2332630af8
PEP8 fixes for the tools module.
2018-02-23 11:57:44 +00:00
Murtuza Zabuawala
96165044ae
Ensure we can properly update rows with upper-case primary key columns. Fixes #3105
2018-02-19 11:37:31 +00:00
Joao Pedro De Almeida Pereira
9c382e4d23
Fix tests for Python 3.x
2018-02-09 14:39:39 +00:00
Joao Pedro De Almeida Pereira
e16a952753
Support EXPLAIN on Greenplum. Fixes #3097
...
- Extract SQLEditor.execute and SQLEditor._poll into their own files and add test around them
- Extract SQLEditor backend functions that start executing query to their own files and add tests around it
- Move the Explain SQL from the front-end and now pass the Explain plan parameters as a JSON object in the start query call.
- Extract the compile_template_name into a function that can be used by the different places that try to select the version of the template and the server type
2018-02-09 11:54:42 +00:00
Murtuza Zabuawala
25647c16ba
Ensure we capture notices raised by queries. Fixes #3027
2018-02-02 15:23:33 +01:00
Harshal Dhumal
e0da9c5a0c
Significantly improve connection loss detection and handling in the query tool. Fixes #2815
2018-02-01 14:29:18 +01:00
Murtuza Zabuawala
bc836aa374
Ensure the user can use keyboard shortcuts after using button controls such as Cancel, Open and Save. Fixes #3054
2018-01-29 13:43:35 +00:00
Murtuza Zabuawala
393ce53d2d
Fix PEP8 issues in the Tools module. Fixes #3063
2018-01-26 16:54:21 +00:00
Murtuza Zabuawala
abcb8c36a3
Fix connection status indicator on IE/FF. Fixes #3046
2018-01-25 13:30:13 +00:00
Murtuza Zabuawala
97760d65c2
Add keyboard navigation in Query tool module via Tab/Shift-Tab key. Fixes #2896
...
Note:
1) Once the keyboard shortcut infrastructure is ready we will add generic shortcut to focus out from CodeMirror editor and set foucs to next element, Right now there is no way of doing this, For testing purpose you can manually focus out from CodeMirror and click on data output panel to continue navigate using Tab key.
2) As of now inner panel's are not getting focused on Tab/Shift-Tab keys but once RM#2895 patch gets committed it will start working automatically as it's inherited code which will add tabindex tag automatically on each newly created wcDocker panel.
2018-01-25 12:27:13 +00:00
Ashesh Vashi
404f1cc8ef
Fixing the javascript file after running pga_eslint.js script
2018-01-17 13:24:25 +05:30
Murtuza Zabuawala
8520871bc6
Monitor connection and transaction status in the query tool. Fixes #2475
2018-01-12 14:34:39 +00:00
Ashesh Vashi
c32eb6bd37
Fixed the warnings/errors reported by eslint for all the static
...
javascripts.
2018-01-12 13:00:14 +05:30
Khushboo Vashi
def2df9028
Fix view data for views/mat views. Fixes #2993
2018-01-10 09:32:42 +00:00
Dave Page
89821c0d19
Update copyright notices for 2018.
2018-01-05 10:42:50 +00:00
Harshal Dhumal
55254a649f
Re-hash the way that we handle rendering of special types such as arrays. Fixes #2782 . Fixes #2822 .
2017-12-13 11:53:27 +00:00
Khushboo Vashi
0c5a5ba9c2
Add support for editing data in tables with OIDs but no primary keys. Fixes #2849 .
...
This patch also updates the editor to retrieve all row values on save, thus immediately showing default values and allowing subsequent editing without a refresh.
2017-12-13 10:28:31 +00:00
Akshay Joshi
ea82d92e41
Do not show success message, when there is an error saving the data in
...
the DataGrid.
Fixes #2907
2017-11-30 13:01:30 +05:30
Akshay Joshi
281b6c91b5
Using the correct type name (along with the internal name) while
...
generating the query for update/insert table data (Data grid).
Modified by Ashesh for array support.
Fixes #2830
2017-11-30 13:01:30 +05:30
Murtuza Zabuawala
f10733e8d4
Ensure the auto-complete selection list can display longer names. Fixes #2726
2017-11-29 11:14:24 +00:00
Harshal Dhumal
05a00f4ac8
Make the "Save Changes" prompts in the query tool optional. Fixes #2845
2017-11-23 09:20:59 +00:00
Murtuza Zabuawala
38f111d969
Ensure the scroll location is retains in the query tool data grid if the user changes tab and then returns. Fixes #2875
2017-11-23 09:07:46 +00:00
Murtuza Zabuawala
fdb4fa454a
Honour whitespace properly in the data grid. Fixes #2880
2017-11-22 16:48:36 +00:00
Murtuza Zabuawala
1bc318f091
Ensure newly added rows cannot be editted until we have key values. Fixes #RM2886
2017-11-22 16:38:18 +00:00
Murtuza Zabuawala
b284572afe
Allow connections to be coloured in the treeview and query tool. Fixes #1383 . Fixes #2802
2017-11-21 16:28:01 +00:00
Khushboo Vashi
0c566f132e
Allow configuration of CSV and clipboard formatting of query results. Fixes #2781
2017-11-20 13:50:47 +00:00
Murtuza Zabuawala
af2722faa3
Focus on the filter textarea when opening filter options in the query tool.
2017-11-16 11:01:40 +00:00
Alexander Lakhin
187ab22d90
Further missing translation fixes. Stats now:
...
1481 of 1831 messages (80%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1694 of 1831 messages (92%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1748 of 1831 messages (95%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1750 of 1831 messages (95%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1436 of 1831 messages (78%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
2017-11-06 19:49:20 -05:00
Alexander Lakhin
23d431fb54
Remove more exclamation marks from error messages.
2017-11-01 15:18:07 +00:00
Alexander Lakhin
9be1364d1a
Various string improvements and fixes.
2017-11-01 12:58:19 +00:00
Murtuza Zabuawala
0cb57848f8
Ensure auto-indent honours the spaces/tabs config setting. Fixes #2780
2017-10-16 15:37:03 +01:00
Dave Page
354679e69b
Fix an issue where we were executing SELECT statements in transactions in query tool which probably is not required because SELECT statements are already protected from dirty reads. Fixes #2683
2017-09-20 11:59:37 +01:00
Akshay Joshi
bdc08d94c4
Fix View Data option and column config for Foreign Tables. Fixes #2691
2017-09-18 14:32:17 +01:00
Harshal Dhumal
30e7016077
Changed array representation and formatting for the data types in Query Tool and View Data. Fixes #2671
2017-09-18 12:07:15 +05:30
Atul Sharma
788f7f3a69
Bundle fonts with pgAdmin so we have a standard set for all platforms.
...
Research by Shirley at Pivotal.
2017-09-13 16:01:14 +01:00
Teng Zhang
512afd6618
Highlighting greenplum keywords in sql editor
2017-09-11 19:39:50 +05:30
Sarah McAlear
b585063a26
Refactor keyboard shortcut functions in the query tool. Fix some incorrect keycodes and update docs.
...
Initial work by Sarah & Violet @ Pivotal, with additional tweaks by Murtuza @ EDB.
2017-08-21 15:27:29 +01:00
Hao Wang
5141debae7
UX improvements of the history in the query tool.
...
- Added copy button for query text.
- Historical queries are binned/grouped by day.
Patch By: Hao Wang, Sarah McAlear
2017-08-09 16:52:43 +05:30
Ashesh Vashi
845025db8f
Some cosmetic changes.
...
- Loading 'pgadmin' as 'sources/pgadmin', as found under the 'sources'
reference directory to be consistent with other files.
- Removed the 'pgadmin' reference from the base.html template.
- Renamed 'pgadmin.slickgrid.editors.js', and
'pgadmin.slickgrid.formatters.js' as 'editors.js', and 'formatters.js'
respectively, as they're already in the 'pgadmin/static/js/slickgrid'
directory.
- Removed the duplicate entry of 'translations' from the webpack.shim.js
2017-08-09 16:52:12 +05:30
Murtuza Zabuawala
ef48c2ed91
Fixed issue in query tool where messages were not displaying from functions/procedures properly. Fixes #2555
2017-08-04 15:50:39 +05:30
Akshay Joshi
e506fa1dbe
Improved alertify notification logic. Remove AlertifyWrapper class and extend notification methods in alertify itself.
2017-07-31 18:59:44 +05:30
Surinder Kumar
6d5417709c
Moved the javascripts of different modules from 'templates' to 'static' directory.
...
Moving the javascripts for the following modules:
- About
- Browser nodes
- Dashboard
- FileManager
- Vendor/snap.svg
- Preferences
- Settings
- Backup
- Datagrid
- Debugger
- Sqleditor
- Grant Wizard
- Import & Export
- Maintenance
- Restore and
- User Management
2017-07-27 17:25:08 +05:30
Surinder Kumar
03657df82a
Ensure babel-polyfill is loaded in older qWebKits. Fixes #2593
2017-07-21 16:15:03 +01:00
Sarah McAlear
86dc1e81f1
Move Query Tool keyboard shortcut code into a new module and add tests.
2017-07-20 22:22:25 +01:00
Matthew Kleiman
21bfcd83f4
Allow navigation of query history using the arrow keys. Fixes #2590
2017-07-20 20:47:40 +01:00
Harshal Dhumal
54882e061c
Don't attempt to render binary data in the query tool result grid. Fixes #2080 . Fixes #2074 .
2017-07-20 13:09:47 +01:00
Dave Page
1e1a9f2cf4
Add controls and shortcuts for commenting/uncommenting code in the SQL Editor. Fixes #2456 .
...
Take the opportunity to tidy up the menus and add access keys to appropriate buttons.
2017-07-19 11:43:45 +01:00
Surinder Kumar
4a91bcde30
Webpack all the things! Fixes #2135
...
This significantly speeds up loading of the application; in an average of 3 tests, v1.6
loaded in 11.5s in the runtime on a Mac, whilst the webpacked version of the code
loaded in 5.53s.
2017-07-18 15:13:17 +01:00
Harshal Dhumal
8bbcf0ab36
Fix handline of large file uploads and properly show any errors that may occur. Fixes #2153
2017-07-17 10:51:26 +01:00
Dave Page
ec739b3392
Revert "Open query tool and debugger windows in new tabs by default."
...
This reverts commit 1a6fe946ce
.
This is going to break the regression tests, so reverting it for now.
2017-07-07 17:06:12 +01:00
Dave Page
1a6fe946ce
Open query tool and debugger windows in new tabs by default.
2017-07-07 16:53:45 +01:00
Harshal Dhumal
fc78202600
Fix clear history.
2017-07-07 15:51:06 +01:00
Matthew Kleiman
e2cbaaef71
UI tweaks for the query history.
2017-07-06 13:08:29 +01:00
Harshal Dhumal
76939e4f63
Prompt the user to save dirty queries rather than discard them for a more natural workflow. Fixes #1972
2017-07-04 23:39:10 +01:00
Khushboo Vashi
f6b879233c
Fix deletion of table rows with the column definition having NOT NULL TRUE and HAS NO DEFAULT VALUE. Fixes #2527
2017-07-03 15:49:59 +01:00
Harshal Dhumal
4e21cdb64b
Fix a syntax error in the SQL Editor.
2017-07-03 11:02:20 +01:00
Murtuza Zabuawala
1e427890de
Fix an issue where duplicate entry is made of successful executed query, one with status message and one without status message.
2017-07-03 11:00:42 +01:00
Joao Pedro De Almeida Pereira
2a30a86e7d
Update alertify alerts to use the styling defined in the styleguide.
2017-06-30 10:21:05 +01:00
Harshal Dhumal
7389744ecf
A number of minor cleanups to the recent changes to the query tool.
2017-06-28 09:49:39 -04:00
Joao Pedro De Almeida Pereira
7f55412059
Overhaul the query history tab to allow browsing of the history and full query text. Fixes #2282
...
Patch by Joao and the team at Pivotal.
2017-06-27 10:55:57 -04:00
Murtuza Zabuawala
1b49bb8b22
Add preferences to enable brace matching and brace closing in the SQL editors. Fixes #2513
2017-06-27 09:57:38 -04:00
Harshal Dhumal
c65158312d
Use on-demand loading for results in the query tool. Fixes #2137
...
With a 27420 row query, pgAdmin III runs the query in 5.873s on my laptop. pgAdmin 4 now takes ~1s.
2017-06-27 09:03:04 -04:00
Surinder Kumar
cfb4b11573
Use client-side url_for in the sql editor and data grid modules.
2017-06-26 07:43:03 -04:00
Matthew Kleiman
94aa5487fb
Update Slickgrid to 2.3.7. As this version includes all the features we need, it can be moved out of the vendor directory and we'll use yarn to pull it in.
2017-06-23 09:35:56 +01:00
Surinder Kumar
fdc9eed514
Ensure text editors render in an appropriate place on the results grid. Fixes #2477
2017-06-14 12:18:27 +01:00
Surinder Kumar
57d866f7b7
Use a more sensible name for Query Tool tabs. Fixes #2482
2017-06-13 11:34:24 +01:00
Shruti B Iyer
1208206bc0
Initial re-vamp of the History tab.
2017-06-13 09:50:41 +01:00
Murtuza Zabuawala
3743c6e86e
Refresh the SQL editor view on resize to ensure the contents are re-rendered for the new viewport. Fixes #2078
2017-06-12 13:25:52 +01:00
Surinder Kumar
49976b1934
Fine tune result grid column sizing now we don't have checkboxes.
2017-06-09 09:24:20 +01:00
Surinder Kumar
73c6f1ca3b
A little leanup of the styling of the edit grid
2017-06-08 17:06:34 +01:00
Sarah McAlear
01bfa88309
Improvements to the Query Results grid:
...
- Improve the UI
- Allow copy/paste from sets of rows, columns or arbitrary blocks of cells
Patch by Matt, Shruti, Joao and Sarah @ Pivotal
Fixes #2476
2017-06-08 13:31:36 +01:00
Surinder Kumar
2fddf750e6
Retain column sizing in the query tool results grid when the same query is re-run multiple times in a row. Fixes #1971
2017-06-08 12:41:56 +01:00
George Gelashvili
8d8e7dab3c
Extract row staging into it's own module with tests.
2017-06-07 14:17:10 +01:00