- Base font size changed from 0.815rem to 0.875rem, for navbar from 0.875rem to 0.925rem.
- Dialog sizes made consistent throughout the application. Now there are 3 size options for width and height each - sm, md, lg. Combination of any of these to be used hereafter
- Alignment fix for controls of Node properties dialogs which includes showing text and label in one line without dialog size change, checkbox alignment, switch control alignment at places and other minor improvements in other dialogs
- Error message design change in dialogs validation
- SQL Editor data grid editor popup design changes which were missed
- Design change for dashboard server activity grid
- Login page language dropdown color fix
- Properties accordion collapse design fix
- Help, Info icon fixed across all dialogs which were not working if clicked exactly on the text
- Added missing icon with buttons at few places
- Shadow behind the dialogs is increased to make it look clearly separated and depth.
- Control Alignment fix in maintenance dialog
- Min height of alertify dialogs set for better UX
- File dialog design fix when no files found
- Grant wizard fixes - Scroll bar visibility on first page, use full space for SQL generated on the last page
- Browser toolbar buttons changed to sync with SQL editor toolbar buttons
- Rounded corners for docker floating dialog (no properties)
- Renaming file in file dialog should show original file name
- SQL data grid text edit popup buttons behaviour was swapped. This is fixed.
- Import/Export dialog changes as per new design.
Changed the SCSS/CSS for the below third party libraries to adopt the
new look 'n' feel:
- wcDocker
- Alertify dialogs, and notifications
- AciTree
- Bootstrap Navbar
- Bootstrap Tabs
- Bootstrap Drop-Down menu
- Backgrid
- Select2
Adopated the new the look 'n' feel for the dialogs, wizard, properties,
tab panels, tabs, fieldset, subnode control, spinner control, HTML
table, and other form controls.
- Font is changed to Roboto
- Using SCSS variables to define the look 'n' feel
- Designer background images for the Login, and Forget password pages in
'web' mode
- Improved the look 'n' feel for the key selection in the preferences
dialog
- Table classes consistency changes across the application
- File Open and Save dialog list view changes
Author(s): Aditya Toshniwal & Khushboo Vashi
- Removed 'collapse in' css from wizard as we have 'collapse show' in Bootstrap-4
- Fixed 'Select/Unselect All' button layout for Select2 control used in pgAgent.
date/time and exception. Fixes#3638
- Fixed syntax error.
- Update/Delete exceptions are not working, SQL is wrong.
- Wrong exception time is shown, it should shown in UTC as datatype of
the column is timestamp with out timezone.
- Added test cases for Schedule and Steps of pgAgent Job.
1) Changes required for working with Bootstrap 4.
2) Change to fix the timeout exception when waiting for element (tested multiple times on multiple server, did not occur to me thereafter)
3) Removed reset layout after each test case. Instead, delete the layout entry from sqlite db file and do a plain refresh. This will save some time and will also remove dependency on reset layout menu.
4) Disables tree state saving when feature test run starts. Feature tests got confused with auto expanding tree.
- Move the duplicate code for closing the background process dialog into 'test_gui_helper.py',
- Simplify the logic by removing the duplicate steps to insert/update binary paths for each server type from 'test_utils.py'.
1779 of 1994 messages (89%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1994 of 1994 messages (100%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1781 of 1994 messages (89%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1405 of 1994 messages (70%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
1449 of 1994 messages (72%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1782 of 1994 messages (89%) translated in pgadmin/translations/ko/LC_MESSAGES/messages.po
1994 of 1994 messages (100%) translated in pgadmin/translations/fr/LC_MESSAGES/messages.po
1835 of 1994 messages (92%) translated in pgadmin/translations/es/LC_MESSAGES/messages.po
1779 of 1994 messages (89%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1994 of 1994 messages (100%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1781 of 1994 messages (89%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1405 of 1994 messages (70%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
1449 of 1994 messages (72%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1782 of 1994 messages (89%) translated in pgadmin/translations/ko/LC_MESSAGES/messages.po
1903 of 1994 messages (95%) translated in pgadmin/translations/fr/LC_MESSAGES/messages.po
1835 of 1994 messages (92%) translated in pgadmin/translations/es/LC_MESSAGES/messages.po
2. Ensure backup should work with '--data-only' and '--schema-only' for any format. Fixes#3347
3. Added supported "Dump Options" for "pg_dumpall" which was not there since pgAdmin 3.
4. Fixed issue where "--clean" should not clubbed with "--data-only" while taking backup.
5. Fixed "--oids" should not clubbed with "--inserts" or "--column-inserts" while taking backup.
As sessions in pgAdmin4 are filesystem based session, they need locking
for avoiding the access from multiple threads, specially running as an
WSGI application.
Fixes#3547
- Filter for the grids were showing on the server level dashboard.
It was regression of the commit-id: f7e43d5e5
- Mark 'is_server_dashboard', and 'is_database_dashboard' to false, when
the node has its own dashboard URL defined.
the graph data.
- Dashboard is intereseted only on the current selected object in the
browser tree. And, not the one, which was got disconnected.
- Disable the auto-collection of data selectively, and only when the
selected object got disconnected, and not when changing back to the
Dashboard panel (as per Aditya).
1. EPAS packages' function/procedure does not honour INOUT arguments, it converts INOUT to OUT.
2. Packages' functions and procedures are not getting listed in their respected nodes in some scenarios like procedure having INOUT argument and function with void return type
3. The Reverse engineering SQL is not correct for Packages' functions/procedures
4. In case of INOUT argument, debugger asks for mendatory input which should not.
5. Re-executing a procedure whilst direct debugging doesn't work.
- Fix the RM #3446 "plpgsql keyword should displayed in SQL pane for EPAS-11".
- Procedures for EPAS 11 always created as 'edbspl', even though language is sql or plpgsql.
- Not able to create Function/Procedure/Trigger function if the language is "C" for all supported database server.
- Function creation for EPAS 9.6 and above when set "Window?" flag to "Yes".
- Disable Volatility, Strict, Parallel, Estimated cost and Leak prof while creating procedures in EPAS 11 when language is not 'edbspl'.
- Rename "default" folder to "11_plus" inside "pg" directory for procedures, as procedures are supported from PG11 onwards.
- Creating/Deleting parameter in Procedure for PG 11.
- Drop procedures with arguments for PG/EPAS 11.
pg_proc table has added default value 'v' for Volatility, 100 for Cost and 'u' for Parallel for any language. All the three are not supported for Procedures in PG/EPAS 11 (excluding 'edbspl' language for EPAS). Fixed the issue where it is visible in properties panel if we create procedure using language 'plpgsql' or 'sql'.
1455 of 1984 messages (73%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1910 of 1984 messages (96%) translated in pgadmin/translations/fr/LC_MESSAGES/messages.po
1941 of 1984 messages (97%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1789 of 1984 messages (90%) translated in pgadmin/translations/ko/LC_MESSAGES/messages.po
1785 of 1984 messages (89%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1787 of 1984 messages (90%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1411 of 1984 messages (71%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
Highlights of this patch include:
- Changes will affect SQL Editors in Create dialog boxes, SQL tab of the main screen, Query tool, History entries in the query tool, Query tool opened in New Tab/Window
- All the components of SQL editor will refer to single source of preferences which is cached in the Browser object. All other redundant ajax get preference calls are removed.
- SQL editor will not refer template JS variables anymore, once all the references are removed the template variables will also be removed.
- Code refactoring wherever possible.
- Covered JS test cases wherever possible.
1459 of 2000 messages (72%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1930 of 2000 messages (96%) translated in pgadmin/translations/fr/LC_MESSAGES/messages.po
1961 of 2000 messages (98%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1796 of 2000 messages (89%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1798 of 2000 messages (89%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1415 of 2000 messages (70%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
Extract some of the ACI Tree functionalities, and decouple it from the
main source. Also - create some abstractions from the repeated code
around the enable/disable the schema children object create/edit/delete
functionalities, and also created the dialog wrappers for backup and
restore dialogs.
Reviewed by: Khushboo and Ashesh
Refactored by: Ashesh
When you disconnect the server with an open sqleditor tab, exception
occurs at the back end. Also, after connecting server, the sqleditor
is not able to connect back because of the exception.
This is the first version of our Tree implementation. At this point is a
very simple tree without no abstractions and with code that eventually
is not very performant, but this is only the first iteration and we are
trying to follow the 'Last Responsible Moment Principle' [1].
Implemention details:
- Creation of PGBrowser.treeMenu
- Initial version of the Tree Adaptor 'pgadmin/static/js/tree/tree.js'
- TreeFake test double that can replace the Tree for testing purposes
- Tests, As an interesting asside because Fake’s need to behave like
the real object you will noticed that there are tests for this type
of double and they the same as of the real object.
[1] https://medium.com/@aidanjcasey/guiding-principles-for-an-evolutionary-software-architecture-b6dc2cb24680
Patched by: Victoria && Joao
Reviewed by: Khushboo & Ashesh
